)]}'
{"id":"openstack%2Fnova~785584","triplet_id":"openstack%2Fnova~stable%2Fvictoria~Iba40c2df72228b461767d5734d5a62403d9f2cfa","project":"openstack/nova","branch":"stable/victoria","topic":"bug/1917619","attention_set":{},"removed_from_attention_set":{"10135":{"account":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"last_update":"2024-03-05 18:59:23.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Iba40c2df72228b461767d5734d5a62403d9f2cfa","subject":"libvirt: Simplify device_path check in _detach_encryptor","status":"ABANDONED","created":"2021-04-09 09:18:36.000000000","updated":"2024-03-05 18:59:23.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d5953e5cf0201c6052c17417a54c6a00d0790d7a","_number":785584,"virtual_id_number":785584,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-04-27 10:22:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2021-07-12 19:23:20.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-09 11:08:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-09 14:27:37.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-04-11 01:20:04.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-07-12 19:23:20.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"ee8a1c3d229be098833682b62e0b451491e8791a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-04-09 09:18:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"01724c27df95f48432852d9a4039a91ef0ba0f12","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 11:08:16.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/bfe038922e4f4923a021197ef9e59875 : SUCCESS in 1h 13m 53s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4f2f52bfdeea475badaec73a50118b6d : SUCCESS in 17m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1629167aae584afe8b1cff35165af43d : SUCCESS in 16m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6a5cb3c7b1514c2c89e7d73a86f0e12a : FAILURE in 9m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a2a17f0742764e89a46ada3b5d14d41d : SUCCESS in 13m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1d47214e4bf5453cbfff59678eb4b64a : SUCCESS in 13m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d2681646477c44ae893c72a0c3f36e02 : SUCCESS in 12m 30s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/b0030a0c7578425181d5fdbf0ae809d7 : SUCCESS in 1h 20m 29s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/2ee0ef8f95ff4e2896faa542622b493f : FAILURE in 1h 42m 28s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/4755e93e2e7d49269f2e79262855f788 : SUCCESS in 1h 08m 51s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/3ce48b060e39482f9f2a76b31163f76e : SUCCESS in 56m 19s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/1a351dabfe73443e8c93794402c7669a : FAILURE in 58m 55s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/823a90586b8340569e8c378106e9d1bd : SUCCESS in 1h 47m 18s\n- nova-next https://zuul.opendev.org/t/openstack/build/d6728c69a08a4d0eb608f83a2d0254ec : SUCCESS in 1h 35m 47s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/96965195ef7a4a25be0a4de7359e8685 : SUCCESS in 15m 37s\n- grenade https://zuul.opendev.org/t/openstack/build/f8db478185a6444a872bef613712e58c : SUCCESS in 46m 10s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e2b835fed5fa4b759a1af27b2b7dc487 : SUCCESS in 48m 42s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c1592f3b02784e8e8b5c2beecfe89a9f : SUCCESS in 53m 48s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/023e9aca81464637a19485d84b8ce2ec : SUCCESS in 24m 28s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/1eace3b56aee4fc9bf4dd3e769260515 : SUCCESS in 41m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"37f91a5b669c8319a38d6a4de440b365f8b2c127","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-04-09 14:27:37.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/785584/1/iscsi : SUCCESS in 2h 49m 15s","accounts_in_message":[],"_revision_number":1},{"id":"dd945ddc7b1bff23f9b31bf8858cc51d705cfcf4","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-04-11 01:20:04.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/84/785584/1/check/tempest-dsvm-full-focal-py3/83dd21c/ : TIMED_OUT in 3h 12m 40s","accounts_in_message":[],"_revision_number":1},{"id":"b1095ac2cc99ae17d2a06ff2352dfb0fcfc26f93","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-04-26 14:50:04.000000000","message":"Topic set to bug/1917619","accounts_in_message":[],"_revision_number":1},{"id":"10b6b72e51489812298ac0430f2cb25e5899dc24","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-04-27 08:09:19.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"0f9187eb4a9a877cb0467b69dc3da33ac55858bc","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-04-27 10:18:45.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/84/785584/1/check/tempest-dsvm-full-focal-py3/fc572e9/ : SUCCESS in 1h 49m 58s","accounts_in_message":[],"_revision_number":1},{"id":"7731ecccc1bd804478174fca049f08e5352d6b4d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-27 10:22:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/a317989b1b2e407ebc4365b280ff3684 : SUCCESS in 1h 17m 22s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/43142d7026b040d7aed0d04cd1c929f0 : SUCCESS in 19m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5fae5b93f41d40ad81bc6d4f7c8e7cb6 : SUCCESS in 17m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ba40a47de23a448980115b42a53500b1 : SUCCESS in 8m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1bbe239f481848fca8ba7dc82a4a8667 : SUCCESS in 13m 03s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/91a48b1f872740068160bf913369e9bb : SUCCESS in 13m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c585f9dfdb104876ae548ff736dc97b4 : SUCCESS in 10m 12s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/b3986947f45145d381d3e583e70c1518 : SUCCESS in 2h 09m 57s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/410424d5ea9a462bb2e0e9b9942b64ef : SUCCESS in 1h 18m 08s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/a89afe94bf7e401e8fcd5f93ff51dde0 : SUCCESS in 1h 26m 52s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/5e0f068fa13844f2b2ffd2a7a809b48c : SUCCESS in 52m 51s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/9c197a7c465f46d5bffbffd818e92183 : SUCCESS in 52m 53s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/ae370f58c80e4b7f8e6b7cb5b2f35e2a : SUCCESS in 1h 23m 18s\n- nova-next https://zuul.opendev.org/t/openstack/build/554eb117eb334fab9a1988f40e870cfd : SUCCESS in 1h 26m 38s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/fadb6748e5a64aab9b8a2bb5baec4502 : SUCCESS in 17m 24s\n- grenade https://zuul.opendev.org/t/openstack/build/611dbeaedcc64af29f4e8f4ac8d9d316 : SUCCESS in 58m 42s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/247785acbe7941c1b94ab03a7339ab50 : SUCCESS in 53m 48s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f3700c8a8c954a0eb45b23f9ceb9efd8 : SUCCESS in 55m 45s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/590ecf39d6f44e39990771796501e5c6 : SUCCESS in 34m 24s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/111858ce46a547719e8b444df437d85a : SUCCESS in 39m 54s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d948dba5cdb84796b38da68d729d6797eead32d1","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-07-12 19:23:20.000000000","message":"Patch Set 1: Code-Review+2\n\nClean cherry pick from wallaby, where the patch has merged. LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"d5953e5cf0201c6052c17417a54c6a00d0790d7a","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-03-05 18:59:23.000000000","message":"Abandoned\n\nstable/victoria branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"67de26776c23dddf906eab30daaecdf401abbdc4","revisions":{"67de26776c23dddf906eab30daaecdf401abbdc4":{"kind":"REWORK","_number":1,"created":"2021-04-09 09:18:36.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/84/785584/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/84/785584/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/84/785584/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/84/785584/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/84/785584/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/84/785584/1"}}},"commit":{"parents":[{"commit":"24595b6ca981ad8342cde691218cbc39b323144b","subject":"Merge \"api: Log os-resetState as an instance action\" into stable/victoria","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/24595b6ca981ad8342cde691218cbc39b323144b"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-03 12:33:49.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-04-09 09:18:08.000000000","tz":60},"subject":"libvirt: Simplify device_path check in _detach_encryptor","message":"libvirt: Simplify device_path check in _detach_encryptor\n\nIntroduced by Id670f13a7f197e71c77dc91276fc2fba2fc5f314 to resolve bug\n #1821696 this check was put in place to ensure _detach_encryptor did not\nattempt to use the os-brick encryptors with an unsupported volume type\nafter libvirt secrets had been removed outside the control of Nova.\n\nWith the introduction of the [workarounds]disable_native_luksv1 via\nIa500eb614cf575ab846f64f4b69c9068274c8c1f however the use of\n_allow_native_luksv1 as part of this check is no longer valid. As this\nhelper was updated to return False when the workaround is enabled,\nregardless of the underlying volume being attached natively or not.\n\nIf an admin had enabled the workaround after users had launched\ninstances with natively attached encrypted volumes *and* the libvirt\nsecrets had gone missing _detach_encryptor would attempt to use the\nos-brick encryptors. This would fail when the underlying volume type is\nunsupported, for example rbd. See bug #1917619 for an example.\n\nThis change resolves this corner case by dropping the use of\n_allow_native_luksv1 from the check and just asserting that a\ndevice_path is present for an encrypted volume before allowing the use\nof the os-brick encryptors. As noted this is safe as calls to the\nencryptors are idempotent, ignoring failures to detach when the\nunderlying volume type is supported.\n\nCloses-Bug: #1917619\nChange-Id: Iba40c2df72228b461767d5734d5a62403d9f2cfa\n(cherry picked from commit 4908daed96ddda492ced6cbb084abe8f33a8b1f7)\n(cherry picked from commit f99f667a96a357adc0070d75b5940e76726f9664)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/67de26776c23dddf906eab30daaecdf401abbdc4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/67de26776c23dddf906eab30daaecdf401abbdc4"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}