)]}'
{"id":"openstack%2Fnova~785585","triplet_id":"openstack%2Fnova~stable%2Fussuri~Iba40c2df72228b461767d5734d5a62403d9f2cfa","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1917619","attention_set":{},"removed_from_attention_set":{"10135":{"account":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"last_update":"2024-02-07 12:54:33.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Iba40c2df72228b461767d5734d5a62403d9f2cfa","subject":"libvirt: Simplify device_path check in _detach_encryptor","status":"ABANDONED","created":"2021-04-09 09:19:10.000000000","updated":"2024-02-07 12:54:33.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"63f7b3676db0d6b1708a7344aa9b6f3fe03757ea","_number":785585,"virtual_id_number":785585,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-04-09 10:48:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-09 10:48:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-09 12:10:45.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-04-09 14:27:06.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2024-02-07 12:54:33.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"5e7d611dad918f011775980a0f1e82278b411c30","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-04-09 09:19:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"edd8a7660602610692bfd8dbe632d191d1cdd7b9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 10:48:06.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/6268b30ffc54433e99b88e3a8e447626 : SUCCESS in 1h 19m 25s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6082683557304a78a2a3ed29827d8882 : SUCCESS in 17m 12s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c1b6d30b486c458ca11272c8450264fb : SUCCESS in 16m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/436e4a60359a401790a61661e8c3d44d : FAILURE in 9m 15s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e7c1b8aa54f6431aba501a7da54e6bc6 : SUCCESS in 15m 58s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1dfe642c254c4d989acdd8167e7c0981 : SUCCESS in 16m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a5d8429a0307495c9db192d5e4839953 : SUCCESS in 11m 47s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/37a075e9ffc74bccaa4be9b441c60c79 : SUCCESS in 1h 00m 45s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/272e54a3d2d246e3b9aa2ea1e01705ca : SUCCESS in 1h 13m 10s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/f75f0e0f2f4c46bfb6eb716d1c543ecb : SUCCESS in 1h 13m 03s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/7a24d724c3b44ad0abd5a20379142989 : SUCCESS in 45m 42s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/d7c0b3270c5246e69d7ca6b7ffda5232 : SUCCESS in 51m 31s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/65c33687a0cc4ce8b50f0c05b156cccd : SUCCESS in 1h 26m 38s\n- nova-next https://zuul.opendev.org/t/openstack/build/ee4e07a5fe444221bd4a9dc26dd112d0 : SUCCESS in 1h 23m 27s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/3b49ef0e74964672be1c7dcd83239715 : SUCCESS in 17m 51s\n- grenade https://zuul.opendev.org/t/openstack/build/7504afdf76624b45948c35d7f58ff6a7 : SUCCESS in 56m 31s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/96731f076ba44f979d11b65d52baf0b2 : SUCCESS in 1h 03m 01s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/93a08819a25343efb2255126af489eeb : SUCCESS in 54m 14s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/6733475ec7224be9a8bff6764811c704 : FAILURE in 30m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8e7d1ed1c84c7387a80e366a486078479e80e742","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-04-09 12:10:45.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/85/785585/1/check/tempest-dsvm-full-bionic/00cc92d/ : SUCCESS in 2h 30m 02s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/85/785585/1/check/tempest-dsvm-full-bionic-py3/383f782/ : SUCCESS in 2h 28m 38s","accounts_in_message":[],"_revision_number":1},{"id":"e5443d65690bd21c3b94bb99e0e907fd93721d93","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-04-09 14:27:06.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/785585/1/iscsi : SUCCESS in 2h 44m 10s","accounts_in_message":[],"_revision_number":1},{"id":"25704228700a7a68a3575e6e98bce6a42e5b5094","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-04-26 14:50:19.000000000","message":"Topic set to bug/1917619","accounts_in_message":[],"_revision_number":1},{"id":"63f7b3676db0d6b1708a7344aa9b6f3fe03757ea","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-02-07 12:54:33.000000000","message":"Abandoned\n\nstable/ussuri branch of openstack/nova transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6ec67d01b0f45815ed08bce49e36fc38b6e23ec4","revisions":{"6ec67d01b0f45815ed08bce49e36fc38b6e23ec4":{"kind":"REWORK","_number":1,"created":"2021-04-09 09:19:10.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/85/785585/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/85/785585/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/785585/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/785585/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/785585/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/85/785585/1"}}},"commit":{"parents":[{"commit":"6b951f9b4d61a7c2a59c6ebbd330c0d7d4efcac0","subject":"Merge \"Add missing exception\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6b951f9b4d61a7c2a59c6ebbd330c0d7d4efcac0"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-03 12:33:49.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-04-09 09:18:47.000000000","tz":60},"subject":"libvirt: Simplify device_path check in _detach_encryptor","message":"libvirt: Simplify device_path check in _detach_encryptor\n\nIntroduced by Id670f13a7f197e71c77dc91276fc2fba2fc5f314 to resolve bug\n #1821696 this check was put in place to ensure _detach_encryptor did not\nattempt to use the os-brick encryptors with an unsupported volume type\nafter libvirt secrets had been removed outside the control of Nova.\n\nWith the introduction of the [workarounds]disable_native_luksv1 via\nIa500eb614cf575ab846f64f4b69c9068274c8c1f however the use of\n_allow_native_luksv1 as part of this check is no longer valid. As this\nhelper was updated to return False when the workaround is enabled,\nregardless of the underlying volume being attached natively or not.\n\nIf an admin had enabled the workaround after users had launched\ninstances with natively attached encrypted volumes *and* the libvirt\nsecrets had gone missing _detach_encryptor would attempt to use the\nos-brick encryptors. This would fail when the underlying volume type is\nunsupported, for example rbd. See bug #1917619 for an example.\n\nThis change resolves this corner case by dropping the use of\n_allow_native_luksv1 from the check and just asserting that a\ndevice_path is present for an encrypted volume before allowing the use\nof the os-brick encryptors. As noted this is safe as calls to the\nencryptors are idempotent, ignoring failures to detach when the\nunderlying volume type is supported.\n\nCloses-Bug: #1917619\nChange-Id: Iba40c2df72228b461767d5734d5a62403d9f2cfa\n(cherry picked from commit 4908daed96ddda492ced6cbb084abe8f33a8b1f7)\n(cherry picked from commit f99f667a96a357adc0070d75b5940e76726f9664)\n(cherry picked from commit 67de26776c23dddf906eab30daaecdf401abbdc4)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6ec67d01b0f45815ed08bce49e36fc38b6e23ec4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6ec67d01b0f45815ed08bce49e36fc38b6e23ec4"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}