)]}'
{"id":"openstack%2Fnova~785682","triplet_id":"openstack%2Fnova~master~I0e068043d8267ab91535413d950a3e154c2234f7","project":"openstack/nova","branch":"master","hashtags":[],"change_id":"I0e068043d8267ab91535413d950a3e154c2234f7","subject":"libvirt: Ignore device already in the process of unplug errors","status":"MERGED","created":"2021-04-09 17:14:03.000000000","updated":"2021-04-15 18:31:19.000000000","submitted":"2021-04-15 18:27:08.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"785682","meta_rev_id":"111e348d8441ebadc00ae72c52e65845da024d1b","_number":785682,"virtual_id_number":785682,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-04-15 18:27:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2021-04-10 01:34:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":2,"date":"2021-04-15 12:29:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":1,"date":"2021-04-15 12:29:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-09 17:52:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-04-09 18:55:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-09 18:56:09.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-04-09 19:52:24.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-04-10 01:34:48.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2021-04-10 12:11:47.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-04-15 12:29:37.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"}],"messages":[{"id":"33039f772b1dee38d0bc277e0f7c4ee5afc98745","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-04-09 17:14:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"65d2bab40e8ecaff7c33a14d44a531c3ca88d060","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-04-09 17:18:02.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"3ccce74567f9af026661722f47f9c8895d75288d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-04-09 17:22:14.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e6d6af5489342b298606f13e626b5a7bb9aec59a","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 17:52:48.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/5ea226d47256447182987d401608077a : SUCCESS in 29m 49s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/b946037a530a4ba5a428c3ff46d95045 : SUCCESS in 25m 46s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"d79ec0b9fb26be54dc0876975ec74a4162d3c56c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 18:55:33.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/cdd7fa41240e4130b9097bbce25faa31 : SUCCESS in 1h 07m 21s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/27a2a8e088ff44ba872a52114833aa91 : SUCCESS in 16m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ae1d22ca7829449e821697292099d5ab : SUCCESS in 14m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/49723e9defe545c89212d2d5df536df0 : SUCCESS in 8m 51s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cff59015b5a649d6a1bd3f9e6d8ac62e : SUCCESS in 12m 52s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4f4ade0344184db9ae855f31bb3016fc : SUCCESS in 13m 04s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a3d3be914c85461a930bba46f101395b : SUCCESS in 14m 35s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/648de9610fcc495bb23ff4f46020c5d8 : SUCCESS in 11m 26s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/2c522d025e0e46178e40c26fef24604f : SUCCESS in 1h 09m 26s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/2e8ec2ce930b4d6e9c6e8b0d2d213dc3 : SUCCESS in 1h 12m 44s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/5c83c22220e0406787d26a2edb8932a6 : SUCCESS in 1h 00m 27s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/89e4cd96987d4e519d26fca732b9d6b6 : SUCCESS in 44m 46s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/42728e4a89b04a8fae201389cd7e3464 : SUCCESS in 47m 57s (non-voting)\n- nova-lvm https://zuul.opendev.org/t/openstack/build/4ff7bc7117464e2e84cc6c461e9c4f54 : SUCCESS in 48m 54s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/628fb3f9f12f46cab4325793a1434772 : SUCCESS in 1h 26m 01s\n- nova-next https://zuul.opendev.org/t/openstack/build/17a70096665e4960967aa8eaa93bb336 : SUCCESS in 1h 31m 09s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/ebfd511e67354abea2acfff7bb64c568 : SUCCESS in 20m 01s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/3d74ddba0cbb4a4b8eeaa54badd0c93f : SUCCESS in 18m 22s (non-voting)\n- grenade https://zuul.opendev.org/t/openstack/build/a45375c5b7ec432485a76f61082f7346 : SUCCESS in 58m 52s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c3e4b9135d984f6f8ef609cde87a4c67 : SUCCESS in 50m 01s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/8eb4e91bdab24c7e8716cfa903680ae6 : SUCCESS in 48m 47s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/4731539ffdbc4f86b76dc91b88a9d97e : SUCCESS in 31m 36s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/36cfa7ceff1f4c49b1e738982a938657 : SUCCESS in 32m 33s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"98b7229be8df55796db0931851c1cffe878f7640","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-04-09 18:56:09.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/82/785682/3/check/EMC_PowerFlex_NOVA/3f5df7c/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":3},{"id":"77802851c99c99f4e5b5fcbe136f1b7a06411910","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-04-09 19:52:24.000000000","message":"Patch Set 3:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/785682/3/iscsi : SUCCESS in 2h 28m 50s","accounts_in_message":[],"_revision_number":3},{"id":"4fb3626331074ec6e137cbac82b4bc8893817c10","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-04-10 01:34:48.000000000","message":"Patch Set 3: Code-Review+2\n\n(2 comments)\n\nLooks sensible to me. Took me awhile to understand that QEMU itself is erroneously trying another delete while a delete is already in progress.\n\nSo this patch makes sense, just catch and ignore this case and retry until the device is reported MISSING which will cause us to raise DeviceNotFound. We will continue on to disconnect the device from the host via cinder (if this is a volume) if we catch DeviceNotFound, so we won\u0027t miss that step either.","accounts_in_message":[],"_revision_number":3},{"id":"f7029f1cfff78255975ac06233dc4505c4aa5d50","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-04-10 12:11:47.000000000","message":"Patch Set 3:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/82/785682/3/check/tempest-dsvm-full-focal-py3/2bd9f23/ : TIMED_OUT in 3h 09m 16s","accounts_in_message":[],"_revision_number":3},{"id":"25518d54c2a66650179cd7c752ed2c227c3b48b1","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-04-15 12:29:37.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nOK this make sense to me. I will adapt the https://review.opendev.org/c/openstack/nova/+/770246 to handle this case too.","accounts_in_message":[],"_revision_number":3},{"id":"b31aca7f3df3fb2ec6b2ccd050f0872b9c495a02","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-15 12:30:06.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"0d3f79c2fdbce69349105702bad800fe5f7e06f8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-15 18:27:07.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/19cdd324acd947a1814384be97bd67f6 : SUCCESS in 1h 19m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b01bbb672c0b429eb1dc5b7bbaf98583 : SUCCESS in 16m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/45d21ed0d99a4d05b9664e59de1cd58e : SUCCESS in 9m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0132001a7f8649e58601daaa1ed90041 : SUCCESS in 13m 40s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e528e91d1a1e44928cba303891e84369 : SUCCESS in 13m 20s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7dfc0353acf94cd088c4e49de05ebd01 : SUCCESS in 10m 36s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/11f317856b464faea1911c7a947cfd69 : SUCCESS in 1h 14m 10s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/cdb18fe9d7b14afea5bc9265c764f9ce : SUCCESS in 44m 58s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/1941dfae1e22431787472fa4ae9e24c0 : SUCCESS in 47m 48s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a276e39846dc4fef980f3dcffe3032e8 : SUCCESS in 19m 26s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/94f29d58426242a090144b8826559a44 : SUCCESS in 1h 51m 15s\n- nova-next https://zuul.opendev.org/t/openstack/build/5ddeb11c93b042598c25619ba618bf35 : SUCCESS in 1h 54m 39s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/2d7dd6d9e0e34d6cb172731fdf55d800 : SUCCESS in 1h 17m 59s\n- grenade https://zuul.opendev.org/t/openstack/build/b2d7f6085e3d4564bdf3a200d2fb9036 : SUCCESS in 1h 03m 20s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/dd94c99c62e74ad6af42f76a6e61e8ac : SUCCESS in 1h 02m 41s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c8a206a025ce4629a68805d3c174633b : SUCCESS in 53m 05s","accounts_in_message":[],"_revision_number":3},{"id":"3a7e55eb610dba2bb4cc43ecf67ded341181c67a","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-15 18:27:08.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"111e348d8441ebadc00ae72c52e65845da024d1b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-15 18:31:19.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4dcecc19c8a14c8b8893372c659092dd : SUCCESS in 1m 06s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"0a7d3794c6dc39976b4cbfe12b1688230ac895a8","revisions":{"0f3abb573a74b8494b4ff1b4b0ea5031d1e37aa0":{"kind":"REWORK","_number":1,"created":"2021-04-09 17:14:03.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/82/785682/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/82/785682/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/785682/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/785682/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/785682/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/82/785682/1"}}},"commit":{"parents":[{"commit":"42c353bd2f1c1f1396def905e31b28ab6e216e9d","subject":"Merge \"[OVN] Adapt the live-migration job scripts to work with OVN\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/42c353bd2f1c1f1396def905e31b28ab6e216e9d"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-04-09 14:37:23.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-04-09 17:13:51.000000000","tz":60},"subject":"libvirt: Ignore device already in the process of unplug errors","message":"libvirt: Ignore device already in the process of unplug errors\n\nAt present QEMU will raise an error to libvirt when a device_del request\nis made for a device that has already partially detached through a\nprevious request. This is outlined in more detail in the following\ndownstream Red Hat QEMU bug report:\n\nGet libvirtError \"Device XX is already in the process of unplug\" [..]\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1878659\n\nWithin Nova we can actually ignore this error and allow our existing\nretry logic to attempt again after a short wait, hopefully allowing the\noriginal request to complete removing the device from the domain.\n\nThis change does this and should result in one of the following\ndevice_del requests resulting in a VIR_ERR_DEVICE_MISSING error from\nlibvirt. _try_detach_device should then translate that libvirt error\ninto a DeviceNotFound exception within Nova which is then ignored by all\ncallers detach_device_with_retry and taken to mean that the device has\ndetached successfully.\n\nCloses-Bug: #1923206\nChange-Id: I0e068043d8267ab91535413d950a3e154c2234f7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0f3abb573a74b8494b4ff1b4b0ea5031d1e37aa0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0f3abb573a74b8494b4ff1b4b0ea5031d1e37aa0"}]},"branch":"refs/heads/master"},"2d0fc6b92040287be0b140b1b31f360d6214125a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-04-09 17:18:02.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/82/785682/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/82/785682/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/785682/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/785682/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/785682/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/82/785682/2"}}},"commit":{"parents":[{"commit":"42c353bd2f1c1f1396def905e31b28ab6e216e9d","subject":"Merge \"[OVN] Adapt the live-migration job scripts to work with OVN\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/42c353bd2f1c1f1396def905e31b28ab6e216e9d"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-04-09 14:37:23.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-04-09 17:16:54.000000000","tz":60},"subject":"libvirt: Ignore device already in the process of unplug errors","message":"libvirt: Ignore device already in the process of unplug errors\n\nAt present QEMU will raise an error to libvirt when a device_del request\nis made for a device that has already partially detached through a\nprevious request. This is outlined in more detail in the following\ndownstream Red Hat QEMU bug report:\n\nGet libvirtError \"Device XX is already in the process of unplug\" [..]\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1878659\n\nWithin Nova we can actually ignore this error and allow our existing\nretry logic to attempt again after a short wait, hopefully allowing the\noriginal request to complete removing the device from the domain.\n\nThis change does this and should result in one of the following\ndevice_del requests raising a VIR_ERR_DEVICE_MISSING error from libvirt.\n_try_detach_device should then translate that libvirt error into a\nDeviceNotFound exception which is itself then ignored by all\ndetach_device_with_retry callers and taken to mean that the device has\ndetached successfully.\n\nCloses-Bug: #1923206\nChange-Id: I0e068043d8267ab91535413d950a3e154c2234f7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2d0fc6b92040287be0b140b1b31f360d6214125a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2d0fc6b92040287be0b140b1b31f360d6214125a"}]},"branch":"refs/heads/master"},"0a7d3794c6dc39976b4cbfe12b1688230ac895a8":{"kind":"REWORK","_number":3,"created":"2021-04-09 17:22:14.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/82/785682/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/82/785682/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/785682/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/785682/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/785682/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/82/785682/3"}}},"commit":{"parents":[{"commit":"42c353bd2f1c1f1396def905e31b28ab6e216e9d","subject":"Merge \"[OVN] Adapt the live-migration job scripts to work with OVN\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/42c353bd2f1c1f1396def905e31b28ab6e216e9d"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-04-09 14:37:23.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-04-09 17:22:04.000000000","tz":60},"subject":"libvirt: Ignore device already in the process of unplug errors","message":"libvirt: Ignore device already in the process of unplug errors\n\nAt present QEMU will raise an error to libvirt when a device_del request\nis made for a device that has already partially detached through a\nprevious request. This is outlined in more detail in the following\ndownstream Red Hat QEMU bug report:\n\nGet libvirtError \"Device XX is already in the process of unplug\" [..]\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1878659\n\nWithin Nova we can actually ignore this error and allow our existing\nretry logic to attempt again after a short wait, hopefully allowing the\noriginal request to complete removing the device from the domain.\n\nThis change does this and should result in one of the following\ndevice_del requests raising a VIR_ERR_DEVICE_MISSING error from libvirt.\n_try_detach_device should then translate that libvirt error into a\nDeviceNotFound exception which is itself then ignored by all\ndetach_device_with_retry callers and taken to mean that the device has\ndetached successfully.\n\nCloses-Bug: #1923206\nChange-Id: I0e068043d8267ab91535413d950a3e154c2234f7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0a7d3794c6dc39976b4cbfe12b1688230ac895a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0a7d3794c6dc39976b4cbfe12b1688230ac895a8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}
