)]}'
{"id":"openstack%2Fnova~787","triplet_id":"openstack%2Fnova~master~I77df5748ba5417b7474a90e641ecc8adc76921c2","project":"openstack/nova","branch":"master","topic":"bug/865371","hashtags":[],"change_id":"I77df5748ba5417b7474a90e641ecc8adc76921c2","subject":"Use new ip addr del syntax","status":"MERGED","created":"2011-10-03 14:27:59.000000000","updated":"2011-10-13 04:39:08.000000000","submitted":"2011-10-13 04:39:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1b2659172d606dce2d15f8a02b801f6b45502008","_number":787,"virtual_id_number":787,"owner":{"_account_id":1631,"deleted":true},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":1,"date":"2011-10-13 04:39:04.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},{"value":0,"_account_id":236,"name":"Monsyne Dragon","email":"mdragon@rackspace.com","username":"mdragon"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"date":"2011-10-13 04:25:49.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2011-10-13 04:25:45.000000000","_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"date":"2011-10-12 16:41:05.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},{"value":1,"date":"2011-10-12 20:17:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":236,"name":"Monsyne Dragon","email":"mdragon@rackspace.com","username":"mdragon"},{"value":1,"date":"2011-10-12 16:37:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},{"value":0,"_account_id":236,"name":"Monsyne Dragon","email":"mdragon@rackspace.com","username":"mdragon"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},{"value":0,"_account_id":236,"name":"Monsyne Dragon","email":"mdragon@rackspace.com","username":"mdragon"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},{"_account_id":236,"name":"Monsyne Dragon","email":"mdragon@rackspace.com","username":"mdragon"},{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-10-07 21:28:41.000000000","updated_by":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"reviewer":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"state":"REVIEWER"},{"updated":"2011-10-11 20:49:27.000000000","updated_by":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"reviewer":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"state":"REVIEWER"},{"updated":"2011-10-12 16:37:46.000000000","updated_by":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"reviewer":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"state":"REVIEWER"},{"updated":"2011-10-12 16:41:05.000000000","updated_by":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"reviewer":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"state":"REVIEWER"},{"updated":"2011-10-12 20:17:04.000000000","updated_by":{"_account_id":236,"name":"Monsyne Dragon","email":"mdragon@rackspace.com","username":"mdragon"},"reviewer":{"_account_id":236,"name":"Monsyne Dragon","email":"mdragon@rackspace.com","username":"mdragon"},"state":"REVIEWER"},{"updated":"2011-10-13 04:25:45.000000000","updated_by":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"reviewer":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"state":"REVIEWER"},{"updated":"2011-10-13 04:39:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"bd1cba1a67d76c9bf1bfc71b3edbc21a9fa3140e","author":{"_account_id":236,"name":"Monsyne Dragon","email":"mdragon@rackspace.com","username":"mdragon"},"date":"2011-10-03 17:42:05.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nGood to stay on top of this before \u0027ip\u0027 decides to drop support.","accounts_in_message":[],"_revision_number":1},{"id":"a4bfd470b8b19e0249e7d03cf24cd8871fa6f12f","author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"date":"2011-10-07 21:09:07.000000000","message":"Patch Set 1:\n\nso as far as I know, and \"man ip\" backs me up on this, the syntax for ip addr add and del coincide. Should we not add this same change to the bind_floating_ip() function as well?","accounts_in_message":[],"_revision_number":1},{"id":"4e293b01273693e5e2aa6f04e897874a0e8ac6aa","author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"date":"2011-10-07 21:28:41.000000000","message":"Patch Set 1:\n\nNo preference here really, I only get the warning when doing the delete, but I do think that it\u0027s better we be explicit now than have to change it down the road.","accounts_in_message":[],"_revision_number":1},{"id":"d345e8c14e82149dd0b2fe17c8b904fb287d1402","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-10-11 20:49:27.000000000","message":"Patch Set 1:\n\nStanislaw Pitucha,\n\nCan you update the bind code to use the new syntax as well?  (or provide justification for not doing so)","accounts_in_message":[],"_revision_number":1},{"id":"26a3e0f5181fd657fb0acab5eb73bebea98c0db2","author":{"_account_id":1631,"deleted":true},"date":"2011-10-12 12:31:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"163f71145c5d501608f9a43593a7c741219d4f7c","author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"date":"2011-10-12 16:37:46.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nlooks good to me at this point, though I\u0027m curious why the change to the authors file was dropped in patch set 2. Maybe it\u0027s already there, I\u0027m not up to speed on the HP work flow.","accounts_in_message":[],"_revision_number":2},{"id":"610142218f37204f062f9202c137a91bb115a297","author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"date":"2011-10-12 16:41:05.000000000","message":"Patch Set 2:\n\nThe change was rebased to the new master and I\u0027m already in that Authors file, so everything\u0027s fine.","accounts_in_message":[],"_revision_number":2},{"id":"2362095696786dad4dc10efb9ca0045c9f050a1d","author":{"_account_id":236,"name":"Monsyne Dragon","email":"mdragon@rackspace.com","username":"mdragon"},"date":"2011-10-12 20:17:04.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nlooks good.","accounts_in_message":[],"_revision_number":2},{"id":"2c763847e7b71ae87b5d8b9d396836e2142bb206","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-10-13 04:25:45.000000000","message":"Patch Set 2: Looks good to me, approved\n\nlgtm.","accounts_in_message":[],"_revision_number":2},{"id":"59ddd8dc1465b0114ff4171a6f2300736ed316b7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 04:25:49.000000000","message":"Patch Set 2:\n\nBuild Started https://jenkins.openstack.org/job/nova-merge/113/ (1/3)","accounts_in_message":[],"_revision_number":2},{"id":"f00957051a41a3bd1ff57eb59cacd37f0e5e038e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 04:26:17.000000000","message":"Patch Set 2:\n\nBuild Started https://jenkins.openstack.org/job/nova-pep8/1485/ (2/3)","accounts_in_message":[],"_revision_number":2},{"id":"8aa3d53b521033fb7d98515d39c5a12c20d46212","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 04:29:37.000000000","message":"Patch Set 2:\n\nBuild Started https://jenkins.openstack.org/job/nova/121635/ (3/3)","accounts_in_message":[],"_revision_number":2},{"id":"ca6f437b42b8554da0adfddb36f9b5d12c855b39","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 04:39:04.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/nova-merge/113/ : SUCCESS \nhttps://jenkins.openstack.org/job/nova-pep8/1485/ : SUCCESS \nhttps://jenkins.openstack.org/job/nova/121635/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"b8569afd94437b1ff280bdb6ae97ae4413340707","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 04:39:08.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"60b3d3fbd12f62fd2077401c12112fc48c886246","revisions":{"b4ea830dcbf8541b57306c2bd7fac8a88bb02618":{"kind":"REWORK","_number":1,"created":"2011-10-03 14:27:59.000000000","uploader":{"_account_id":1631,"deleted":true},"ref":"refs/changes/87/787/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/787/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/787/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/787/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/787/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/787/1"}}},"commit":{"parents":[{"commit":"3837f09ee0b7b0da23e1caa185f58610d30bffe6","subject":"Merge \"Fixes bug 862633 -- OS api consoles create() broken\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3837f09ee0b7b0da23e1caa185f58610d30bffe6"}]}],"author":{"name":"Stanislaw Pitucha","email":"stanislaw.pitucha@hp.com","date":"2011-09-30 14:50:29.000000000","tz":60},"committer":{"name":"Stanislaw Pitucha","email":"stanislaw.pitucha@hp.com","date":"2011-10-03 14:24:51.000000000","tz":60},"subject":"Use new ip addr del syntax","message":"Use new ip addr del syntax\n\nStart appending the /32 suffix to the addresses when removing floating IPs.\nFixes bug 865371.\n\nChange-Id: I77df5748ba5417b7474a90e641ecc8adc76921c2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b4ea830dcbf8541b57306c2bd7fac8a88bb02618"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b4ea830dcbf8541b57306c2bd7fac8a88bb02618"}]},"branch":"refs/heads/master"},"60b3d3fbd12f62fd2077401c12112fc48c886246":{"kind":"REWORK","_number":2,"created":"2011-10-12 12:31:07.000000000","uploader":{"_account_id":1631,"deleted":true},"ref":"refs/changes/87/787/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/787/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/787/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/787/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/787/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/787/2"}}},"commit":{"parents":[{"commit":"56be39aedb195576179e73c859db2271a9585496","subject":"Merge \"Further changes to the cleaner.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/56be39aedb195576179e73c859db2271a9585496"}]}],"author":{"name":"Stanislaw Pitucha","email":"stanislaw.pitucha@hp.com","date":"2011-09-30 14:50:29.000000000","tz":60},"committer":{"name":"Stanislaw Pitucha","email":"stanislaw.pitucha@hp.com","date":"2011-10-12 12:31:05.000000000","tz":60},"subject":"Use new ip addr del syntax","message":"Use new ip addr del syntax\n\nStart appending the /32 suffix to the addresses when removing floating IPs.\nFixes bug 865371.\n\nChange-Id: I77df5748ba5417b7474a90e641ecc8adc76921c2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/60b3d3fbd12f62fd2077401c12112fc48c886246"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/60b3d3fbd12f62fd2077401c12112fc48c886246"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}