)]}'
{"nova/storage/rbd_utils.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"04207a7e4b7de6c7692c27cf2833a93f5d6c613d","unresolved":true,"context_lines":[{"line_number":162,"context_line":"            # rbd_connect_timeout is siliently ignored, patch object"},{"line_number":163,"context_line":"            # and raise timeout exception"},{"line_number":164,"context_line":"            with timeout.Timeout(self.rbd_connect_timeout):"},{"line_number":165,"context_line":"                client.connect(timeout\u003dself.rbd_connect_timeout)"},{"line_number":166,"context_line":"            pool_to_open \u003d pool or self.pool"},{"line_number":167,"context_line":"            # NOTE(luogangyi): open_ioctx \u003e\u003d 10.1.0 could handle unicode"},{"line_number":168,"context_line":"            # arguments perfectly as part of Python 3 support."}],"source_content_type":"text/x-python","patch_set":1,"id":"a6c3dfef_6f71bec4","line":165,"range":{"start_line":165,"start_character":31,"end_line":165,"end_character":63},"updated":"2021-04-20 09:52:35.000000000","message":"You can drop this.","commit_id":"fe5c7fd803ec57d6f12ebe2f609105228ad3b46e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"04207a7e4b7de6c7692c27cf2833a93f5d6c613d","unresolved":true,"context_lines":[{"line_number":171,"context_line":"            ioctx \u003d client.open_ioctx(str(pool_to_open))"},{"line_number":172,"context_line":"            return client, ioctx"},{"line_number":173,"context_line":"        except (rados.Error, timeout.Timeout):"},{"line_number":174,"context_line":"            # shutdown cannot raise an exception or timeout"},{"line_number":175,"context_line":"            client.shutdown()"},{"line_number":176,"context_line":"            raise"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9958709f_616461ae","line":174,"range":{"start_line":174,"start_character":14,"end_line":174,"end_character":59},"updated":"2021-04-20 09:52:35.000000000","message":"`or timeout` doesn\u0027t make sense in this context.\n\nYou\u0027re just ensuring that shutdown, that is idempotent, is called when a timeout is hit.","commit_id":"fe5c7fd803ec57d6f12ebe2f609105228ad3b46e"}]}