)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"61702a1764ffee0a718a0329ec0d4ed6edf99447","unresolved":true,"context_lines":[{"line_number":5637,"context_line":"            ovs_agent_rp_uuid,"},{"line_number":5638,"context_line":"            {\"inventories\": {"},{"line_number":5639,"context_line":"                self.CUSTOM_NET_KILOPACKET_PER_SEC: {\"total\": 10000},"},{"line_number":5640,"context_line":"            }})"},{"line_number":5641,"context_line":""},{"line_number":5642,"context_line":"        self._set_provider_inventories("},{"line_number":5643,"context_line":"            ovs_bridge_rp_uuid,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7638e1f3_f7a8c9e4","line":5640,"updated":"2021-06-25 13:46:29.000000000","message":"The agent RP also needs to have vnic type traits.","commit_id":"17907f048abe308516303fce95c2e657340035bc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca63c0b3e7112ea5a6a1aba6023bca48c729dc4d","unresolved":true,"context_lines":[{"line_number":5520,"context_line":""},{"line_number":5521,"context_line":""},{"line_number":5522,"context_line":"class PortResourceRequestBasedSchedulingTestBase("},{"line_number":5523,"context_line":"        integrated_helpers.ProviderUsageBaseTestCase):"},{"line_number":5524,"context_line":""},{"line_number":5525,"context_line":"    compute_driver \u003d \u0027fake.FakeDriverWithPciResources\u0027"},{"line_number":5526,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"22a23d25_5ad914ec","line":5523,"updated":"2021-07-20 17:26:43.000000000","message":"Before you start on this series, what\u0027s the chances of moving these tests to their own file? This file is growing without bound and we\u0027re about to add a whole lot more stuff on top. It\u0027ll have a slight backport implication but shouldn\u0027t be too crazy","commit_id":"7ae54937c8f338d9726465381b858fbd67429171"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"df30ff1fe6c3c2af71cb4aa27c6bdff2b679da5f","unresolved":false,"context_lines":[{"line_number":5520,"context_line":""},{"line_number":5521,"context_line":""},{"line_number":5522,"context_line":"class PortResourceRequestBasedSchedulingTestBase("},{"line_number":5523,"context_line":"        integrated_helpers.ProviderUsageBaseTestCase):"},{"line_number":5524,"context_line":""},{"line_number":5525,"context_line":"    compute_driver \u003d \u0027fake.FakeDriverWithPciResources\u0027"},{"line_number":5526,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"a193951d_51e37295","line":5523,"in_reply_to":"22a23d25_5ad914ec","updated":"2021-07-22 13:19:57.000000000","message":"This file is huge, I totally agree. Lets move all the port resource request related tests to a separate one.\n\n//later \n\nThe interactive rebase of this move was interesting. As every later patch in this series modifies the part of the test_servers.py that was moved now to test_servers_resource_request.py. Git only follow file renames and moves, but not partial content move. So all those patches got in merge conflict with the new base where the content is moved away from test_servers. After some googling I ended up doing the following to avoid the manual work resolving these trivial but tiresome conflicts: \n\n  $ git rebase -i \u003cbefore-this-patch\u003e # with stopping at before this patch\n  $ # do the partial code move and create a separate commit out of it\n  # repeat until rebase finished:\n    $ git rebase --continue # it stops with the next patch touching test_severs with a conflict\n    $ git reset --hard HEAD  # step the interactive rebase backwards\n    # download the patch file from gerrit for the conflicting patch \u003e a.patch\n    $ sed -i \u0027s/test_servers.py/test_servers_resource_request.py/g a.patch\n    $ git am .patch\n  # done","commit_id":"7ae54937c8f338d9726465381b858fbd67429171"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f9bb7f0ec70747ebdef6eef711e42ac21b7716b6","unresolved":true,"context_lines":[{"line_number":5534,"context_line":"    PF2 \u003d \u0027pf2\u0027"},{"line_number":5535,"context_line":"    PF3 \u003d \u0027pf3\u0027"},{"line_number":5536,"context_line":""},{"line_number":5537,"context_line":"    # TODO(gibi): use the standard resource from orc when that is merges"},{"line_number":5538,"context_line":"    NET_PACKET_RATE_KILOPACKET_PER_SEC \u003d orc.NET_PACKET_RATE_KILOPACKET_PER_SEC"},{"line_number":5539,"context_line":""},{"line_number":5540,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f5deee9_597818d6","line":5537,"updated":"2021-07-20 16:54:17.000000000","message":"This TODO doesn\u0027t make sense. Aren\u0027t you using the standard resource here?","commit_id":"7ae54937c8f338d9726465381b858fbd67429171"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"df30ff1fe6c3c2af71cb4aa27c6bdff2b679da5f","unresolved":false,"context_lines":[{"line_number":5534,"context_line":"    PF2 \u003d \u0027pf2\u0027"},{"line_number":5535,"context_line":"    PF3 \u003d \u0027pf3\u0027"},{"line_number":5536,"context_line":""},{"line_number":5537,"context_line":"    # TODO(gibi): use the standard resource from orc when that is merges"},{"line_number":5538,"context_line":"    NET_PACKET_RATE_KILOPACKET_PER_SEC \u003d orc.NET_PACKET_RATE_KILOPACKET_PER_SEC"},{"line_number":5539,"context_line":""},{"line_number":5540,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"b6108640_21fb5640","line":5537,"in_reply_to":"5f5deee9_597818d6","updated":"2021-07-22 13:19:57.000000000","message":"I forgot to remove the TODO when I changed this patch to use the standard rc from the lib","commit_id":"7ae54937c8f338d9726465381b858fbd67429171"}],"nova/tests/functional/test_servers_resource_request.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a384d6571c875df37b0a9ca9fd5b40649b88ab9a","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    PF2 \u003d \u0027pf2\u0027"},{"line_number":61,"context_line":"    PF3 \u003d \u0027pf3\u0027"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    NET_PACKET_RATE_KILOPACKET_PER_SEC \u003d orc.NET_PACKET_RATE_KILOPACKET_PER_SEC"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def setUp(self):"},{"line_number":66,"context_line":"        # enable PciPassthroughFilter to support SRIOV before the base class"}],"source_content_type":"text/x-python","patch_set":11,"id":"c6f74937_b7896013","line":63,"updated":"2021-07-23 15:59:33.000000000","message":"nit: you removed the nit but you could have removed this too and just referenced the import from os-resource-classes directly below","commit_id":"c258010527abd25fd00da5bdb2f0f2d6b132eafd"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"43b4056773bbbfac9e7b2ca80def1350c7270fe2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    PF2 \u003d \u0027pf2\u0027"},{"line_number":61,"context_line":"    PF3 \u003d \u0027pf3\u0027"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    NET_PACKET_RATE_KILOPACKET_PER_SEC \u003d orc.NET_PACKET_RATE_KILOPACKET_PER_SEC"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def setUp(self):"},{"line_number":66,"context_line":"        # enable PciPassthroughFilter to support SRIOV before the base class"}],"source_content_type":"text/x-python","patch_set":11,"id":"2bb5e7cc_1d34182b","line":63,"in_reply_to":"c6f74937_b7896013","updated":"2021-08-16 19:30:44.000000000","message":"Done","commit_id":"c258010527abd25fd00da5bdb2f0f2d6b132eafd"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"43b4056773bbbfac9e7b2ca80def1350c7270fe2","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            \u0027/resource_providers\u0027, body\u003dovs_bridge_req, version\u003d\u00271.20\u0027)"},{"line_number":159,"context_line":"        self.ovs_bridge_rp_per_host[compute_rp_uuid] \u003d ovs_bridge_rp_uuid"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        self._create_resource_class(self.NET_PACKET_RATE_KILOPACKET_PER_SEC)"},{"line_number":162,"context_line":"        self._set_provider_inventories("},{"line_number":163,"context_line":"            ovs_agent_rp_uuid,"},{"line_number":164,"context_line":"            {\"inventories\": {"}],"source_content_type":"text/x-python","patch_set":11,"id":"46efd9a0_76c33615","line":161,"updated":"2021-08-16 19:30:44.000000000","message":"that is not needed now that this is a standard RC in the lib.","commit_id":"c258010527abd25fd00da5bdb2f0f2d6b132eafd"}]}