)]}'
{"nova/tests/fixtures/neutron.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0d88a2c4298acedf844dd603d57465566a072176","unresolved":true,"context_lines":[{"line_number":945,"context_line":"        self._subnets["},{"line_number":946,"context_line":"            self.subnet_2[\u0027id\u0027]] \u003d self.subnet_2"},{"line_number":947,"context_line":"        macvtap \u003d self.port_macvtap_with_resource_request"},{"line_number":948,"context_line":"        self._ports[macvtap[\u0027id\u0027]] \u003d copy.deepcopy(macvtap)"}],"source_content_type":"text/x-python","patch_set":10,"id":"6467c759_4f11c4e8","line":948,"updated":"2021-07-20 16:57:05.000000000","message":"Any reason for this to live here rather than locally in \u0027test_servers.py\u0027? This is a common module so it doesn\u0027t really make sense to specify here unless this is widely useful","commit_id":"c59f7d9a8f819bea313370f2e0925f11dd04dc21"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e5b29118e00a83e2955c04cacb917bbdb1388885","unresolved":false,"context_lines":[{"line_number":945,"context_line":"        self._subnets["},{"line_number":946,"context_line":"            self.subnet_2[\u0027id\u0027]] \u003d self.subnet_2"},{"line_number":947,"context_line":"        macvtap \u003d self.port_macvtap_with_resource_request"},{"line_number":948,"context_line":"        self._ports[macvtap[\u0027id\u0027]] \u003d copy.deepcopy(macvtap)"}],"source_content_type":"text/x-python","patch_set":10,"id":"6ee302a3_b7bd2a33","line":948,"in_reply_to":"6467c759_4f11c4e8","updated":"2021-07-22 13:20:02.000000000","message":"I\u0027m not 100% sure I won\u0027t get a comment later why the fixtures are not living in the common fixture module :) One reasoning behind that would be that if neutron changes behavior then we need to change all the neutron fixtures to adapt to the new behavior and for that we need to find all the neutron fixtures we have. So I can imagine that one way to organize the code is that one external interface might need one set of fixtures to fake the interface and then that one set can live in the fixtures.\u003cinteface-name\u003e module.\n\nBut sure I can move this to the test_servers_resoure_request module. That totally make sense from usage perspective.","commit_id":"c59f7d9a8f819bea313370f2e0925f11dd04dc21"}]}