)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fcffc96408b5c6b4748284543454559348ddc348","unresolved":true,"context_lines":[{"line_number":7,"context_line":"os-assisted-volume-snapshots: mention Hyper-V usage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The docs state that this API is only implemented by the libvirt"},{"line_number":10,"context_line":"driver, but it\u0027s also used by the out of tree Hyper-V driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We\u0027re adding a note about Hyper-V, which will be useful as this"},{"line_number":13,"context_line":"API is about to become supersededed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"633efa9c_2f99f78d","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":60},"updated":"2021-04-21 18:00:30.000000000","message":"This doesn\u0027t seem valid for our in tree documentation to refer to an out of tree driver. The out of tree Hyper-V driver uses os-assisted-volume-snapshots but the in tree Hyper-V driver does not? As an aside, I\u0027m curious what\u0027s the reason for that.","commit_id":"3022715f0e45eb973b68d7ae3b768c7893939bb5"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"fc3ba87af2d418d3a2d9ced53ac3f89d4d09c5fc","unresolved":true,"context_lines":[{"line_number":7,"context_line":"os-assisted-volume-snapshots: mention Hyper-V usage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The docs state that this API is only implemented by the libvirt"},{"line_number":10,"context_line":"driver, but it\u0027s also used by the out of tree Hyper-V driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We\u0027re adding a note about Hyper-V, which will be useful as this"},{"line_number":13,"context_line":"API is about to become supersededed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c91f9a6c_2ba9bc57","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":60},"in_reply_to":"633efa9c_2f99f78d","updated":"2021-04-22 06:58:44.000000000","message":"Someone asked for it here: https://etherpad.opendev.org/p/nova-cinder-xena-ptg. Also, it might be an useful information as this API is about to be deprecated.\n\nIt\u0027s true that it\u0027s an out of tree driver, but this also mentions the remotefs Cinder driver, which isn\u0027t part of Nova either.\n\nAs to why the the out of tree driver has this feature and the in-tree one doesn\u0027t, we went with an out of tree driver back in 2016 as it was taking way too long to have our patches reviewed, thus missing releases on a regular basis. As the codebase diverged, it became more and more difficult for us to submit patches to both drivers, so the in-tree driver only receives critical bug fixes or simple features that are worth adding to the release notes (e.g. RBD support in Wallaby).\n\nNone of our customers use the in-tree driver, but we do keep it alive (including the CI) so that Nova continues to officially support Hyper-V. The circumstances may have changed now, but sync-ing the drivers at this point would probably require significant effort, mostly on the reviewing side.","commit_id":"3022715f0e45eb973b68d7ae3b768c7893939bb5"}]}