)]}'
{"id":"openstack%2Fnova~787415","triplet_id":"openstack%2Fnova~master~Ic408c80ad5dff4162ac8519b049ed7311c15fb5b","project":"openstack/nova","branch":"master","hashtags":[],"change_id":"Ic408c80ad5dff4162ac8519b049ed7311c15fb5b","subject":"os-assisted-volume-snapshots: mention Hyper-V usage","status":"ABANDONED","created":"2021-04-21 16:15:24.000000000","updated":"2021-04-26 07:22:55.000000000","total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"b39dc99a8d6ddd95079295b6a890999b8ea5260c","_number":787415,"virtual_id_number":787415,"owner":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2021-04-21 16:37:20.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2021-04-23 15:30:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":-1,"date":"2021-04-21 18:00:30.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-21 16:37:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-21 18:00:30.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2021-04-21 18:00:30.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2021-04-21 18:05:23.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2021-04-21 18:40:53.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"}],"messages":[{"id":"7847b5c0730d52ea09e8d00ce89cf9b321450bbf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"date":"2021-04-21 16:15:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b9b02f3dd0f5c9e79579247e4b19aaf0e7b5e081","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"date":"2021-04-21 16:20:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1cf432edfbf2a1536be6410a365f075a1fcc9bce","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-21 16:37:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/8b30c3b755554ad2aaccb3d338f01520 : SUCCESS in 7m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f2c4a3f2951444f38c37e372f8a02e20 : SUCCESS in 8m 48s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1dd06974b72c4f8f8cf97fe3cf59daeb : SUCCESS in 10m 37s","accounts_in_message":[],"_revision_number":2},{"id":"fcffc96408b5c6b4748284543454559348ddc348","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-04-21 18:00:30.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nAFAIK, we don\u0027t document out of tree drivers in our docs...","accounts_in_message":[],"_revision_number":2},{"id":"c0a7b93f8318ff0ebd58f0cf1018941d1fc4fd7e","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-04-21 18:05:23.000000000","message":"Patch Set 2:\n\nI see now the context on https://etherpad.opendev.org/p/nova-cinder-xena-ptg, adding bauzas also to look at this.","accounts_in_message":[],"_revision_number":2},{"id":"f01857a117a9371522cd27ab92b012c6b9bf515d","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-04-21 18:40:53.000000000","message":"Patch Set 2:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/787415/2/iscsi : SUCCESS in 2h 19m 09s","accounts_in_message":[],"_revision_number":2},{"id":"fc3ba87af2d418d3a2d9ced53ac3f89d4d09c5fc","author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"date":"2021-04-22 06:58:44.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c586bc3a85cd5fc4d4f54dd82dbb2c9b6fbb4aa8","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2021-04-23 15:30:40.000000000","message":"Patch Set 2: Code-Review-1\n\nApologies if I confused people here, but I thought we were referring at the PTG that the in-tree HyperV driver was using this API, and not solely the out-of-driver driver.\n\nAs Mel said, our upstream docs never tell about out-of-tree drivers so this change can\u0027t be accepted.","accounts_in_message":[],"_revision_number":2},{"id":"b39dc99a8d6ddd95079295b6a890999b8ea5260c","tag":"autogenerated:gerrit:abandon","author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"date":"2021-04-26 07:22:55.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3022715f0e45eb973b68d7ae3b768c7893939bb5","revisions":{"614f1a685f990ef161b021021df9e0f331581842":{"kind":"REWORK","_number":1,"created":"2021-04-21 16:15:24.000000000","uploader":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"ref":"refs/changes/15/787415/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/15/787415/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/15/787415/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/15/787415/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/15/787415/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/15/787415/1"}}},"commit":{"parents":[{"commit":"3e88f99ed4759e70c7216134fb73448f67589d0d","subject":"Merge \"Follow up type hints for a634103\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3e88f99ed4759e70c7216134fb73448f67589d0d"}]}],"author":{"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","date":"2021-04-21 16:09:31.000000000","tz":180},"committer":{"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","date":"2021-04-21 16:09:31.000000000","tz":180},"subject":"os-assisted-volume-snapshots: mention Hyper-V usage","message":"os-assisted-volume-snapshots: mention Hyper-V usage\n\nThe docs state that this API is only implemented by the libvirt\ndriver, but it\u0027s also used by the out of tree Hyper-V driver.\n\nWe\u0027re adding a note about Hyper-V, which will be useful as this\nAPI is about to become supersededed.\n\n[1] https://github.com/openstack/compute-hyperv/blob/12.0.0/compute_hyperv/nova/driver.py#L250-L253\n\nChange-Id: Ic408c80ad5dff4162ac8519b049ed7311c15fb5b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/614f1a685f990ef161b021021df9e0f331581842"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/614f1a685f990ef161b021021df9e0f331581842"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3e88f99ed4759e70c7216134fb73448f67589d0d","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"3022715f0e45eb973b68d7ae3b768c7893939bb5":{"kind":"REWORK","_number":2,"created":"2021-04-21 16:20:01.000000000","uploader":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"ref":"refs/changes/15/787415/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/15/787415/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/15/787415/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/15/787415/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/15/787415/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/15/787415/2"}}},"commit":{"parents":[{"commit":"3e88f99ed4759e70c7216134fb73448f67589d0d","subject":"Merge \"Follow up type hints for a634103\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3e88f99ed4759e70c7216134fb73448f67589d0d"}]}],"author":{"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","date":"2021-04-21 16:09:31.000000000","tz":180},"committer":{"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","date":"2021-04-21 16:19:35.000000000","tz":180},"subject":"os-assisted-volume-snapshots: mention Hyper-V usage","message":"os-assisted-volume-snapshots: mention Hyper-V usage\n\nThe docs state that this API is only implemented by the libvirt\ndriver, but it\u0027s also used by the out of tree Hyper-V driver.\n\nWe\u0027re adding a note about Hyper-V, which will be useful as this\nAPI is about to become supersededed.\n\n[1] https://github.com/openstack/compute-hyperv/blob/12.0.0/compute_hyperv/nova/driver.py#L250-L253\n\nChange-Id: Ic408c80ad5dff4162ac8519b049ed7311c15fb5b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3022715f0e45eb973b68d7ae3b768c7893939bb5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3022715f0e45eb973b68d7ae3b768c7893939bb5"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3e88f99ed4759e70c7216134fb73448f67589d0d","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}