)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4bb0fcce271951c800970fa184a13bb3818d0909","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update aggregate should not allow duplicated names"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It is not allow to create 2 aggrgates with the same name"},{"line_number":10,"context_line":"But if update an existing one with a name already used"},{"line_number":11,"context_line":"by other aggregate that check should be made"},{"line_number":12,"context_line":"This patch doesn\u0027t allow to change the name to an existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAVn%2F%2B2TQ%3D","line":9,"updated":"2014-03-11 19:10:26.000000000","message":"s/aggrgates/aggregates.\n\nAlso, this is a bit nitty, but can you end the sentences with periods please?","commit_id":"156baa01250620d06c612a67656e4cae141a6e40"}],"nova/api/openstack/compute/contrib/aggregates.py":[{"author":{"_account_id":9449,"name":"Verónica Musso","email":"veronica.a.musso@intel.com","username":"vamusso"},"change_message_id":"aefcf706ff6bc5a4dd54450f507d53cb6999fa9f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        try:"},{"line_number":129,"context_line":"            aggregate \u003d self.api.update_aggregate(context, id, updates)"},{"line_number":130,"context_line":"        except exception.AggregateNameExists as e:"},{"line_number":131,"context_line":"            LOG.info(e)"},{"line_number":132,"context_line":"            raise exc.HTTPConflict()"},{"line_number":133,"context_line":"        except exception.AggregateNotFound:"},{"line_number":134,"context_line":"            LOG.info(_(\u0027Cannot update aggregate: %s\u0027), id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2B3R4%3D","line":131,"updated":"2014-03-11 16:59:19.000000000","message":"Just a minor suggestion... maybe you can add a message here instead of printing the exception. Thanks!","commit_id":"156baa01250620d06c612a67656e4cae141a6e40"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4bb0fcce271951c800970fa184a13bb3818d0909","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        try:"},{"line_number":129,"context_line":"            aggregate \u003d self.api.update_aggregate(context, id, updates)"},{"line_number":130,"context_line":"        except exception.AggregateNameExists as e:"},{"line_number":131,"context_line":"            LOG.info(e)"},{"line_number":132,"context_line":"            raise exc.HTTPConflict()"},{"line_number":133,"context_line":"        except exception.AggregateNotFound:"},{"line_number":134,"context_line":"            LOG.info(_(\u0027Cannot update aggregate: %s\u0027), id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2B2SE%3D","line":131,"in_reply_to":"AAAAVn%2F%2B3R4%3D","updated":"2014-03-11 19:10:26.000000000","message":"I\u0027d remove the log statement, I know the other exception is doing it, but you don\u0027t need to log the exception just to raise it - the raised exception will be logged later.  Just make sure the HTTPConflict explanation kwarg is set to e.format_message().\n\nBy the way, this also needs to be handled in the V3 API:\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/plugins/v3/aggregates.py#L138","commit_id":"156baa01250620d06c612a67656e4cae141a6e40"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a7c348947c4df81ec39dc54017513cc7073bfc0a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        try:"},{"line_number":129,"context_line":"            aggregate \u003d self.api.update_aggregate(context, id, updates)"},{"line_number":130,"context_line":"        except exception.AggregateNameExists as e:"},{"line_number":131,"context_line":"            LOG.info(e)"},{"line_number":132,"context_line":"            raise exc.HTTPConflict()"},{"line_number":133,"context_line":"        except exception.AggregateNotFound:"},{"line_number":134,"context_line":"            LOG.info(_(\u0027Cannot update aggregate: %s\u0027), id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2B0TE%3D","line":131,"updated":"2014-03-12 00:03:56.000000000","message":"Don\u0027t need to log this, just handle the error with the formatted error message in HTTPConflict like InvalidAggregateAction below.","commit_id":"f8fa205a3b9de4f746b946377c6c3ef68d1da055"}],"nova/api/openstack/compute/plugins/v3/aggregates.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a7c348947c4df81ec39dc54017513cc7073bfc0a","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        try:"},{"line_number":138,"context_line":"            aggregate \u003d self.api.update_aggregate(context, id, updates)"},{"line_number":139,"context_line":"        except exception.AggregateNameExists as e:"},{"line_number":140,"context_line":"            raise exc.HTTPConflict()"},{"line_number":141,"context_line":"        except exception.AggregateNotFound as e:"},{"line_number":142,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":143,"context_line":"        except exception.InvalidAggregateAction as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2B0Ss%3D","line":140,"updated":"2014-03-12 00:03:56.000000000","message":"Need to pass the formatted exception message in the HTTPConflict via the explanation kwarg like the other errors here.","commit_id":"f8fa205a3b9de4f746b946377c6c3ef68d1da055"}]}