)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7242d63dee30b5246e939ad5faeb3f1907cc84ad","unresolved":false,"context_lines":[{"line_number":681,"context_line":"            instance \u003d self._instance_update(context, instance.uuid,"},{"line_number":682,"context_line":"                                   task_state\u003dNone)"},{"line_number":683,"context_line":"            instance \u003d instance_obj.Instance._from_db_object("},{"line_number":684,"context_line":"                context, instance_obj.Instance(), instance)"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        if instance.task_state \u003d\u003d task_states.DELETING:"},{"line_number":687,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FTDA%3D","line":684,"updated":"2014-03-07 00:15:02.000000000","message":"This is wrong. You should use the instance object instead:\n\n instance.task_state \u003d None\n instance.save()\n\nand not do the instance_update at all, which is converting it back to a dict.","commit_id":"149e2b440d65ec64eec8da4d1c3317b5088b61f8"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"a40aa065c4cbe2c96dd5040caf0f2de94af26f63","unresolved":false,"context_lines":[{"line_number":681,"context_line":"            instance \u003d self._instance_update(context, instance.uuid,"},{"line_number":682,"context_line":"                                   task_state\u003dNone)"},{"line_number":683,"context_line":"            instance \u003d instance_obj.Instance._from_db_object("},{"line_number":684,"context_line":"                context, instance_obj.Instance(), instance)"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        if instance.task_state \u003d\u003d task_states.DELETING:"},{"line_number":687,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FTCA%3D","line":684,"in_reply_to":"AAAAVn%2F%2FTDA%3D","updated":"2014-03-07 00:46:09.000000000","message":"Done","commit_id":"149e2b440d65ec64eec8da4d1c3317b5088b61f8"}],"nova/tests/compute/test_compute_mgr.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2df26bc0fd9022f3e743785a07fe7c08739873b3","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    def _test_init_instance_cleans_image_states(self, instance):"},{"line_number":409,"context_line":"        with mock.patch.object(self.compute, \u0027_instance_update\u0027"},{"line_number":410,"context_line":"             ) as _instance_update:"},{"line_number":411,"context_line":"                _instance_update.return_value \u003d {\u0027a\u0027: \u0027dict\u0027}"},{"line_number":412,"context_line":"                self.compute._init_instance(self.context, instance)"},{"line_number":413,"context_line":"                call \u003d mock.call(self.context, \u0027foo\u0027, task_state\u003dNone)"},{"line_number":414,"context_line":"                _instance_update.assert_has_calls([call])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FSt4%3D","line":411,"updated":"2014-03-07 00:53:28.000000000","message":"Hmm, not sure how this would have caused the other case to fail. It would have caused the next use of instance to fail in the same way as before I think...","commit_id":"a0a9a82521a0b448c8be7d2f565ccd15618e0f9d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2df26bc0fd9022f3e743785a07fe7c08739873b3","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                _instance_update.return_value \u003d {\u0027a\u0027: \u0027dict\u0027}"},{"line_number":412,"context_line":"                self.compute._init_instance(self.context, instance)"},{"line_number":413,"context_line":"                call \u003d mock.call(self.context, \u0027foo\u0027, task_state\u003dNone)"},{"line_number":414,"context_line":"                _instance_update.assert_has_calls([call])"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def test_init_instance_cleans_image_state_pending_upload(self):"},{"line_number":417,"context_line":"        instance \u003d instance_obj.Instance(self.context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FSts%3D","line":414,"updated":"2014-03-07 00:53:28.000000000","message":"Isn\u0027t this checking that we\u0027re calling _instance_update()? You removed that, so this should fail, right? If it passes, then I\u0027m confused :)","commit_id":"a0a9a82521a0b448c8be7d2f565ccd15618e0f9d"}]}