)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a4b5a6f66eea5ca9da6b1685c952a9fd17f54574","unresolved":true,"context_lines":[{"line_number":710,"context_line":"            # TODO(gibi): remove hasattr() conditional in favor of \"url.set()\""},{"line_number":711,"context_line":"            # when SQLAlchemy 1.4 is the minimum version in requirements"},{"line_number":712,"context_line":"            if hasattr(url, \"set\"):"},{"line_number":713,"context_line":"                url \u003d url.set(database\u003durl.database + \u0027_cell0\u0027)"},{"line_number":714,"context_line":"            else:"},{"line_number":715,"context_line":"                # TODO(zzzeek): remove when SQLAlchemy 1.4"},{"line_number":716,"context_line":"                # is the minimum version in requirements"}],"source_content_type":"text/x-python","patch_set":4,"id":"21b22c8d_09ad8d85","line":713,"range":{"start_line":713,"start_character":39,"end_line":713,"end_character":62},"updated":"2021-05-13 14:40:55.000000000","message":"I probably would have put this in a separate line outside the conditional to make sure (and clear) that we\u0027re doing the same construction, just setting it in a different way. But, just MHO.","commit_id":"39a617752f71cb8fe7188baee08b1c2ba48ad066"}],"nova/objects/instance.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"a0e3f06a333bbe8b2a06f790879caf8fd88cd29c","unresolved":true,"context_lines":[{"line_number":1522,"context_line":"            func.count(models.Instance.id),"},{"line_number":1523,"context_line":"            func.sum(models.Instance.vcpus),"},{"line_number":1524,"context_line":"            func.sum(models.Instance.memory_mb)).\\"},{"line_number":1525,"context_line":"            filter(models.Instance.deleted \u003d\u003d 0).\\"},{"line_number":1526,"context_line":"            filter(not_soft_deleted).\\"},{"line_number":1527,"context_line":"            filter(models.Instance.project_id \u003d\u003d project_id)"},{"line_number":1528,"context_line":"        # NOTE(mriedem): Filter out hidden instances since there should be a"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ddc33f7_38e8bfee","line":1525,"updated":"2021-04-30 16:57:24.000000000","message":"was filter_by failing?  Note we run a subset of nova test suite on SQLAlchemy CI and I\u0027ve been making sure there are no openstack regressions","commit_id":"b435d23438140574fe3a850c0a8709865b376a34"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9dfdf295238b8575dbaeb5dd4613a7548c70fe4b","unresolved":true,"context_lines":[{"line_number":1522,"context_line":"            func.count(models.Instance.id),"},{"line_number":1523,"context_line":"            func.sum(models.Instance.vcpus),"},{"line_number":1524,"context_line":"            func.sum(models.Instance.memory_mb)).\\"},{"line_number":1525,"context_line":"            filter(models.Instance.deleted \u003d\u003d 0).\\"},{"line_number":1526,"context_line":"            filter(not_soft_deleted).\\"},{"line_number":1527,"context_line":"            filter(models.Instance.project_id \u003d\u003d project_id)"},{"line_number":1528,"context_line":"        # NOTE(mriedem): Filter out hidden instances since there should be a"}],"source_content_type":"text/x-python","patch_set":2,"id":"f1372dd9_5c83b82e","line":1525,"in_reply_to":"320b9e08_30d82c36","updated":"2021-05-03 08:35:37.000000000","message":"Thanks Mike! I have tested your fix and it makes the currently proposed nova fixes unnecessary.","commit_id":"b435d23438140574fe3a850c0a8709865b376a34"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"4562ebe3411f9c220bcaff50a8a925968ee27ddf","unresolved":true,"context_lines":[{"line_number":1522,"context_line":"            func.count(models.Instance.id),"},{"line_number":1523,"context_line":"            func.sum(models.Instance.vcpus),"},{"line_number":1524,"context_line":"            func.sum(models.Instance.memory_mb)).\\"},{"line_number":1525,"context_line":"            filter(models.Instance.deleted \u003d\u003d 0).\\"},{"line_number":1526,"context_line":"            filter(not_soft_deleted).\\"},{"line_number":1527,"context_line":"            filter(models.Instance.project_id \u003d\u003d project_id)"},{"line_number":1528,"context_line":"        # NOTE(mriedem): Filter out hidden instances since there should be a"}],"source_content_type":"text/x-python","patch_set":2,"id":"320b9e08_30d82c36","line":1525,"in_reply_to":"425309da_b22dbcb2","updated":"2021-05-01 12:42:56.000000000","message":"this is a regression, please report these to me - added at https://github.com/sqlalchemy/sqlalchemy/issues/6414 .   will try to get it fixed","commit_id":"b435d23438140574fe3a850c0a8709865b376a34"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"19f31854f6c2a4a3b5205a5eccf66afcb2c9a369","unresolved":true,"context_lines":[{"line_number":1522,"context_line":"            func.count(models.Instance.id),"},{"line_number":1523,"context_line":"            func.sum(models.Instance.vcpus),"},{"line_number":1524,"context_line":"            func.sum(models.Instance.memory_mb)).\\"},{"line_number":1525,"context_line":"            filter(models.Instance.deleted \u003d\u003d 0).\\"},{"line_number":1526,"context_line":"            filter(not_soft_deleted).\\"},{"line_number":1527,"context_line":"            filter(models.Instance.project_id \u003d\u003d project_id)"},{"line_number":1528,"context_line":"        # NOTE(mriedem): Filter out hidden instances since there should be a"}],"source_content_type":"text/x-python","patch_set":2,"id":"425309da_b22dbcb2","line":1525,"in_reply_to":"9ddc33f7_38e8bfee","updated":"2021-05-01 06:33:42.000000000","message":"yes, it was failing with filter_by in multiple tests. See the stack trace in http://paste.openstack.org/show/804894/","commit_id":"b435d23438140574fe3a850c0a8709865b376a34"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9e123e0108ab62b3b985e14ee7ecfd6112576211","unresolved":true,"context_lines":[{"line_number":1522,"context_line":"            func.count(models.Instance.id),"},{"line_number":1523,"context_line":"            func.sum(models.Instance.vcpus),"},{"line_number":1524,"context_line":"            func.sum(models.Instance.memory_mb)).\\"},{"line_number":1525,"context_line":"            filter(models.Instance.deleted \u003d\u003d 0).\\"},{"line_number":1526,"context_line":"            filter(not_soft_deleted).\\"},{"line_number":1527,"context_line":"            filter(models.Instance.project_id \u003d\u003d project_id)"},{"line_number":1528,"context_line":"        # NOTE(mriedem): Filter out hidden instances since there should be a"}],"source_content_type":"text/x-python","patch_set":2,"id":"919051c8_fbf622cd","line":1525,"in_reply_to":"f1372dd9_5c83b82e","updated":"2021-05-03 08:54:16.000000000","message":"But there is one more small fix needed in nova similarly to what you have added to oslo.db 8.6.0.","commit_id":"b435d23438140574fe3a850c0a8709865b376a34"}]}