)]}'
{"id":"openstack%2Fnova~788720","triplet_id":"openstack%2Fnova~stable%2Fwallaby~I7f2b6330decb92e2838aa7cee47fb228f00f47da","project":"openstack/nova","branch":"stable/wallaby","topic":"bug/1882521","hashtags":[],"change_id":"I7f2b6330decb92e2838aa7cee47fb228f00f47da","subject":"Replace blind retry with libvirt event waiting in detach","status":"MERGED","created":"2021-04-29 12:12:33.000000000","updated":"2021-05-20 17:29:57.000000000","submitted":"2021-05-20 17:27:26.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"788720-bug/1882521","meta_rev_id":"55867201d64a5ce2f7bd562441e9098b2764596a","_number":788720,"virtual_id_number":788720,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-05-20 17:27:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2021-05-19 16:44:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2021-05-13 14:24:57.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":1,"date":"2021-05-19 16:44:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-29 12:58:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-04-29 13:45:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-29 14:40:53.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-05-13 14:24:57.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2021-05-19 16:44:35.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"bad0fc153364baa773df8a8e6e414628df6efff8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-04-29 12:12:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d538b99939a35e80fe097e1017cd56922a4ebbdc","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-29 12:58:21.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/ad7c98cbacfb45e69ce79a1fe5bc8212 : SUCCESS in 27m 46s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/20098c8cd940418091852b00ad21e8b7 : SUCCESS in 42m 15s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"eb8d5fff805e302941d2a5f0812b676f5c6caf87","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-29 13:45:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/c93f78f89bb742a0bee51cdca35ba85c : SUCCESS in 1h 20m 07s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4f52da2647a240459d9bbed72ce6f0d9 : SUCCESS in 16m 23s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5cc48b54bb294b5dba09b58706f3549e : SUCCESS in 12m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3a99337544394c59a00c8a5e6c17545f : FAILURE in 11m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/56f9e8b190d14bbfaafd1ae4058c2bc7 : SUCCESS in 12m 25s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ae2d4d1137944473aaf56ba2c908a4dc : SUCCESS in 17m 05s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/bd657c9d2ac049979924f9f1f0e33b99 : SUCCESS in 14m 33s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f44556e79e2f4672962bd3afefd570f5 : SUCCESS in 12m 32s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/3a7d9a9f6cf64fef9fac3f8fa133c7cb : SUCCESS in 1h 24m 20s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/2664904123c141808adb3971b1b085cd : SUCCESS in 1h 05m 49s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/2cf53d57ea4443e3a6da9cd5a14d19e1 : FAILURE in 1h 05m 51s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/6823b0c2252344b3824bf798e69423ef : SUCCESS in 51m 46s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/5f583bd2118445c6abfcb997061cfca2 : SUCCESS in 52m 27s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/fe376e0911ef4412a1d211659ee7858d : SUCCESS in 1h 24m 15s\n- nova-next https://zuul.opendev.org/t/openstack/build/2d524d0a4a5f43ed833de7b1fc98e972 : SUCCESS in 1h 28m 43s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/0852d353ac4a46a79e5fbaefdcfbfe5d : SUCCESS in 17m 26s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/e9d3e03340704fee8ea14dc4584317fd : SUCCESS in 19m 19s (non-voting)\n- grenade https://zuul.opendev.org/t/openstack/build/5a7018cf96824aaa84d28e1e33ac9764 : SUCCESS in 1h 02m 41s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8dd7354c62934ebeb9860b0a53411264 : SUCCESS in 57m 31s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/0a55051afc084d8fb9e96fb267953b4b : SUCCESS in 53m 37s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/250b50da3cc84213b05a3897c072bfc4 : SUCCESS in 32m 54s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/55770758bffc448294e389d72e0e6245 : SUCCESS in 50m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"225db7726e3c5d42a328cfa3f923f0371a81a7fb","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-04-29 14:22:49.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2841b970c9929c9f1e13de62d09177d56b234743","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-04-29 14:40:53.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/788720/1/iscsi : FAILURE in 2h 25m 59s","accounts_in_message":[],"_revision_number":1},{"id":"38ce903f390f9ebf5aa8cf4c9e6543bc6c72d777","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-05 07:58:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4fd833d1765ec3d020635353f526d35930899281","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-05 08:00:28.000000000","message":"Patch Set 2:\n\nI redid the cherry-picks now with the proper commits. This made the whole series backport a clean cherry pick.","accounts_in_message":[],"_revision_number":2},{"id":"c5181773ecaaa6d61c7c98ed539334d3a2750dc4","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-05 09:03:51.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/6cf7660280944854afe52e690fe8ff03 : SUCCESS in 31m 46s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/409157111e9f46f8ada594e14c73dd89 : TIMED_OUT in 1h 01m 11s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"712bea2d639e52840af7efae36ccc16ac8803459","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-05 09:58:24.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/7d071dd79105436a893b6ac68d6f32a8 : SUCCESS in 1h 31m 39s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/98af37e6d5924e3b8ea3cbeb32004a9d : SUCCESS in 16m 26s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/432f327f1e394ba1aa4b554a99cf131b : SUCCESS in 15m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3d42899d781143d9ab4191f35d7821c8 : SUCCESS in 8m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f586528dd08f43c091f5550a2ba7693b : SUCCESS in 15m 04s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/217245a274714400964416120dfbdd83 : SUCCESS in 13m 36s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/025bbea3d98d452ba81090de65b8a4d0 : SUCCESS in 12m 09s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/89d33a6c9b5149bcad9e55b7ee2e044a : SUCCESS in 12m 44s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a6c2216c09054f2ba4f03a6b0e6dea91 : SUCCESS in 20m 45s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/0e014d8ffa8f4433b517606bee1ccb46 : SUCCESS in 1h 25m 08s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/0be6e8d40ac146b1a2792407a72df4f1 : SUCCESS in 1h 09m 46s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/f218f485e3374062b0671e36a01a4f28 : SUCCESS in 1h 19m 30s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/dd68da477a4b4fdeabd574ef4e67eaa4 : SUCCESS in 52m 47s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/330feddd39394a618040943bfa6afb88 : FAILURE in 1h 00m 56s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/a06bffcd49094e7bbd5134be2f7b357b : SUCCESS in 1h 21m 41s\n- nova-next https://zuul.opendev.org/t/openstack/build/81292f50c7014d4193df6be4f8a9ba2d : SUCCESS in 1h 46m 51s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/29b7dc7f25684daebb870204a743c76e : SUCCESS in 15m 05s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/466af0a75ec0448fa2e111ee37ffc463 : SUCCESS in 14m 43s (non-voting)\n- grenade https://zuul.opendev.org/t/openstack/build/5a92a0fcad6c4bb5b4abf04ce0d4ff80 : SUCCESS in 56m 08s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/27eb351bb8154fb3bdcb577043d2757c : SUCCESS in 46m 25s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/2e992098debf4c23a2912c01d5e8e718 : SUCCESS in 1h 07m 45s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/10f90b967a2941f8a43d2dbacd4b50f0 : SUCCESS in 26m 18s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/0f410db6772c40a38641f6f1af293d28 : SUCCESS in 50m 39s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"5497dadc075895b121857d7c76cc80c6c10efdd4","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-05 10:17:45.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"ff85530903ae628160136aaf74ec97e053b732a4","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-05-05 10:55:47.000000000","message":"Patch Set 2:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/788720/2/iscsi : SUCCESS in 2h 56m 09s","accounts_in_message":[],"_revision_number":2},{"id":"bee44be677fe2cb363fd7b509f2a74ad03dcd0f9","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-05 11:30:58.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/b626bac8d4d64e63b5c9a0d5fdf54023 : SUCCESS in 30m 22s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/fa46877807794f51bb8814323c3a0f99 : TIMED_OUT in 1h 01m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"34c290b46ff03ca392b1312df8ba47499b9e968e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-05 12:07:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/92349c42b1ff4d79b4946da2424b6fa3 : SUCCESS in 1h 47m 55s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/77d76819684e4f9ebb6165531c3986ae : SUCCESS in 28m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3adae5a7e5bb4988ad3a94a90b538be8 : SUCCESS in 13m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/838f93f34b1c4b309528f9e9155d4358 : SUCCESS in 9m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/92e78b5cedf5420aaed32d077c0ed55a : SUCCESS in 12m 15s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ab2a013ec02b4019853b08dda1ae2e43 : SUCCESS in 15m 39s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/43982695ac56418a8f75235d298c1ab9 : SUCCESS in 14m 04s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4b72da704059476f90c5afa27b25c6cb : SUCCESS in 9m 35s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8d17a1fb515e48b6a0b05211be9c96b0 : SUCCESS in 17m 46s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/091542ede3764704979408736373288f : SUCCESS in 1h 15m 01s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/b40729e1a2a249fda320aefc81cdddba : SUCCESS in 1h 11m 25s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/f603e3b3fa8041bfbb42223bda30c4c4 : SUCCESS in 1h 05m 58s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/01bf8203f3504006939fec00f875d87b : SUCCESS in 54m 24s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/aee1e757818e4318b5412edb051b4968 : SUCCESS in 52m 26s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/31a571fdaf6b4fa69ee55126401f3e8c : SUCCESS in 1h 20m 33s\n- nova-next https://zuul.opendev.org/t/openstack/build/6a725b1c140441ba849aa5cf2d61fe96 : SUCCESS in 1h 17m 10s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/350d248bb6bb4c9c956a1d88c02579f6 : SUCCESS in 18m 21s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/15fc4dd93e094d3fb93af9560ec5f089 : SUCCESS in 23m 01s (non-voting)\n- grenade https://zuul.opendev.org/t/openstack/build/efe115712ff447fca13c22d2e7b47a54 : SUCCESS in 1h 15m 46s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c06b3adc97dd4a6ba62c36bd174e0b9d : SUCCESS in 54m 08s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c7dff81ddb994756837e093a57c54a84 : SUCCESS in 42m 09s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/668c02b80eaa4a67a3cc9610fe213b8f : SUCCESS in 28m 35s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/38a968b517474a168fecb8ae471b5d24 : SUCCESS in 31m 12s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"492ed5868a37962e57b9010d84b9c81ed51751d6","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-05-13 14:24:57.000000000","message":"Patch Set 2: Code-Review+2\n\nLGTM, clean, passing and definitely needed at the moment on stable/wallaby.","accounts_in_message":[],"_revision_number":2},{"id":"560bac4fabb15b665372f39c314e643ffb75d841","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-05-19 16:44:35.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nAs we discussed in IRC, I was hesitant with this patch, as this is a bit bigger change than a usual backport would contain. Anyway, this patch is useful, so not worth keeping it back. Also, merged on master, clean cherry pick. The two new config options have default values, so looks OK to backport.","accounts_in_message":[],"_revision_number":2},{"id":"fe295205fe388a81057db632d73bc31909fc1d80","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-19 16:47:08.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"acbef25df49245e3a8e7d9deb3f188a289f6e5f2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-19 21:31:53.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/86447fd411ad42a8b35fd55eff5422b6 : SUCCESS in 1h 23m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e264f3f412c74f379790a34ee4008702 : SUCCESS in 14m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/02538721f3414793a1c03896ae6c00ba : SUCCESS in 7m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6dd8ff9053974afd9557e9fd841b1206 : SUCCESS in 14m 42s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8639b443c4e045d7a9f9e700d15768c2 : SUCCESS in 17m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e46d9ff27d4c40dba923b12b13f2c248 : SUCCESS in 11m 12s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c445f1e25ea344a5910f8620364cea5c : SUCCESS in 22m 46s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/b02251f4beb847739f06e2a4f0ac8e12 : FAILURE in 56m 54s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/6b0fd9d173234c24b4a7e5251183d43e : SUCCESS in 48m 26s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/f49e47ac9f3d475d911f16dbade63bd2 : SUCCESS in 20m 37s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/d0d68bcf632b4948967d3f9d5e3b8acc : SUCCESS in 1h 18m 31s\n- nova-next https://zuul.opendev.org/t/openstack/build/7b2f9ede14a54a57a8337afbd78180f8 : SUCCESS in 1h 23m 33s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/b78c984609594747b2d8f03506dd5ac8 : SUCCESS in 1h 17m 29s\n- grenade https://zuul.opendev.org/t/openstack/build/52aef9a080904094a6616c188e2d332e : SUCCESS in 50m 55s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6ae5483c478d42e8a83ed9f97b82d9b6 : SUCCESS in 56m 38s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/54e88a0fda9549cf9f14d6b7a0590252 : SUCCESS in 45m 52s","accounts_in_message":[],"_revision_number":2},{"id":"11de13470e066a54202979591d4839a8c4a4861c","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-20 12:15:12.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"979fcb8ebe441da9f5520dc65cf90ae56dda2332","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-20 12:40:42.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/48fdd41dc0c94c4d916cd7c8ffecf6dc : SUCCESS in 23m 13s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/ca75c4d2dfff430387b1dc50d14e5c64 : SUCCESS in 21m 17s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"20cb90dbc0ec852728a1c104d6d1dd3910f31e73","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-20 13:57:53.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/95672ed88d534e239fdd52a1e5957dcd : SUCCESS in 1h 10m 06s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2f490dcbd94748c78e40ea91650c1a29 : SUCCESS in 16m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/916c45e8b00b48b992468d0f5ff46464 : SUCCESS in 13m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/087b129aafd547e5b07b3e65da652783 : SUCCESS in 8m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3a560c7a726146d9b60c47f39690649d : SUCCESS in 11m 59s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4148bd36a74a46068cddd03ccf98ec8a : SUCCESS in 12m 47s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a6fccdca7255491fae9d68e8d13cbbe7 : SUCCESS in 13m 00s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7ea33df2e0304284bec5716515b50ada : SUCCESS in 9m 35s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b6f2789248f94a4289972048b1dd5096 : SUCCESS in 15m 59s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/085dfb342d0540e0af5f16f1834dc97f : SUCCESS in 1h 25m 05s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/4500539f808a47709abb2896093e2549 : FAILURE in 1h 12m 00s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/c4b674dcadc741c7b131fdc452dd209e : SUCCESS in 1h 18m 38s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/110207523e854fd88c647bec68e2a2e9 : SUCCESS in 50m 01s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/e47016a016c74ff79158bb61009250ef : SUCCESS in 52m 36s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/62869ea208bc4233b9203e797a1c87b2 : SUCCESS in 1h 36m 18s\n- nova-next https://zuul.opendev.org/t/openstack/build/96cc07bd69a848cfb692613095b97773 : SUCCESS in 1h 35m 00s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/61028542cb8a40d2b6da714b19a1d617 : SUCCESS in 16m 33s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/d634fb50d2204652a13e1fdcd4c2466b : SUCCESS in 21m 26s (non-voting)\n- grenade https://zuul.opendev.org/t/openstack/build/b12888893bd04c1a96157095f7b18faf : SUCCESS in 1h 02m 23s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1f10d7440d834a94aedbb5dd958f65aa : SUCCESS in 55m 49s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/1bb12accd9354cbab1e315677ed5ac12 : SUCCESS in 1h 04m 17s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/e30c5db860614357a13f875069a74e02 : SUCCESS in 31m 32s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/bec3e7a1b8e246d6aa69451c00d3e7a3 : SUCCESS in 36m 27s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"224055d5e6beeb1f45ffc482cd1e11cc52fa6f37","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-20 14:00:37.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"bb9870c663a12420c776a677401d5d1c5a00ac9c","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-20 14:32:23.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/7f9a176f78d242fea5b8560ac7041ef2 : SUCCESS in 29m 47s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/2d51e4368e1142c99c7290d106d5189b : SUCCESS in 25m 45s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b53193f9b3c986941ef174d5598e28c316f93e8b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-20 15:29:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/eead40792f61487ca6b244d512d8f6b8 : SUCCESS in 1h 21m 59s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0425d0e2ca5b4932bef3232c28782d40 : SUCCESS in 16m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/56397101042f44b0bba8b60f3064e189 : SUCCESS in 15m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cfeea101a1494a2ea194bbac40236922 : SUCCESS in 7m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c0b57a9741694f14976c313357a5c9e6 : SUCCESS in 12m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/dac3e9457c1a4cd1b6b6b1d8c67d6019 : SUCCESS in 11m 24s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0153ad19e73b40eb98fd83017c57712e : SUCCESS in 12m 08s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a311c0bc6a9d4fdd891b41dc19fb0445 : SUCCESS in 10m 30s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/17a12976d40f4a63b03cadb4dc87d29d : SUCCESS in 14m 45s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/e01e4c99a4b24d169e34682fdc956968 : SUCCESS in 1h 01m 35s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/641d39a73ce445debf9f18b040ab90b9 : SUCCESS in 1h 07m 26s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/1cc0f497f1594dc89a1da2b4f9afef12 : SUCCESS in 1h 00m 28s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/b7a1725cb0cb44e0a1f7d31e538272a6 : SUCCESS in 39m 09s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/bb17dd764d4549b9b1bd07e30fe3e761 : SUCCESS in 51m 27s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/e13cc60189b14a25b8e654e3921847a3 : SUCCESS in 1h 06m 08s\n- nova-next https://zuul.opendev.org/t/openstack/build/4fd9d3fb5963462c84c0a7aab49240dd : SUCCESS in 1h 23m 03s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/180c8895bcea467089ec31de0090f267 : SUCCESS in 16m 57s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/f779cd5a66a6444194df915dae1a01ab : SUCCESS in 18m 17s (non-voting)\n- grenade https://zuul.opendev.org/t/openstack/build/c1521935900948549f3bd1a1fdab0fc4 : SUCCESS in 1h 17m 21s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/83c74ed9f38745ec86ea1f2ecd92f81f : SUCCESS in 53m 10s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/e4f10d903b0a45dd9d1b6e386dd16e70 : SUCCESS in 1h 05m 58s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/832e617d0bae4b6faa1ccbcd665290fb : SUCCESS in 27m 05s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/1759b33b316c434c8ebbae898ead7613 : SUCCESS in 39m 34s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"28b4333c5e2fe01333bfdb6e8c7e33caa21d7d30","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-20 15:30:14.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"412701581e28e166ef8376d85f3bb9caa7491e96","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-05-20 16:13:42.000000000","message":"Patch Set 2:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/788720/2/iscsi : SUCCESS in 2h 52m 01s","accounts_in_message":[],"_revision_number":2},{"id":"5d68c349dee41bd24aa625ce5451e69b91138735","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-20 17:27:25.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/b267f567c8f743df91b21f5547eb0481 : SUCCESS in 1h 10m 58s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cf5a50e81d1d48d689928d3a126468f0 : SUCCESS in 15m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dfcb1c5d015d49bd8b173e402cb204df : SUCCESS in 8m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cac58da72a7b4ffcb8c711fe1e803a15 : SUCCESS in 11m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/41129df5ac90456a84b634a6685192f7 : SUCCESS in 13m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8c4a6a0cd2ad482da15005f9020c3624 : SUCCESS in 14m 42s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2715a40a09c946adb0ef237ab84e8f9f : SUCCESS in 15m 53s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/55e4f6b54e3744ceb6035fc3b0461660 : SUCCESS in 1h 04m 37s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/3ad0f68b61124942afbce1fa82db44ed : SUCCESS in 46m 48s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/d923524f14bb4aa586dbfa941b01dc47 : SUCCESS in 18m 54s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/4b3b70401d484e15b858a54d6eacf9f8 : SUCCESS in 1h 17m 15s\n- nova-next https://zuul.opendev.org/t/openstack/build/592ae4178b69430abd170d7f9242d528 : SUCCESS in 1h 53m 43s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/93cb61d0c34f4bfd854cfe9d94c43202 : SUCCESS in 1h 16m 27s\n- grenade https://zuul.opendev.org/t/openstack/build/0aec845966b345919313c6debcd39fd2 : SUCCESS in 52m 32s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6b30b2b024ac4a269f69cbcdedc73dca : SUCCESS in 50m 30s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/cf36a17e27d0451fa3be07b97072269a : SUCCESS in 46m 17s","accounts_in_message":[],"_revision_number":2},{"id":"e98a7e7437be43dd9476565529aabb01ba18163b","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-20 17:27:26.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"55867201d64a5ce2f7bd562441e9098b2764596a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-20 17:29:57.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c4345934c1e047999205fa3bb268a722 : SUCCESS in 1m 35s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ba4fca93102348a6a8fea19cc454fc37 : SUCCESS in 1m 37s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"30317e6b3f5ee5e7fd1e8c564a1d6f3e3a2fb91b","revisions":{"4348bc19d231a04d2db0c7e276edc3487709e2a9":{"kind":"REWORK","_number":1,"created":"2021-04-29 12:12:33.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/20/788720/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/20/788720/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/788720/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/788720/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/788720/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/20/788720/1"}}},"commit":{"parents":[{"commit":"79707c6d074f8df6583520f8a9c20aab28cd76c0","subject":"Merge \"guestfs: With libguestfs \u003e\u003d v1.41.1 decode returned bytes to string\" into stable/wallaby","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/79707c6d074f8df6583520f8a9c20aab28cd76c0"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-01-12 07:23:17.000000000","tz":60},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-04-29 11:51:45.000000000","tz":120},"subject":"Replace blind retry with libvirt event waiting in detach","message":"Replace blind retry with libvirt event waiting in detach\n\nNova so far applied a retry loop that tried to periodically detach the\ndevice from libvirt while the device was visible in the domain xml. This\ncould lead to an issue where an already progressing detach on the\nlibvirt side is interrupted by nova re-sending the detach request for\nthe same device. See bug #1882521 for more information.\n\nAlso if there was both a persistent and a live domain the nova tried the\ndetach from both at the same call. This lead to confusion about the\nresult when such call failed. Was the detach failed partially?\n\nWe can do better, at least for the live detach case. Based on the\nlibvirt developers detaching from the persistent domain always\nsucceeds and it is a synchronous process. Detaching from the live\ndomain can be both synchronous or asynchronous depending on the guest\nOS and the load on the hypervisor. But for live detach libvirt always\nsends an event [1] nova can wait for.\n\nSo this patch does two things.\n\n1) Separates the detach from the persistent domain from the detach from\n   the live domain to make the error cases clearer.\n\n2) Changes the retry mechanism.\n\n   Detaching from the persistent domain is not retried. If libvirt\n   reports device not found, while both persistent and live detach\n   is needed, the error is ignored, and the process continues with\n   the live detach. In any other case the error considered as fatal.\n\n   Detaching from the live domain is changed to always wait for the\n   libvirt event. In case of timeout, the live detach is retried.\n   But a failure event from libvirt considered fatal, based on the\n   information from the libvirt developers, so in this case the\n   detach is not retried.\n\nConflicts:\n      nova/tests/unit/virt/libvirt/test_driver.py\n      nova/tests/unit/virt/libvirt/test_guest.py\n      nova/virt/libvirt/driver.py\n      nova/virt/libvirt/guest.py\n\nThese conflicts are due to two other bugfixes backported earlier from\nmaster to wallaby than the current fix.\n\n* f99f667a96a357adc0070d75b5940e76726f9664 causing only whitespace\n  damage\n* I0e068043d8267ab91535413d950a3e154c2234f7 is a fix that was valid both\n  before and after the current patch but need changes in different\n  places due to the current fix also impacting the same detach path\n\nRelated-Bug: #1882521\n\n[1]https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectDomainEventDeviceRemovedCallback\n\nChange-Id: I7f2b6330decb92e2838aa7cee47fb228f00f47da\n(cherry picked from commit e27f51fdb7873fc39cf93f49838661eed11b1e03)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4348bc19d231a04d2db0c7e276edc3487709e2a9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4348bc19d231a04d2db0c7e276edc3487709e2a9"}]},"parents_data":[{"branch_name":"refs/heads/stable/wallaby","commit_id":"79707c6d074f8df6583520f8a9c20aab28cd76c0","is_merged_in_target_branch":false}],"branch":"refs/heads/stable/wallaby"},"30317e6b3f5ee5e7fd1e8c564a1d6f3e3a2fb91b":{"kind":"REWORK","_number":2,"created":"2021-05-05 07:58:01.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/20/788720/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/20/788720/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/788720/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/788720/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/788720/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/20/788720/2"}}},"commit":{"parents":[{"commit":"a5ce4d806172f9d144633f297163e088c8ed1491","subject":"Merge \"[neutron] Get only ID and name of the SGs from Neutron\" into stable/wallaby","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a5ce4d806172f9d144633f297163e088c8ed1491"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-01-12 07:23:17.000000000","tz":60},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-05-05 07:47:35.000000000","tz":120},"subject":"Replace blind retry with libvirt event waiting in detach","message":"Replace blind retry with libvirt event waiting in detach\n\nNova so far applied a retry loop that tried to periodically detach the\ndevice from libvirt while the device was visible in the domain xml. This\ncould lead to an issue where an already progressing detach on the\nlibvirt side is interrupted by nova re-sending the detach request for\nthe same device. See bug #1882521 for more information.\n\nAlso if there was both a persistent and a live domain the nova tried the\ndetach from both at the same call. This lead to confusion about the\nresult when such call failed. Was the detach failed partially?\n\nWe can do better, at least for the live detach case. Based on the\nlibvirt developers detaching from the persistent domain always\nsucceeds and it is a synchronous process. Detaching from the live\ndomain can be both synchronous or asynchronous depending on the guest\nOS and the load on the hypervisor. But for live detach libvirt always\nsends an event [1] nova can wait for.\n\nSo this patch does two things.\n\n1) Separates the detach from the persistent domain from the detach from\n   the live domain to make the error cases clearer.\n\n2) Changes the retry mechanism.\n\n   Detaching from the persistent domain is not retried. If libvirt\n   reports device not found, while both persistent and live detach\n   is needed, the error is ignored, and the process continues with\n   the live detach. In any other case the error considered as fatal.\n\n   Detaching from the live domain is changed to always wait for the\n   libvirt event. In case of timeout, the live detach is retried.\n   But a failure event from libvirt considered fatal, based on the\n   information from the libvirt developers, so in this case the\n   detach is not retried.\n\nRelated-Bug: #1882521\n\n[1]https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectDomainEventDeviceRemovedCallback\n\nChange-Id: I7f2b6330decb92e2838aa7cee47fb228f00f47da\n(cherry picked from commit e56cc4f439846558fc13298c2360d7cdd473cc89)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/30317e6b3f5ee5e7fd1e8c564a1d6f3e3a2fb91b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/30317e6b3f5ee5e7fd1e8c564a1d6f3e3a2fb91b"}]},"parents_data":[{"branch_name":"refs/heads/stable/wallaby","commit_id":"a5ce4d806172f9d144633f297163e088c8ed1491","is_merged_in_target_branch":false}],"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}