)]}'
{"nova/api/openstack/compute/contrib/floating_ips_bulk.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"fd39c1126ef929b011d06adad2f4a2ff9ba6b214","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                floating_ips \u003d db.floating_ip_get_all_by_host(context, host)"},{"line_number":58,"context_line":"        except exception.FloatingIpNotFoundForHost as e:"},{"line_number":59,"context_line":"            msg \u003d _(\"Floating ip not found for host %s\") % host"},{"line_number":60,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":61,"context_line":"        except exception.NoFloatingIpsDefined:"},{"line_number":62,"context_line":"            return floating_ip_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FQb4%3D","line":59,"updated":"2014-03-07 08:13:27.000000000","message":"if host is None, will this give a log like:\nhost None ?","commit_id":"72b059598bb50658a498e68ec2c3b06de9af71f8"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"0d7acbb77a532db2c85f3c2ea4e33cd0e76ceb81","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                floating_ips \u003d db.floating_ip_get_all_by_host(context, host)"},{"line_number":58,"context_line":"        except exception.FloatingIpNotFoundForHost as e:"},{"line_number":59,"context_line":"            msg \u003d _(\"Floating ip not found for host %s\") % host"},{"line_number":60,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":61,"context_line":"        except exception.NoFloatingIpsDefined:"},{"line_number":62,"context_line":"            return floating_ip_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B9%2FI%3D","line":59,"in_reply_to":"AAAAVn%2F%2B%2Boo%3D","updated":"2014-03-11 00:12:55.000000000","message":"We can see there is another exception \u0027NoFloatingIpsDefined\u0027 which will be caught here, so I will think about the scope for both of the exceptions.\nThank you.","commit_id":"72b059598bb50658a498e68ec2c3b06de9af71f8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f8729980238d200e8ff3ba0d9c9a9cda581760d6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                floating_ips \u003d db.floating_ip_get_all_by_host(context, host)"},{"line_number":58,"context_line":"        except exception.FloatingIpNotFoundForHost as e:"},{"line_number":59,"context_line":"            msg \u003d _(\"Floating ip not found for host %s\") % host"},{"line_number":60,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":61,"context_line":"        except exception.NoFloatingIpsDefined:"},{"line_number":62,"context_line":"            return floating_ip_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B%2Boo%3D","line":59,"in_reply_to":"AAAAVn%2F%2FQZo%3D","updated":"2014-03-10 22:13:08.000000000","message":"Maybe it should be scoped to just that call then, because it\u0027s in a try catch where host is checked against None, so this is confusing.  Also, use IP in the message rather than \u0027ip\u0027.","commit_id":"72b059598bb50658a498e68ec2c3b06de9af71f8"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"75b93030d0e081ec60febdbac11a07f924e61315","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                floating_ips \u003d db.floating_ip_get_all_by_host(context, host)"},{"line_number":58,"context_line":"        except exception.FloatingIpNotFoundForHost as e:"},{"line_number":59,"context_line":"            msg \u003d _(\"Floating ip not found for host %s\") % host"},{"line_number":60,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":61,"context_line":"        except exception.NoFloatingIpsDefined:"},{"line_number":62,"context_line":"            return floating_ip_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FQZo%3D","line":59,"in_reply_to":"AAAAVn%2F%2FQb4%3D","updated":"2014-03-07 08:18:34.000000000","message":"No, this exception is raised by floating_ip_get_all_by_host, so host can\u0027t be None.","commit_id":"72b059598bb50658a498e68ec2c3b06de9af71f8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"596caeedbd1d5d6797e445184ba4fb4078441e46","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            try:"},{"line_number":60,"context_line":"                floating_ips \u003d db.floating_ip_get_all_by_host(context, host)"},{"line_number":61,"context_line":"            except exception.FloatingIpNotFoundForHost as e:"},{"line_number":62,"context_line":"                msg \u003d _(\"Floating IP not found for host %s\") % host"},{"line_number":63,"context_line":"                raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2B9UE%3D","line":61,"updated":"2014-03-11 02:14:34.000000000","message":"\"as e\" seems unnecessary because it is not used.","commit_id":"5aa7cc1d85aa97a6e30e1c98f57e6f126996f551"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"e2f03f98a53e2bd8dba418858491c04cd83b2ecb","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            try:"},{"line_number":60,"context_line":"                floating_ips \u003d db.floating_ip_get_all_by_host(context, host)"},{"line_number":61,"context_line":"            except exception.FloatingIpNotFoundForHost as e:"},{"line_number":62,"context_line":"                msg \u003d _(\"Floating IP not found for host %s\") % host"},{"line_number":63,"context_line":"                raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2B9R0%3D","line":61,"in_reply_to":"AAAAVn%2F%2B9UE%3D","updated":"2014-03-11 02:18:18.000000000","message":"Done. Thank you.","commit_id":"5aa7cc1d85aa97a6e30e1c98f57e6f126996f551"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"49ff53440aee1977d8d0634238d375f765f43f68","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                floating_ips \u003d db.floating_ip_get_all_by_host(context, host)"},{"line_number":61,"context_line":"            except exception.FloatingIpNotFoundForHost:"},{"line_number":62,"context_line":"                msg \u003d _(\"Floating IP not found for host %s\") % host"},{"line_number":63,"context_line":"                raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        for floating_ip in floating_ips:"},{"line_number":66,"context_line":"            instance_uuid \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2B9PM%3D","line":63,"updated":"2014-03-11 02:27:56.000000000","message":"Sorry for my previous review.\n\nclass FloatingIpNotFoundForHost is defined like:\n\n class FloatingIpNotFoundForHost(FloatingIpNotFound):\n     msg_fmt \u003d _(\"Floating ip not found for host %(host)s.\")\n\nand floating_ip_get_all_by_host() raises\n\n      raise exception.FloatingIpNotFoundForHost(host\u003dhost)\n\nso we can modify here to\n\n except exception.FloatingIpNotFoundForHost as e:\n     raise webob.exc.HTTPNotFound(explanation\u003de.format_message())\n\nwithout a new message.","commit_id":"94f6412b547144bb057a5621dc5d3711dfc83acc"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"2e54d55a3b99128c29d7ba8eaeabdaae1204ca5d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                floating_ips \u003d db.floating_ip_get_all_by_host(context, host)"},{"line_number":61,"context_line":"            except exception.FloatingIpNotFoundForHost:"},{"line_number":62,"context_line":"                msg \u003d _(\"Floating IP not found for host %s\") % host"},{"line_number":63,"context_line":"                raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        for floating_ip in floating_ips:"},{"line_number":66,"context_line":"            instance_uuid \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2B9HA%3D","line":63,"in_reply_to":"AAAAVn%2F%2B9PM%3D","updated":"2014-03-11 02:54:53.000000000","message":"That\u0027s good, thank you.","commit_id":"94f6412b547144bb057a5621dc5d3711dfc83acc"}]}