)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"8d5fdb35dc9844f2d18edf44f73b0c2eaa17d81c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            try:"},{"line_number":163,"context_line":"                # ensure the bridge is available and iptable rules are"},{"line_number":164,"context_line":"                # inserted after a restart of service"},{"line_number":165,"context_line":"                network_ref \u003d self.db.network_get_by_instance(context,"},{"line_number":166,"context_line":"                                                              instance_id)"},{"line_number":167,"context_line":"                self.network_manager.driver.plug(network_ref, None)"},{"line_number":168,"context_line":"            except exception.NetworkNotFoundForInstance:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F850%3D","line":165,"updated":"2011-10-12 16:38:32.000000000","message":"The network database and the compute database may not be the same (for example, using quantum). This should call out to the network_api to retrieve the networks.","commit_id":"9f64a78b140deb4ee7cb4656e64fde4e484622cd"},{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"052958cf46a201e944cb4abf55418c0460f64c5f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                # inserted after a restart of service"},{"line_number":165,"context_line":"                network_ref \u003d self.db.network_get_by_instance(context,"},{"line_number":166,"context_line":"                                                              instance_id)"},{"line_number":167,"context_line":"                self.network_manager.driver.plug(network_ref, None)"},{"line_number":168,"context_line":"            except exception.NetworkNotFoundForInstance:"},{"line_number":169,"context_line":"                LOG.info(_(\u0027Network cannot be found for instance %s - cannot \u0027"},{"line_number":170,"context_line":"                        \u0027create a bridge at the moment\u0027), instance_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F9Vc%3D","line":167,"updated":"2011-10-07 21:20:24.000000000","message":"I get the feeling that we shouldn\u0027t be calling the network manager from the compute manager. I\u0027m fairly certain that the managers should always be invoked from their API layer and not directly. \n\nDoes removing this and keeping the linux_net.py change still fix the problem? From the bug description it seems like we\u0027re just not calling \"apply\", which is fixed in the linux_net patch.","commit_id":"9f64a78b140deb4ee7cb4656e64fde4e484622cd"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"65e25b5eaaf346abcc4455501d2aa7fb321b03a2","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                network_ref \u003d self.db.network_get_by_instance(context,"},{"line_number":166,"context_line":"                                                              instance_id)"},{"line_number":167,"context_line":"                self.network_manager.driver.plug(network_ref, None)"},{"line_number":168,"context_line":"            except exception.NetworkNotFoundForInstance:"},{"line_number":169,"context_line":"                LOG.info(_(\u0027Network cannot be found for instance %s - cannot \u0027"},{"line_number":170,"context_line":"                        \u0027create a bridge at the moment\u0027), instance_id)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F8xw%3D","line":168,"updated":"2011-10-13 00:50:45.000000000","message":"blamar is right.  You can\u0027t make a direct call to network manager from compute manager.  It looks like ComputeManager\u0027s __init__() has a self.network_manager \u003d line (line 142) that needs to be removed.  It\u0027s not used anywhere at all...  until this patch... but it should not be used.\n\nInstead, an API call should be created in nova/network/api.py which does a cast to the network manager.","commit_id":"9f64a78b140deb4ee7cb4656e64fde4e484622cd"}],"nova/tests/test_compute.py":[{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"8d5fdb35dc9844f2d18edf44f73b0c2eaa17d81c","unresolved":false,"context_lines":[{"line_number":1632,"context_line":"        db.instance_destroy(self.context, refs[0][\u0027id\u0027])"},{"line_number":1633,"context_line":""},{"line_number":1634,"context_line":""},{"line_number":1635,"context_line":"class VlanComputeTestCase(test.TestCase):"},{"line_number":1636,"context_line":"    \"\"\"Test case for compute\"\"\""},{"line_number":1637,"context_line":"    def setUp(self):"},{"line_number":1638,"context_line":"        super(VlanComputeTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F85U%3D","line":1635,"updated":"2011-10-12 16:38:32.000000000","message":"I think this should probably be renamed, as it really doesn\u0027t test anything nova-network related and is confusing. Perhaps this could just be called InitHostTestCase?","commit_id":"9f64a78b140deb4ee7cb4656e64fde4e484622cd"}]}