)]}'
{"nova/tests/virt/xenapi/test_vmops.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"21d9fc555509f03a6bd00c3aeab5941ed3fd4448","unresolved":false,"context_lines":[{"line_number":850,"context_line":"        self.vmops._resize_up_vdis(instance, {\"root\": {}})"},{"line_number":851,"context_line":"        self.assertFalse(mock_resize.called)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    def test_resize_up_vdis_no_vdis_like_initial_spawn(self, mock_resize):"},{"line_number":854,"context_line":"        instance \u003d {\"root_gb\": 0, \"ephemeral_gb\": 3000}"},{"line_number":855,"context_line":"        vdis \u003d {}"},{"line_number":856,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FN5M%3D","line":853,"updated":"2014-03-07 15:12:58.000000000","message":"This doesn\u0027t seem to be testing your code change.  This breaks out of _resize_up_vdis because there\u0027s no \u0027root\u0027 key/value in vdis, not because ephemeral is missing.","commit_id":"38d049ad0b9d169b965383b093d49e9c724c084d"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"2c110f35099fc2a508537433779c2e09118eaa7d","unresolved":false,"context_lines":[{"line_number":850,"context_line":"        self.vmops._resize_up_vdis(instance, {\"root\": {}})"},{"line_number":851,"context_line":"        self.assertFalse(mock_resize.called)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    def test_resize_up_vdis_no_vdis_like_initial_spawn(self, mock_resize):"},{"line_number":854,"context_line":"        instance \u003d {\"root_gb\": 0, \"ephemeral_gb\": 3000}"},{"line_number":855,"context_line":"        vdis \u003d {}"},{"line_number":856,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FNb0%3D","line":853,"in_reply_to":"AAAAVn%2F%2FN5M%3D","updated":"2014-03-07 16:11:23.000000000","message":"+1","commit_id":"38d049ad0b9d169b965383b093d49e9c724c084d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a82567df62429a77520d1bc253a2f86279f59936","unresolved":false,"context_lines":[{"line_number":850,"context_line":"        self.vmops._resize_up_vdis(instance, {\"root\": {}})"},{"line_number":851,"context_line":"        self.assertFalse(mock_resize.called)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    def test_resize_up_vdis_no_vdis_like_initial_spawn(self, mock_resize):"},{"line_number":854,"context_line":"        instance \u003d {\"root_gb\": 0, \"ephemeral_gb\": 3000}"},{"line_number":855,"context_line":"        vdis \u003d {}"},{"line_number":856,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FNa4%3D","line":853,"in_reply_to":"AAAAVn%2F%2FN5M%3D","updated":"2014-03-07 16:15:04.000000000","message":"It did seem to repo the error then, I applied the fix and it stopped failing.\n\nit doesn\u0027t bail with no root_gb, it continues to the ephemeral, I think, I will double check","commit_id":"38d049ad0b9d169b965383b093d49e9c724c084d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9f0ab58cd09ff581eb3664fb62dcc57566335954","unresolved":false,"context_lines":[{"line_number":850,"context_line":"        self.vmops._resize_up_vdis(instance, {\"root\": {}})"},{"line_number":851,"context_line":"        self.assertFalse(mock_resize.called)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    def test_resize_up_vdis_no_vdis_like_initial_spawn(self, mock_resize):"},{"line_number":854,"context_line":"        instance \u003d {\"root_gb\": 0, \"ephemeral_gb\": 3000}"},{"line_number":855,"context_line":"        vdis \u003d {}"},{"line_number":856,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FNR0%3D","line":853,"in_reply_to":"AAAAVn%2F%2FNXQ%3D","updated":"2014-03-07 16:29:02.000000000","message":"ah, got ya, I didn\u0027t like the extra return, its not very symmetric, but the indentation was madness, then the patch ballooned too big to a bug fix when I refactored it a bit, so I just whet with the tiny fix :(","commit_id":"38d049ad0b9d169b965383b093d49e9c724c084d"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"041dbeb822e1fd8441988232bd9a0e9e86bb6045","unresolved":false,"context_lines":[{"line_number":850,"context_line":"        self.vmops._resize_up_vdis(instance, {\"root\": {}})"},{"line_number":851,"context_line":"        self.assertFalse(mock_resize.called)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    def test_resize_up_vdis_no_vdis_like_initial_spawn(self, mock_resize):"},{"line_number":854,"context_line":"        instance \u003d {\"root_gb\": 0, \"ephemeral_gb\": 3000}"},{"line_number":855,"context_line":"        vdis \u003d {}"},{"line_number":856,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FNXQ%3D","line":853,"in_reply_to":"AAAAVn%2F%2FNa4%3D","updated":"2014-03-07 16:20:10.000000000","message":"woops, you\u0027re correct.  I was thinking the return was for both cases when looking at tests.","commit_id":"38d049ad0b9d169b965383b093d49e9c724c084d"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"2c110f35099fc2a508537433779c2e09118eaa7d","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"            vm_utils.update_vdi_virtual_size(self._session, instance,"},{"line_number":1081,"context_line":"                                             vdi_ref, new_root_gb)"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"        ephemeral_vdis \u003d vdis.get(\u0027ephemerals\u0027)"},{"line_number":1084,"context_line":"        if not ephemeral_vdis:"},{"line_number":1085,"context_line":"            return"},{"line_number":1086,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FNbw%3D","line":1083,"updated":"2014-03-07 16:11:23.000000000","message":"Drop a comment here stating that in the instance create code flow the ephemeral disk haven\u0027t been created yet?","commit_id":"38d049ad0b9d169b965383b093d49e9c724c084d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a82567df62429a77520d1bc253a2f86279f59936","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"            vm_utils.update_vdi_virtual_size(self._session, instance,"},{"line_number":1081,"context_line":"                                             vdi_ref, new_root_gb)"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"        ephemeral_vdis \u003d vdis.get(\u0027ephemerals\u0027)"},{"line_number":1084,"context_line":"        if not ephemeral_vdis:"},{"line_number":1085,"context_line":"            return"},{"line_number":1086,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FNas%3D","line":1083,"in_reply_to":"AAAAVn%2F%2FNbw%3D","updated":"2014-03-07 16:15:04.000000000","message":"yeah, good call.","commit_id":"38d049ad0b9d169b965383b093d49e9c724c084d"}]}