)]}'
{"nova/compute/utils.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0e9ae4572d6728cec7283e4554a31cf71eac94a8","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"    \"\"\""},{"line_number":1250,"context_line":"    image_meta \u003d utils.get_image_from_system_metadata("},{"line_number":1251,"context_line":"        instance.system_metadata)"},{"line_number":1252,"context_line":"    # NOTE(lyarwood): get_image_from_system_metadata now populates \u0027id\u0027 from"},{"line_number":1253,"context_line":"    # instance.image_ref so we need to ensure it\u0027s removed here as we want"},{"line_number":1254,"context_line":"    # to create a fresh image."},{"line_number":1255,"context_line":"    image_meta.pop(\u0027id\u0027)"},{"line_number":1256,"context_line":"    image_meta[\u0027name\u0027] \u003d name"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    # If the user creating the snapshot is not in the same project as"}],"source_content_type":"text/x-python","patch_set":2,"id":"d3019d6f_ecbcbe1f","line":1255,"range":{"start_line":1252,"start_character":0,"end_line":1255,"end_character":24},"updated":"2021-05-14 09:38:53.000000000","message":"This has caused a load of fallout when booting from a volume snapshot AFAICT, I\u0027ll fix this up and respin now.","commit_id":"7b5de79b861cea9c6bed516d3c804e435beb13be"}],"nova/utils.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"559106f7c693e15621cf04090018dee18cc3f245","unresolved":true,"context_lines":[{"line_number":782,"context_line":"    # FIXME(lyarwood): Remove this once we have an online migration populating"},{"line_number":783,"context_line":"    # this for all instances."},{"line_number":784,"context_line":"    if image_meta.get(\u0027id\u0027) is None and instance.image_ref:"},{"line_number":785,"context_line":"        image_meta[\u0027id\u0027] \u003d instance.image_ref"},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"    return image_meta"},{"line_number":788,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0c71d2b5_773df226","line":785,"updated":"2021-05-11 19:02:26.000000000","message":"I\u0027m not sure I get the point of the change to stash the image.id in the sysmeta. It seems like what you have here should pretty much always work, and if we did that, we\u0027d have image_meta include id when we pass it to hardware.\n\nIs there some reason instance.image_ref gets lost when it wouldn\u0027t be lost in sysmeta? Are you proposing that we (eventually) drop the image_ref column too?","commit_id":"a78e92b6a1bba8166e3561d3e2d4d845657a1d77"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2c50f651a85aa2a3269573b6df1ff5b471a93529","unresolved":true,"context_lines":[{"line_number":782,"context_line":"    # FIXME(lyarwood): Remove this once we have an online migration populating"},{"line_number":783,"context_line":"    # this for all instances."},{"line_number":784,"context_line":"    if image_meta.get(\u0027id\u0027) is None and instance.image_ref:"},{"line_number":785,"context_line":"        image_meta[\u0027id\u0027] \u003d instance.image_ref"},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"    return image_meta"},{"line_number":788,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b35aa0d1_049c7277","line":785,"in_reply_to":"0c71d2b5_773df226","updated":"2021-05-12 08:53:02.000000000","message":"Yeah this is all ground work for resolving bug #1928063 and likely a slew of other issues where we\u0027ve assumed the image_meta dict being passed around is fully populated when it is in fact only partially populated from instance.system_metadata.\n\nWe could change *all* of the places where we assume we have access to things like image_meta.name etc to instance.image_ref but that would cause lots of churn when we could just stash it in system_metadata for new instances and quickly add it in to image_meta for existing instances.","commit_id":"a78e92b6a1bba8166e3561d3e2d4d845657a1d77"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"fbd726c6ee45d65ee18cdd574023d61f536c5358","unresolved":true,"context_lines":[{"line_number":782,"context_line":"    # FIXME(lyarwood): Remove this once we have an online migration populating"},{"line_number":783,"context_line":"    # this for all instances."},{"line_number":784,"context_line":"    if image_meta.get(\u0027id\u0027) is None and instance.image_ref:"},{"line_number":785,"context_line":"        image_meta[\u0027id\u0027] \u003d instance.image_ref"},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"    return image_meta"},{"line_number":788,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"17e131bc_dfc52a8b","line":785,"in_reply_to":"b35aa0d1_049c7277","updated":"2021-05-12 08:53:44.000000000","message":"s/dict/objects/g","commit_id":"a78e92b6a1bba8166e3561d3e2d4d845657a1d77"}]}