)]}'
{"id":"openstack%2Fnova~790945","triplet_id":"openstack%2Fnova~master~I2d7f814f811139a65546ba2360a40d216e7adf12","project":"openstack/nova","branch":"master","hashtags":[],"change_id":"I2d7f814f811139a65546ba2360a40d216e7adf12","subject":"tests: Remove \u0027create_fake_libvirt_mock\u0027","status":"ABANDONED","created":"2021-05-12 10:29:30.000000000","updated":"2025-01-28 16:49:42.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"56804f2e442f90c26b058a6e01fcf8bfabfd47d2","_number":790945,"virtual_id_number":790945,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2021-05-26 16:50:09.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-12 10:56:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-12 10:57:28.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-05-12 13:03:30.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"}],"messages":[{"id":"f55d0892f031fea1c5d1e8857876cc0b5beb05a7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-05-12 10:29:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1bc03580415be0fd47239720561f2306ec208176","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-12 10:56:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/079fb1df271f4e90a3ddeddd5578e6d2 : SUCCESS in 19m 01s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/65ab6ebb6ccd47e2a02ca6d064be14d8 : SUCCESS in 14m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d398b2712b814595a61e898f58175972 : SUCCESS in 7m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/91a7601ae8414134938bae1608f15fa7 : SUCCESS in 13m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a0fb8dd111fe49aba3ba9a56b0758180 : SUCCESS in 13m 30s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/46767dee5f6c4c84a6181dbdb636aa64 : SUCCESS in 13m 44s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8a6e0b07954847a5b5b4cf86c59dcc76 : SUCCESS in 10m 28s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/d5bad31a5afd44ca90322c9e1c5d80e7 : SUCCESS in 20m 51s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/e51e2f8dbd2c4cdd877886ea3fda93b0 : SUCCESS in 17m 45s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"357b75f818045e0469dd3bbba001fc0d0f0818f0","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-05-12 10:57:28.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/45/790945/1/check/EMC_PowerFlex_NOVA/3f19444/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":1},{"id":"c45cf9e0692861b0a2b8dbfee7730065b1f2c1c1","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-12 11:07:40.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/801264e7e90048c38fb1fd4dea30d1f2 : SUCCESS in 27m 50s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/6f911ae0930e4863838deceb7e354180 : SUCCESS in 27m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f70e72d4cde000c7dfd8b4c96cea035b7d749c04","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-05-12 11:08:09.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/45/790945/1/check/EMC_PowerFlex_NOVA/b9298ef/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":1},{"id":"7c236cd68c94842fdd8fe00a6cb470b8102baa4d","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-05-12 13:03:30.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/790945/1/iscsi : SUCCESS in 2h 29m 27s","accounts_in_message":[],"_revision_number":1},{"id":"3d686b5f2a0b4852bd05512df5a24cc0a8131720","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-05-26 16:26:44.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"fbd9bd2f27e831d5a1ca6cc601e90ad24446a173","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 16:50:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d246e0c180364299bfa54dc521e74afb : SUCCESS in 21m 02s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7e3d9109ffe04167a2593a9674acdab2 : SUCCESS in 13m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/658a19eaa9f64f16ab99084ef09dd98e : SUCCESS in 8m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2d84d8c74a6c41d9ab297ed6f9c27049 : SUCCESS in 15m 43s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2b8ca8e5b45e426f980c97a36acd405b : SUCCESS in 13m 24s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/071cc245876849048aa9dab088a1a2ef : SUCCESS in 13m 56s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/120b3fc0d2474731b01c24dbf33c87c0 : SUCCESS in 9m 52s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/5c4d62f3602f4c25bf63061dd3b2cdd6 : SUCCESS in 19m 34s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/4ce63488eb6749c39062b3db91e2c481 : SUCCESS in 17m 21s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f1b15c0ee197594fd65774dd96d4d08aa02df9be","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 17:00:43.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/71811dfb45c14208a1c956a4dbfeff2b : SUCCESS in 26m 05s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/736781e0b8a344819c0b5c05d49bf033 : SUCCESS in 25m 44s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"635f2c1f05f5c17ce0531870b5e4f194ceb481eb","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-05-26 19:10:05.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/790945/2/iscsi : FAILURE in 2h 40m 43s","accounts_in_message":[],"_revision_number":2},{"id":"56804f2e442f90c26b058a6e01fcf8bfabfd47d2","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-01-28 16:49:42.000000000","message":"Abandoned\n\nNeeds a rebase. Can be taken by someone else if needed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4507e52e1314875c95a4346523d1c0ccaa28817b","revisions":{"fd1562331265eb76804788782e2a0f66524e6d63":{"kind":"REWORK","_number":1,"created":"2021-05-12 10:29:30.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/45/790945/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/45/790945/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/790945/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/790945/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/790945/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/45/790945/1"}}},"commit":{"parents":[{"commit":"2569cc0f1672d1e7aea87fdb4c79fa2500408a0c","subject":"libvirt: Enable \u0027vmcoreinfo\u0027 feature by default","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2569cc0f1672d1e7aea87fdb4c79fa2500408a0c"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-05-11 17:14:02.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-05-11 17:14:02.000000000","tz":60},"subject":"tests: Remove \u0027create_fake_libvirt_mock\u0027","message":"tests: Remove \u0027create_fake_libvirt_mock\u0027\n\nThis is no longer necessary, as our fakelibvirt fixture is sufficiently\nwell developed to handle virtually all use cases required by these\ntests. The sole exceptions are tests that do tests on instances before\n\"creating\" the instance. Calls to \u0027lookupByUUIDString\u0027 inside these\ntests fail since the fakelibvirt fixture has no record of the fake\ninstance, so we resolve this by simply mocking out that helper.\n\nChange-Id: I2d7f814f811139a65546ba2360a40d216e7adf12\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fd1562331265eb76804788782e2a0f66524e6d63"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fd1562331265eb76804788782e2a0f66524e6d63"}]},"branch":"refs/heads/master"},"4507e52e1314875c95a4346523d1c0ccaa28817b":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-05-26 16:26:44.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/45/790945/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/45/790945/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/790945/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/790945/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/790945/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/45/790945/2"}}},"commit":{"parents":[{"commit":"740e6f09bf5a3e5ab3c6dd6d412dd1fe33f81d9f","subject":"libvirt: Enable \u0027vmcoreinfo\u0027 feature by default","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/740e6f09bf5a3e5ab3c6dd6d412dd1fe33f81d9f"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-05-11 17:14:02.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-05-26 16:26:05.000000000","tz":60},"subject":"tests: Remove \u0027create_fake_libvirt_mock\u0027","message":"tests: Remove \u0027create_fake_libvirt_mock\u0027\n\nThis is no longer necessary, as our fakelibvirt fixture is sufficiently\nwell developed to handle virtually all use cases required by these\ntests. The sole exceptions are tests that do tests on instances before\n\"creating\" the instance. Calls to \u0027lookupByUUIDString\u0027 inside these\ntests fail since the fakelibvirt fixture has no record of the fake\ninstance, so we resolve this by simply mocking out that helper.\n\nChange-Id: I2d7f814f811139a65546ba2360a40d216e7adf12\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4507e52e1314875c95a4346523d1c0ccaa28817b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4507e52e1314875c95a4346523d1c0ccaa28817b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}