)]}'
{"id":"openstack%2Fnova~791483","triplet_id":"openstack%2Fnova~stable%2Fvictoria~I95882ea28564a31a6b4f8b665de462774d84edfc","project":"openstack/nova","branch":"stable/victoria","attention_set":{},"removed_from_attention_set":{"10135":{"account":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"last_update":"2024-03-05 19:00:00.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I95882ea28564a31a6b4f8b665de462774d84edfc","subject":"api: Reject requests to force up computes when `done` evacuation records exist","status":"ABANDONED","created":"2021-05-14 13:31:31.000000000","updated":"2024-03-05 19:00:00.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4b62969899eb34009e5da623eedf46b29f6189f2","_number":791483,"virtual_id_number":791483,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-05-14 15:16:03.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-14 15:16:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-14 15:47:10.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-05-14 17:58:11.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2024-03-05 19:00:00.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"eacff0468d106b04074ac6bb878b030739d191b1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-05-14 13:31:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"254550e0f9ac0e18d7e32e9d9daaffbbc0ce0e64","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-14 15:16:03.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/fba3d7ba5b11443b817f76955da8b8ad : SUCCESS in 1h 17m 52s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3d1b6b0663ae41a7ba28281d4f070eb9 : SUCCESS in 18m 02s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/45c8e89cdde940f5b0816ef5e8b6b4c7 : SUCCESS in 15m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9534534df8974c49a0b9d6444cee8801 : FAILURE in 8m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/56055c484b974efe963a8c95a2801f0a : SUCCESS in 15m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/38244a0948314e96a2d7debf0bd36938 : SUCCESS in 13m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a62caad011c64a4f85485e95d5b7bd22 : SUCCESS in 12m 42s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/9a012a7cdf3a43009285f51a2615032f : SUCCESS in 1h 13m 54s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/82046dd0c1654d0aa3bbcd18e7f068b9 : SUCCESS in 1h 15m 05s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/60f7118b8bc6439483581d2f1aaad38d : SUCCESS in 1h 02m 19s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/0b926dddd3fe416e9995c82dd8d079c8 : SUCCESS in 53m 14s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/134bc91d984f465787307366fac26187 : SUCCESS in 1h 17m 44s\n- nova-next https://zuul.opendev.org/t/openstack/build/3513d72068144aba9b3a603f488ce506 : SUCCESS in 1h 38m 47s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/68504283ad3948008380b48c9bac1e66 : SUCCESS in 20m 03s\n- grenade https://zuul.opendev.org/t/openstack/build/63de78cf2d854fea9bc54679d536551b : SUCCESS in 1h 12m 26s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/d7532586fecb4d349c2d70b4c89142c8 : SUCCESS in 55m 55s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/764b729e825c42a79791dbedf3298e66 : SUCCESS in 53m 21s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/00e21bd28d1d41ea89eaef83678497f0 : SUCCESS in 29m 29s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/eb55a6bf71fa4ceea1fb9e526b09d452 : SUCCESS in 43m 37s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6d4f377ca33f9a4147490c575b0066ec3e988bc2","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-05-14 15:47:10.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/7cf103df068b490c9086f085ed83c271 : POST_FAILURE in 1h 31m 22s","accounts_in_message":[],"_revision_number":1},{"id":"5f0b45e66d6439218174ecafaebc456881b3cb83","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-05-14 17:58:11.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/791483/1/iscsi : SUCCESS in 2h 26m 44s","accounts_in_message":[],"_revision_number":1},{"id":"4b62969899eb34009e5da623eedf46b29f6189f2","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-03-05 19:00:00.000000000","message":"Abandoned\n\nstable/victoria branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"25993dfcad4bdab169a71425db191550f6a6699f","revisions":{"25993dfcad4bdab169a71425db191550f6a6699f":{"kind":"REWORK","_number":1,"created":"2021-05-14 13:31:31.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/83/791483/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/83/791483/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/83/791483/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/83/791483/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/83/791483/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/83/791483/1"}}},"commit":{"parents":[{"commit":"1d144f9de1768ab5fff034f459e49bd68e758893","subject":"Add regression test for bug #1922053","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1d144f9de1768ab5fff034f459e49bd68e758893"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-31 10:00:57.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-05-14 13:21:40.000000000","tz":60},"subject":"api: Reject requests to force up computes when `done` evacuation records exist","message":"api: Reject requests to force up computes when `done` evacuation records exist\n\nWhen evacuating an instance the evacuation migration record moves from a\nstate of `accepted` to `pre-migrating` and eventually `done` once the\ninstance has been rebuilt on the new compute host. At present the\nmigration record remains in this state until the original compute host\nis restarted and the service cleans up any leftovers of the instance\nbefore it is moved to a state of `completed`.\n\nBug #1922053 details a use case where an operator might unintentionally\nforget to ensure the compute service is restarted before forcing the\nservice up leaving evacuation migration records stuck as `done`.\n\nThis could become an issue in the future if the instance is moved back\nto this compute before the service is restarted. Any future restart\ninvoking the cleanup logic and potentially damaging the running\ninstance.\n\nThis change aims to address this by blocking requests to force up\ncomputes associated to `done` evacuation records. Forcing operators to\nrestart the service allowing them to move to a `completed` state before\nthe service can be forced up again.\n\nTo allow this to be backportable these requests are rejected with a 400\nBadRequest return code from the API. A TODO is left to move this to a\n409 Conflict during the Xena release under a new microversion.\n\nFinally, some additional functional tests have been updated to ensure\nthey restart the source compute service of an evacuation before\nattempting to force up the service, ensuring any migration records are\nmarked as completed.\n\nCloses-Bug: #1922053\nChange-Id: I95882ea28564a31a6b4f8b665de462774d84edfc\n(cherry picked from commit bf89a23d91f01a29ba9b19bd0accf8de8c05f2f7)\n(cherry picked from commit f9b1c1f9b046745276046b6e940d01211a323913)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/25993dfcad4bdab169a71425db191550f6a6699f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/25993dfcad4bdab169a71425db191550f6a6699f"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}