)]}'
{"id":"openstack%2Fnova~791502","triplet_id":"openstack%2Fnova~master~I7d11ef8abb30686f9d125cac0e48369eab839b0f","project":"openstack/nova","branch":"master","topic":"bp/qos-minimum-guaranteed-packet-rate","hashtags":[],"change_id":"I7d11ef8abb30686f9d125cac0e48369eab839b0f","subject":"Fix RequestLevelParams persistence handling in RequestSpec","status":"MERGED","created":"2021-05-14 15:10:46.000000000","updated":"2021-06-04 10:21:37.000000000","submitted":"2021-06-04 10:19:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":3,"has_review_started":true,"submission_id":"791502-bp/qos-minimum-guaranteed-packet-rate","meta_rev_id":"22a96c829bb9360117827591fbb2493ef54db4ef","_number":791502,"virtual_id_number":791502,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-06-04 10:19:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":1,"date":"2021-06-04 10:21:37.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2021-06-04 10:21:37.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2021-06-04 10:21:37.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":1,"date":"2021-06-04 08:45:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-14 15:14:52.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2021-05-14 15:14:52.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2021-05-14 15:44:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-05-14 17:07:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-14 17:08:46.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-05-14 19:00:48.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-05-14 19:40:01.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-05-18 12:37:31.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"}],"messages":[{"id":"6b147da24aa59bbd67a78ef88ccc23bd06f0e66f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-14 15:10:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f461a535137fa52885428327028ef3b59bd71059","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-14 15:44:16.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/7057cde490ef41429639a289aea9fd34 : SUCCESS in 21m 35s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/f1e05ee4504845088dd0846de58f0fcf : SUCCESS in 24m 18s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"86cffea846820d154e29a7c88706801848654c51","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-14 15:44:26.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"7f467fc154b3136d2a6cd751de103a9745c0d3c7","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-14 16:14:46.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/8118a9dac495475998c928cd2179a053 : SUCCESS in 20m 56s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/8b4fc6841b7741178fac4b187377b1c5 : SUCCESS in 21m 29s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b10176ed2b9a16be1c6bcfd1186f9e174eb2e02a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-14 17:07:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/796927ba2d444870ab1f8d76c6818df3 : SUCCESS in 1h 07m 15s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1d511e64e7064099acfe275b57ac52eb : SUCCESS in 12m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2b8762c1267848cca6abe4e7978ea0a7 : SUCCESS in 13m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c0c6152942b54bd0b28d9bbbb723b23d : SUCCESS in 8m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d3f04e083ba249d1a44874dadcdfc3c7 : SUCCESS in 16m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/74c934ec4e3c4586808036a1833faf63 : SUCCESS in 15m 29s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a2fc4d481e8a491b8d252413a920572b : SUCCESS in 13m 51s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7c7252b60f8e47f289aa98bb71603b35 : SUCCESS in 9m 02s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/21e5de6d66a0446eaaa11286ca1b8198 : SUCCESS in 1h 11m 27s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/8d3e3f15fe9642dc807a6cfb5d35bc40 : SUCCESS in 1h 21m 19s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/278df4f5b2ce4f618c4c77a44a56847f : SUCCESS in 37m 46s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/bbee4ac351a44ee29dd64df768378372 : SUCCESS in 38m 22s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/8d9852e73c2546dc84ed790ea68c065c : SUCCESS in 1h 11m 55s\n- nova-next https://zuul.opendev.org/t/openstack/build/4438c4b61c3f4ea387e9a470ff70cc8b : SUCCESS in 1h 15m 38s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/207508f2ca6c42c69a3be2e2cf163352 : SUCCESS in 14m 39s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/ca43e9f0dd28430c8009df15edfd0d74 : SUCCESS in 21m 51s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/03f636a7bbe64dd4830f23d8a4077504 : SUCCESS in 1h 00m 18s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e1410dcdcb754efe8c56d7079ed9b355 : SUCCESS in 56m 46s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/e1b69fad887f4e42b16d49f781d9c738 : SUCCESS in 54m 34s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/d8dcfbc9199a4501a700497c62923ddb : SUCCESS in 20m 48s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/96b89f50042e4341a92ae8095d6f13c7 : SUCCESS in 31m 47s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b8921cb3c6b40f4f2c7dc3976898d418988ea7ce","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-05-14 17:08:46.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/02/791502/2/check/EMC_PowerFlex_NOVA/2ce37cf/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":2},{"id":"4b8f8a7acf90243e7968079c109721ce36a372c2","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-05-14 19:00:48.000000000","message":"Patch Set 2:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/791502/2/iscsi : SUCCESS in 2h 39m 53s","accounts_in_message":[],"_revision_number":2},{"id":"a8798a0eed37347f55a96fe37740c1ad2d862e4e","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-05-14 19:40:01.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/89a719de695c4496a60e5c7995942823 : POST_FAILURE in 1h 03m 23s","accounts_in_message":[],"_revision_number":2},{"id":"0f3f5dff7beb5125bd864774b22c3a5c5299ed95","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2021-05-17 13:50:20.000000000","message":"Patch Set 2: Code-Review+2\n\n(2 comments)\n\nDefinitely looks like the right thing to do. Just a comment about how changing this now could lead to someone not realizing this was the past and doing something in the future that chokes on that value being NULL in the DB.","accounts_in_message":[],"_revision_number":2},{"id":"968fffaca25c473cadd57cf9816c3a9fa7242192","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-17 16:05:59.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"c062b3d9535e4599533b900593f855bfb52a3fb3","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2021-05-17 16:30:21.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"860c4ada9fb28f30bc8e56afa5c4fe2b311b6f1f","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-18 07:34:44.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8594c82c4f006345158595c169a44af738d36727","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2021-05-18 12:37:31.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c48088954ac677b154d436241ae92cda1ecb2431","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-05-19 16:30:32.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)\n\nChange makes sense to me and Dan has taken a look and signed off on it also. All good by me","accounts_in_message":[],"_revision_number":2},{"id":"9ff1c23cd5f76a83a485727aac157e13a165922b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-19 16:31:11.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"f59d08b80b9a24886570b092d361c1c3892a7c8f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-19 20:32:22.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/8ea3bf29c96a41b7bbc9236440cabd50 : SUCCESS in 1h 13m 28s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/49b48bd1b64d48bebe25864eaae25b8b : SUCCESS in 16m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7837b6f4cc4a4a5082b9e46e4ad9f4d5 : SUCCESS in 9m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bd54c6b2c5be4baa86c8e57385c6d90a : SUCCESS in 14m 48s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/251f97dbb094461a8e2f910975d9e1f0 : SUCCESS in 16m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5262d18f4f7544d1af72669315920274 : SUCCESS in 10m 14s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/8e7931876be545be8581a30639b686a6 : FAILURE in 58m 02s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/04bc4d319886430483ebc61806a083e1 : SUCCESS in 49m 09s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/2599b440bea84618beee4af6ee4ec759 : SUCCESS in 22m 09s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/7a79bbe4256741cf9887fec23825b099 : SUCCESS in 1h 41m 19s\n- nova-next https://zuul.opendev.org/t/openstack/build/c326337a072f4582b47c0cadbe78683f : SUCCESS in 1h 51m 33s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/558fda8bb7e04bed85e81701ea6d1d47 : SUCCESS in 1h 20m 29s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/61d01ad725b44ce39fa93fec46a8488b : SUCCESS in 1h 19m 21s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8df5b524424e41d1b35573d9b1ef4051 : SUCCESS in 57m 37s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/21c9f0d976dd4562987cf20480d4c1e3 : SUCCESS in 54m 09s","accounts_in_message":[],"_revision_number":2},{"id":"3aadb36511f1a85751fa441f9795b9c43666b9bf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-21 15:14:20.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"42be6b26dee70cb6a13ad798d7ad07f528854b7c","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-21 15:50:41.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/1474be8930b64eaf92c97237d7a53bc8 : SUCCESS in 33m 11s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/644d89cc4cf84f4c93a529ae95fe6a11 : SUCCESS in 33m 03s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"ed8c17bace4a6d6857c45785338bb0a88df6dad3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-21 16:54:08.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/ec3cde379d9e4ac7a7dbe0a88e0c4d3d : FAILURE in 1h 22m 37s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/41d9a5cf46fc4bce81d526fd5650d3b2 : SUCCESS in 18m 01s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/17a2c6f293d449ed99f07d1e7338a9f1 : SUCCESS in 14m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1840613383b541bf99a4758918f516c4 : SUCCESS in 9m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f73064a7a14b4c8aa1b39aa8f67aa49f : SUCCESS in 12m 39s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/69476149ac21486ba18efcbd22974a25 : SUCCESS in 14m 19s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c457f4edf06a4815a36f4554d5ce11ef : SUCCESS in 14m 03s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d59fff3c570b4f0187968b630b086c2e : SUCCESS in 10m 15s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/54a42ab4d23b46209d84d07d707ff13f : SUCCESS in 1h 17m 42s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/3e8e0778727e4afabf0d2d28b2ea205c : SUCCESS in 1h 30m 20s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/f632feaed72e484082d66aea597142a7 : FAILURE in 56m 36s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/96ab10037c4348ca9043edee897181a9 : SUCCESS in 53m 37s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/bfae7160c99d48418a5994dfa0339af1 : SUCCESS in 1h 24m 17s\n- nova-next https://zuul.opendev.org/t/openstack/build/fed4eeec5ae243e9ae178fff34d30021 : FAILURE in 1h 20m 36s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/aedb76d4606a4ce38a2b8430857f4fa3 : SUCCESS in 17m 23s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/5106d80fd1d4426dbac64eaec1a57d7d : SUCCESS in 18m 44s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/535d817e8efe46848cf29f7a72410cd3 : SUCCESS in 1h 13m 57s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/879467912445464d836d86abb9b4d95e : SUCCESS in 56m 36s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/1edf59ee556a49bab77919ad2214253a : SUCCESS in 46m 46s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/642830e720a94ff2bc6ff5f0cc681b65 : SUCCESS in 27m 34s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/19749c28365d4a1093b4ce2513566c08 : SUCCESS in 40m 47s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"8155435ed88e6042be591f0d30497b163f8d9736","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-05-21 17:42:11.000000000","message":"Patch Set 3:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/e9c940ee2fbe43d487c6892c76609256 : POST_FAILURE in 1h 50m 07s","accounts_in_message":[],"_revision_number":3},{"id":"e61649ed8d973f3e800ebbe1b4eb86c4cd9175b9","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-05-21 18:12:50.000000000","message":"Patch Set 3:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/791502/3/iscsi : SUCCESS in 2h 56m 21s","accounts_in_message":[],"_revision_number":3},{"id":"7e980b923d7d1ca339f426d243c4b9fadf0a235e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-28 12:37:51.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"62fa32fabb37410dd03f09890941f91e50ca5d80","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-05-28 13:32:56.000000000","message":"Patch Set 4:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/9c24e9c94b8346c58f7679ad2b53c79a : POST_FAILURE in 50m 38s","accounts_in_message":[],"_revision_number":4},{"id":"9cb4a8f979c13867978fec1574a21971f993d1f3","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-28 13:35:14.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/07888c60edc74cca8c5cdcefd4c5a516 : SUCCESS in 26m 45s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/36d971bd3f50480eae43506ef56a3f52 : SUCCESS in 46m 06s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"2ce6420371758b9baec185358c1df0e9912dc206","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-28 14:32:49.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/0159a447cb55479598129c4c7df0b868 : SUCCESS in 1h 16m 44s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/360e973b650f4018a7365e4c85783126 : SUCCESS in 18m 18s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6f3523b882b140ec9cb241655d2f8c61 : SUCCESS in 17m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1f527f5ceb094379a68ece55d3f09a43 : SUCCESS in 9m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4bbbd19715af43e8b00ccbea76d7add7 : SUCCESS in 15m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/19cd410a46394f99aff31b5300d5af95 : SUCCESS in 14m 22s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/59404a72cb314bafbf6072977003b012 : SUCCESS in 15m 13s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9d99b310fe4846a6b37ca31c9b84130e : SUCCESS in 13m 32s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/2d851ec1b41b4b5d85c5068ad2c422a8 : FAILURE in 1h 42m 42s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/56601b0902a04409a6b3a2405c06b420 : SUCCESS in 1h 15m 57s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/cf69f15713b341b892d4364c642441d7 : SUCCESS in 56m 39s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/9c077a6047ab4700bb203f0a2216f884 : SUCCESS in 53m 11s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/e1d843a422f04fdda977fe377c6a7499 : SUCCESS in 1h 48m 36s\n- nova-next https://zuul.opendev.org/t/openstack/build/c155bbebd6a94aa1b15f424402cf726f : SUCCESS in 1h 40m 11s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/e72ac4ea71de421d94cbd3e21a1c7e5c : SUCCESS in 18m 46s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/9de441e0d55541a08d042a5713024bc5 : SUCCESS in 19m 57s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/2584e75372d04d0984718a33236484c3 : SUCCESS in 1h 18m 19s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/52f8549f93d5483988de9afd9f1e8262 : SUCCESS in 1h 05m 35s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/9db630ec1bce4eda802abb2c399b4509 : SUCCESS in 51m 41s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/f9b7ccf2c41e40e09bdfc56f3db37854 : SUCCESS in 35m 25s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/a3cc182116f0474cb673715532544903 : SUCCESS in 40m 27s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"2db649163e82aeba1d02b95aba2792726e93c2b5","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-05-28 15:08:07.000000000","message":"Patch Set 4:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/791502/4/iscsi : SUCCESS in 2h 28m 57s","accounts_in_message":[],"_revision_number":4},{"id":"30f1c2453a8423c658826ced4242bb033cc26c26","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-06-04 08:45:56.000000000","message":"Patch Set 4: Workflow+1\n\nplugging back +A that was lost in a trivial rebase","accounts_in_message":[],"_revision_number":4},{"id":"7e54618cac4ca0ef9ad8a487f8a75e85e82f51ad","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-04 08:48:22.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"d82350c06a636b5a472a0abcb80b7ce48ff87adc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-04 10:19:33.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/bc8c32c0011749428d0bb3ccebf785c0 : SUCCESS in 1h 12m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/13107f4089824713aa517584cf85cfe5 : SUCCESS in 13m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a5f7f99711d14d5ab7339d8f7d29f942 : SUCCESS in 8m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b80c94f043f24f52b36e61fc0843ae68 : SUCCESS in 12m 14s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e7cafa5da6954c87beacba87f5dd5a7d : SUCCESS in 13m 26s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/74042e019df14fa19d22b9186f0fce1a : SUCCESS in 10m 43s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/80c96db12d614c07afdf41b4924a5fe9 : SUCCESS in 54m 57s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/c71219f00a3c4d3dbfcde0f1f9cf5a54 : SUCCESS in 56m 52s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/f527f0a013be454cba74477ec9a9f26f : SUCCESS in 19m 25s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/ceb9b6a8855448ccb3953105e3bfcf23 : SUCCESS in 1h 29m 42s\n- nova-next https://zuul.opendev.org/t/openstack/build/5c240f83c46c4c069ea73fa160a5707c : SUCCESS in 1h 27m 44s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/6338d0b1720846a78f2316615503f670 : SUCCESS in 1h 17m 27s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/56bd46f56eb94c7b910387a742958f50 : SUCCESS in 1h 10m 53s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/981ac03a0b094d799cecd81ae87c72ad : SUCCESS in 51m 24s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/eb4de91a4a5f4947b4568657613f8fa5 : SUCCESS in 48m 34s","accounts_in_message":[],"_revision_number":4},{"id":"ac25b4da708a0f7a922718b9544b4474ac30236c","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-04 10:19:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"89bf5697989625caa55a6b961bbed8917fc5e40c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-04 10:21:37.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/aa4fda6c30f2428a9c417f0e18dcbadf : SUCCESS in 1m 17s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"5c50a45a1e5b66e6ef97192bbaec6fdd54f9c2a4","revisions":{"8d1a6bb05c413efec7971d2318a64f6f559bbfbc":{"kind":"REWORK","_number":1,"created":"2021-05-14 15:10:46.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/02/791502/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/02/791502/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/791502/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/791502/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/791502/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/02/791502/1"}}},"commit":{"parents":[{"commit":"3e04d9f9bfb5d8d040ad41f44de5b87a3f6b7e1b","subject":"Merge \"vmware: Handle empty list attributes on vSphere objects\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3e04d9f9bfb5d8d040ad41f44de5b87a3f6b7e1b"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-05-14 13:29:47.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-05-14 14:25:58.000000000","tz":120},"subject":"Fix RequestLevelParams persistence handling in RequestSpec","message":"Fix RequestLevelParams persistence handling in RequestSpec\n\nThe request_level_params field of the RequestSpec are intentionally not\npersistent and at the same time it is declared as non nullable. The\ncurrent code handling the persistence of this field actually set the\nrequest_level_params field to None breaking the non nullable invariant\nof the field.\n\nSo far this is error is not triggered as the request_level_params field\nwas only used lazy loading, which is defaulted the field to a new\nRequestLevelParam object on the RequestSpec object that was never saved after\nsuch lazy load. A later patch will initialize request_level_params field\nin the RequestSpec.from_components() factory method to handle this\nparameters from Neutron ports and that triggers a failure when the\nRequestSpec is saved.\n\nThere are a set of non nullable, non persisted RequestSpec fields that\nare handled individually during create / save. This patch applies the\nsame logic to request_level_params as well.\n\nChange-Id: I7d11ef8abb30686f9d125cac0e48369eab839b0f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8d1a6bb05c413efec7971d2318a64f6f559bbfbc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8d1a6bb05c413efec7971d2318a64f6f559bbfbc"}]},"branch":"refs/heads/master"},"67c2d86b10aa87e6657e12641e05d0aae0ccff9c":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-05-14 15:44:26.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/02/791502/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/02/791502/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/791502/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/791502/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/791502/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/02/791502/2"}}},"commit":{"parents":[{"commit":"6b5fa144e40d6f1af9da959c546c7867fca2ebf1","subject":"Merge \"mypy: Add type annotations to \u0027nova.pci\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6b5fa144e40d6f1af9da959c546c7867fca2ebf1"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-05-14 13:29:47.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-05-14 15:36:57.000000000","tz":120},"subject":"Fix RequestLevelParams persistence handling in RequestSpec","message":"Fix RequestLevelParams persistence handling in RequestSpec\n\nThe request_level_params field of the RequestSpec are intentionally not\npersistent and at the same time it is declared as non nullable. The\ncurrent code handling the persistence of this field actually set the\nrequest_level_params field to None breaking the non nullable invariant\nof the field.\n\nSo far this is error is not triggered as the request_level_params field\nwas only used lazy loading, which is defaulted the field to a new\nRequestLevelParam object on the RequestSpec object that was never saved after\nsuch lazy load. A later patch will initialize request_level_params field\nin the RequestSpec.from_components() factory method to handle this\nparameters from Neutron ports and that triggers a failure when the\nRequestSpec is saved.\n\nThere are a set of non nullable, non persisted RequestSpec fields that\nare handled individually during create / save. This patch applies the\nsame logic to request_level_params as well.\n\nChange-Id: I7d11ef8abb30686f9d125cac0e48369eab839b0f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/67c2d86b10aa87e6657e12641e05d0aae0ccff9c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/67c2d86b10aa87e6657e12641e05d0aae0ccff9c"}]},"branch":"refs/heads/master"},"3d5602693787b3f33baa328fe6562df187399e0f":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-05-21 15:14:20.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/02/791502/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/02/791502/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/791502/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/791502/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/791502/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/02/791502/3"}}},"commit":{"parents":[{"commit":"771ea5bf1ea667d6ffe456ee6ef081b83a77f53c","subject":"Merge \"Add regression test for bug #1928063\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/771ea5bf1ea667d6ffe456ee6ef081b83a77f53c"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-05-14 13:29:47.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-05-21 14:50:59.000000000","tz":120},"subject":"Fix RequestLevelParams persistence handling in RequestSpec","message":"Fix RequestLevelParams persistence handling in RequestSpec\n\nThe request_level_params field of the RequestSpec are intentionally not\npersistent and at the same time it is declared as non nullable. The\ncurrent code handling the persistence of this field actually set the\nrequest_level_params field to None breaking the non nullable invariant\nof the field.\n\nSo far this is error is not triggered as the request_level_params field\nwas only used lazy loading, which is defaulted the field to a new\nRequestLevelParam object on the RequestSpec object that was never saved after\nsuch lazy load. A later patch will initialize request_level_params field\nin the RequestSpec.from_components() factory method to handle this\nparameters from Neutron ports and that triggers a failure when the\nRequestSpec is saved.\n\nThere are a set of non nullable, non persisted RequestSpec fields that\nare handled individually during create / save. This patch applies the\nsame logic to request_level_params as well.\n\nChange-Id: I7d11ef8abb30686f9d125cac0e48369eab839b0f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3d5602693787b3f33baa328fe6562df187399e0f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3d5602693787b3f33baa328fe6562df187399e0f"}]},"branch":"refs/heads/master"},"5c50a45a1e5b66e6ef97192bbaec6fdd54f9c2a4":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2021-05-28 12:37:51.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/02/791502/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/02/791502/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/791502/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/791502/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/791502/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/02/791502/4"}}},"commit":{"parents":[{"commit":"b0cd985f0c09088098f74cc0cb1df616cc0ef12b","subject":"Merge \"image_meta: Provide image_ref as the id when fetching from instance\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b0cd985f0c09088098f74cc0cb1df616cc0ef12b"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-05-14 13:29:47.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-05-28 12:26:56.000000000","tz":120},"subject":"Fix RequestLevelParams persistence handling in RequestSpec","message":"Fix RequestLevelParams persistence handling in RequestSpec\n\nThe request_level_params field of the RequestSpec are intentionally not\npersistent and at the same time it is declared as non nullable. The\ncurrent code handling the persistence of this field actually set the\nrequest_level_params field to None breaking the non nullable invariant\nof the field.\n\nSo far this is error is not triggered as the request_level_params field\nwas only used lazy loading, which is defaulted the field to a new\nRequestLevelParam object on the RequestSpec object that was never saved after\nsuch lazy load. A later patch will initialize request_level_params field\nin the RequestSpec.from_components() factory method to handle this\nparameters from Neutron ports and that triggers a failure when the\nRequestSpec is saved.\n\nThere are a set of non nullable, non persisted RequestSpec fields that\nare handled individually during create / save. This patch applies the\nsame logic to request_level_params as well.\n\nChange-Id: I7d11ef8abb30686f9d125cac0e48369eab839b0f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5c50a45a1e5b66e6ef97192bbaec6fdd54f9c2a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5c50a45a1e5b66e6ef97192bbaec6fdd54f9c2a4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}