)]}'
{"id":"openstack%2Fnova~791806","triplet_id":"openstack%2Fnova~stable%2Fussuri~Ie36401c782f023d1d5f2623732619105dc2cfa24","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1927677","hashtags":[],"change_id":"Ie36401c782f023d1d5f2623732619105dc2cfa24","subject":"Reject open redirection in the console proxy","status":"MERGED","created":"2021-05-17 17:09:35.000000000","updated":"2021-07-27 15:18:48.000000000","submitted":"2021-07-27 15:17:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"791806-bug/1927677","meta_rev_id":"60ef7ba50d2e31b56ade438b492089b76844d412","_number":791806,"virtual_id_number":791806,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-07-27 15:17:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2021-07-27 13:41:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2021-07-27 11:56:48.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":1,"date":"2021-07-27 13:41:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-17 18:51:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-17 19:10:41.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-05-17 20:08:49.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-06-17 05:17:44.000000000","updated_by":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"reviewer":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"state":"CC"},{"updated":"2021-07-27 11:56:48.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2021-07-27 13:41:10.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"df9552871af489a0b81be0c3fb9a1aed49530b61","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-05-17 17:09:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ccbbcd60a781620dc93947b6eade451befd23f4d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-17 18:51:45.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/1c55f3197b0548379d41956371cbe0f4 : FAILURE in 1h 01m 46s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4cee14d155bb43d2be5e00e1788f233d : SUCCESS in 22m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a20fb46ffcea49bdb203b06c2ccd8dbc : SUCCESS in 13m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f71f495c85e54df8965fdb7eb884e8c9 : FAILURE in 9m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d6e20fa3232f4214a5c58a80cf693fc6 : SUCCESS in 19m 23s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c8e576f7ee95427d9fe5d3e456738b05 : SUCCESS in 18m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e8221b0a47d24246b565a7b12adecae9 : SUCCESS in 11m 05s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5ed5ba5ea2324ca99aea15a498475bfb : SUCCESS in 19m 28s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/64703ca7c50e4150a43ff750b58373f2 : SUCCESS in 55m 18s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/d1ce562a7f154bdebd7d39dc18a439d8 : SUCCESS in 1h 03m 24s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/707261ab6ae2464b85acbdd1e483e0e1 : FAILURE in 1h 10m 34s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/1c9248b5b93e4b358fe6a263a3f0f030 : SUCCESS in 44m 40s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/09e7d84b04e747ed9adbc9c2ea4f45a4 : SUCCESS in 1h 10m 30s\n- nova-next https://zuul.opendev.org/t/openstack/build/a2c7929678f64c5b99a227d553cc09e9 : FAILURE in 1h 39m 35s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/ccb45e2e0b9c4480a8a7d891b316d1e2 : SUCCESS in 20m 06s\n- grenade https://zuul.opendev.org/t/openstack/build/fd65a983e0ae4c46a4524618d1c993ed : SUCCESS in 1h 01m 19s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2e3b72535bff41c3acb75fc0f5274d1c : SUCCESS in 47m 38s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/674b6ff29a2143bfb3a0abccbcdf4b69 : SUCCESS in 49m 34s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/ff9ccfce48a84246854e21f4f7651934 : FAILURE in 31m 52s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5955394269899f7e9a2c7645df9d7cda3066025a","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-05-17 19:10:41.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/06/791806/1/check/tempest-dsvm-full-bionic/7d3830b/ : SUCCESS in 1h 39m 49s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/06/791806/1/check/tempest-dsvm-full-bionic-py3/c9dd9ce/ : SUCCESS in 1h 52m 41s","accounts_in_message":[],"_revision_number":1},{"id":"9265dc2e5ee556fedb2705f24ff28ac93d69ab9b","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-05-17 20:08:49.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/791806/1/iscsi : SUCCESS in 2h 57m 53s","accounts_in_message":[],"_revision_number":1},{"id":"acf1a930e80dde44f628921c98e29860bbcc24ac","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2021-06-17 05:17:44.000000000","message":"Patch Set 1:\n\nI noticed this failed CI, I wonder if this is likely to be backported?","accounts_in_message":[],"_revision_number":1},{"id":"949e2b04ebd2cd084c645c84d56539429b949b15","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-26 19:26:59.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"a549232cc87597495c958e56905db7483f9b649e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-26 21:10:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/9dde47083a2d479a86c54e3bcf7945b6 : SUCCESS in 1h 28m 40s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fe7f23de136c48c088c774300edfffd2 : SUCCESS in 16m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ee4252f9c22e4d76ad830a0299be75d7 : SUCCESS in 15m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5ff1ccfd0301454498deb71d98e2eced : SUCCESS in 8m 52s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f9bfc472e91c44f19545f1dc45d35306 : SUCCESS in 13m 28s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/4d1037175c2b408e88565576f147488a : SUCCESS in 14m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c78ba2ac4e054e2c9278dfd377d5e350 : SUCCESS in 11m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a8db062d426748aab2e1f30614c0b31c : SUCCESS in 18m 42s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/fdfbd01c4d88401bae1c16ab791c8956 : SUCCESS in 1h 05m 56s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/a618c802296347f9801cdee64e4e35ba : SUCCESS in 1h 09m 06s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/15466f2c86704f049419285fd400931a : SUCCESS in 52m 44s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/4c5e56c32dbf402f981adf819b50d26d : SUCCESS in 1h 26m 39s\n- nova-next https://zuul.opendev.org/t/openstack/build/ef1bc4cf3dcd476690378fbad7631fae : SUCCESS in 1h 37m 08s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/ee2047f5c57844ef907e463bdfb687f7 : SUCCESS in 15m 56s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/7de7bcac489f47f69b3795b89ea6583d : SUCCESS in 1h 29m 05s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/13ef6a91bf144b719d27ac897bf7c612 : SUCCESS in 53m 28s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c323a07cef044c3984298e60101a0eae : SUCCESS in 57m 21s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/b22e863e23a34299932fdb2abe47b5f6 : SUCCESS in 30m 16s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"8541f60df041df00d231c7bb3584e7355a2bc040","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-07-26 21:59:16.000000000","message":"Patch Set 2:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/791806/2/iscsi : SUCCESS in 2h 31m 06s","accounts_in_message":[],"_revision_number":2},{"id":"c6ca71d082eaa3e7cdc44449cb9c015d9f83a5bc","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-07-27 11:56:48.000000000","message":"Patch Set 2: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"b3b12bcfb3a6a13f1948c37aff033b7a3735af18","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-07-27 13:41:10.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nClean cherry pick and merged in Victoria. LGTM.","accounts_in_message":[],"_revision_number":2},{"id":"adbbcb752919f7d71861e1323c03a8f5b11174e0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-27 13:41:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"2153616fa68aa13af66886ebe2bf9e2fe261b692","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-27 15:17:01.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/357a0cd554f548e898ed5d53f45f36f4 : SUCCESS in 1h 09m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/51f2e9408d924a29bf1014ec5bcbcf0d : SUCCESS in 15m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2d7d986fab2f4a08b890b5e786b5b2aa : SUCCESS in 9m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5873defbbf14468eb63f8e2027319cd7 : SUCCESS in 13m 10s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/d129583615b9467ea3858c5657e7420b : SUCCESS in 14m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fe03cb8ae84044a3a7488563f6da404d : SUCCESS in 11m 11s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/14767a64f6424f4faf1e438ade8dec19 : SUCCESS in 16m 07s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/17c0e381668544188540158d80b5712a : SUCCESS in 1h 02m 17s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/9b7e579eeaff4d6abd65af223c123405 : SUCCESS in 24m 41s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/b87757c27ec54f2783b7fbfb857ebbd4 : SUCCESS in 1h 31m 04s\n- nova-next https://zuul.opendev.org/t/openstack/build/011ca3d139d34600a21236ef7e06ea2d : SUCCESS in 1h 25m 58s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/e6c4b8a3280544259f33f66575425393 : SUCCESS in 1h 19m 08s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/0bd572ca85764c30982aae946c8353b0 : SUCCESS in 52m 03s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/27904c9cf73644728be542d2ead0c3c5 : SUCCESS in 47m 53s","accounts_in_message":[],"_revision_number":2},{"id":"0a03953120df33231cc1e8dc8dfd70ab29318d39","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-27 15:17:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"60ef7ba50d2e31b56ade438b492089b76844d412","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-27 15:18:48.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2fcd018149104e6b9975e9c857767c15 : SUCCESS in 1m 19s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b4990060dfbc431284da9426776f47ba : SUCCESS in 1m 15s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"719e651e6be277950632e0c2cf5cc9a018344e7b","revisions":{"1a8dd4e2e107f0ec19bd3b6646618af4f9bdf25b":{"kind":"REWORK","_number":1,"created":"2021-05-17 17:09:35.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/06/791806/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/06/791806/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/791806/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/791806/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/791806/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/06/791806/1"}}},"commit":{"parents":[{"commit":"ba6789e458f5da1e7b792866120128c609ca8537","subject":"Merge \"Update image_base_image_ref during rebuild.\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba6789e458f5da1e7b792866120128c609ca8537"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-05-13 05:43:42.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-05-17 17:08:52.000000000","tz":0},"subject":"Reject open redirection in the console proxy","message":"Reject open redirection in the console proxy\n\nOur console proxies (novnc, serial, spice) run in a websockify server\nwhose request handler inherits from the python standard\nSimpleHTTPRequestHandler. There is a known issue [1] in the\nSimpleHTTPRequestHandler which allows open redirects by way of URLs\nin the following format:\n\n  http://vncproxy.my.domain.com//example.com/%2F..\n\nwhich if visited, will redirect a user to example.com.\n\nWe can intercept a request and reject requests that pass a redirection\nURL beginning with \"//\" by implementing the\nSimpleHTTPRequestHandler.send_head() method containing the\nvulnerability to reject such requests with a 400 Bad Request.\n\nThis code is copied from a patch suggested in one of the issue comments\n[2].\n\nCloses-Bug: #1927677\n\n[1] https://bugs.python.org/issue32084\n[2] https://bugs.python.org/issue32084#msg306545\n\nChange-Id: Ie36401c782f023d1d5f2623732619105dc2cfa24\n(cherry picked from commit 781612b33282ed298f742c85dab58a075c8b793e)\n(cherry picked from commit 470925614223c8dd9b1233f54f5a96c02b2d4f70)\n(cherry picked from commit 6b70350bdcf59a9712f88b6435ba2c6500133e5b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1a8dd4e2e107f0ec19bd3b6646618af4f9bdf25b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1a8dd4e2e107f0ec19bd3b6646618af4f9bdf25b"}]},"branch":"refs/heads/stable/ussuri"},"719e651e6be277950632e0c2cf5cc9a018344e7b":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-07-26 19:26:59.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/06/791806/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/06/791806/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/791806/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/791806/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/791806/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/06/791806/2"}}},"commit":{"parents":[{"commit":"264429032152335855552dfcc9ea23e45b1b655d","subject":"Merge \"guestfs: With libguestfs \u003e\u003d v1.41.1 decode returned bytes to string\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/264429032152335855552dfcc9ea23e45b1b655d"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-05-13 05:43:42.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-07-26 19:26:59.000000000","tz":0},"subject":"Reject open redirection in the console proxy","message":"Reject open redirection in the console proxy\n\nOur console proxies (novnc, serial, spice) run in a websockify server\nwhose request handler inherits from the python standard\nSimpleHTTPRequestHandler. There is a known issue [1] in the\nSimpleHTTPRequestHandler which allows open redirects by way of URLs\nin the following format:\n\n  http://vncproxy.my.domain.com//example.com/%2F..\n\nwhich if visited, will redirect a user to example.com.\n\nWe can intercept a request and reject requests that pass a redirection\nURL beginning with \"//\" by implementing the\nSimpleHTTPRequestHandler.send_head() method containing the\nvulnerability to reject such requests with a 400 Bad Request.\n\nThis code is copied from a patch suggested in one of the issue comments\n[2].\n\nCloses-Bug: #1927677\n\n[1] https://bugs.python.org/issue32084\n[2] https://bugs.python.org/issue32084#msg306545\n\nChange-Id: Ie36401c782f023d1d5f2623732619105dc2cfa24\n(cherry picked from commit 781612b33282ed298f742c85dab58a075c8b793e)\n(cherry picked from commit 470925614223c8dd9b1233f54f5a96c02b2d4f70)\n(cherry picked from commit 6b70350bdcf59a9712f88b6435ba2c6500133e5b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/719e651e6be277950632e0c2cf5cc9a018344e7b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/719e651e6be277950632e0c2cf5cc9a018344e7b"}]},"branch":"refs/heads/stable/ussuri","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}