)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9e9ca9ad9ab5c26e03758ad3cfbaaa2a820d8e75","unresolved":false,"context_lines":[{"line_number":9,"context_line":"HPET is a harware timer for x86 arch. Also, qemu option \u0027-no-hpet\u0027"},{"line_number":10,"context_line":"is not supported on non x86 targets. This change does not add hpet"},{"line_number":11,"context_line":"in the guest\u0027s timer config when the arch is not x86_64 or i686."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1b81d1c5ed4f900ed87d1ecbbb97d4fdb22405fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAVn%2F%2FEYM%3D","line":12,"updated":"2014-03-10 08:16:45.000000000","message":"We are currently in a feature freeze. Can you please open a bug and reference the bug in the commit message. This certainly sounds like a bug and should be addressed in my opinion.","commit_id":"ae3bf75bf6bf2b3482d0e50116cb89e7bac2fbb9"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"6ca0f5d877b15ecec70756671d2188e046740464","unresolved":false,"context_lines":[{"line_number":9,"context_line":"HPET is a harware timer for x86 arch. Also, qemu option \u0027-no-hpet\u0027"},{"line_number":10,"context_line":"is not supported on non x86 targets. This change does not add hpet"},{"line_number":11,"context_line":"in the guest\u0027s timer config when the arch is not x86_64 or i686."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1b81d1c5ed4f900ed87d1ecbbb97d4fdb22405fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAVn%2F%2FCb4%3D","line":12,"in_reply_to":"AAAAVn%2F%2FEYM%3D","updated":"2014-03-10 15:35:00.000000000","message":"Oops! Sorry.\nhttps://bugs.launchpad.net/nova/+bug/1290362","commit_id":"ae3bf75bf6bf2b3482d0e50116cb89e7bac2fbb9"}],"nova/tests/virt/libvirt/test_libvirt.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9e9ca9ad9ab5c26e03758ad3cfbaaa2a820d8e75","unresolved":false,"context_lines":[{"line_number":880,"context_line":"                                            image_meta,"},{"line_number":881,"context_line":"                                            disk_info)"},{"line_number":882,"context_line":"            self._test_get_guest_config_clock(cfg)"},{"line_number":883,"context_line":"            self.assertEqual(len(cfg.clock.timers), 2)"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"    def test_get_guest_config_clock_x86(self):"},{"line_number":886,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027, group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FEZY%3D","line":883,"updated":"2014-03-10 08:16:45.000000000","message":"in general the first parameter should be the expected one and the second the received parameter.","commit_id":"ae3bf75bf6bf2b3482d0e50116cb89e7bac2fbb9"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"6ca0f5d877b15ecec70756671d2188e046740464","unresolved":false,"context_lines":[{"line_number":880,"context_line":"                                            image_meta,"},{"line_number":881,"context_line":"                                            disk_info)"},{"line_number":882,"context_line":"            self._test_get_guest_config_clock(cfg)"},{"line_number":883,"context_line":"            self.assertEqual(len(cfg.clock.timers), 2)"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"    def test_get_guest_config_clock_x86(self):"},{"line_number":886,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027, group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FCcg%3D","line":883,"in_reply_to":"AAAAVn%2F%2FEZY%3D","updated":"2014-03-10 15:35:00.000000000","message":"Right, I\u0027ll fix this only for the changed functions now. This file is not following the right order for assertEqual, they\u0027re all inverted. I\u0027ll address this in a separate patch.","commit_id":"ae3bf75bf6bf2b3482d0e50116cb89e7bac2fbb9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9e9ca9ad9ab5c26e03758ad3cfbaaa2a820d8e75","unresolved":false,"context_lines":[{"line_number":898,"context_line":"                                            image_meta,"},{"line_number":899,"context_line":"                                            disk_info)"},{"line_number":900,"context_line":"                self._test_get_guest_config_clock(cfg)"},{"line_number":901,"context_line":"                self.assertEqual(len(cfg.clock.timers), 3)"},{"line_number":902,"context_line":"                self.assertIsInstance(cfg.clock.timers[2],"},{"line_number":903,"context_line":"                                      vconfig.LibvirtConfigGuestTimer)"},{"line_number":904,"context_line":"                self.assertEqual(cfg.clock.timers[2].name, \u0027hpet\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FEZQ%3D","line":901,"updated":"2014-03-10 08:16:45.000000000","message":"ditto","commit_id":"ae3bf75bf6bf2b3482d0e50116cb89e7bac2fbb9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9e9ca9ad9ab5c26e03758ad3cfbaaa2a820d8e75","unresolved":false,"context_lines":[{"line_number":901,"context_line":"                self.assertEqual(len(cfg.clock.timers), 3)"},{"line_number":902,"context_line":"                self.assertIsInstance(cfg.clock.timers[2],"},{"line_number":903,"context_line":"                                      vconfig.LibvirtConfigGuestTimer)"},{"line_number":904,"context_line":"                self.assertEqual(cfg.clock.timers[2].name, \u0027hpet\u0027)"},{"line_number":905,"context_line":"                self.assertEqual(cfg.clock.timers[2].present, False)"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"    def test_get_guest_config_windows(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FEZM%3D","line":904,"updated":"2014-03-10 08:16:45.000000000","message":"ditto","commit_id":"ae3bf75bf6bf2b3482d0e50116cb89e7bac2fbb9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9e9ca9ad9ab5c26e03758ad3cfbaaa2a820d8e75","unresolved":false,"context_lines":[{"line_number":902,"context_line":"                self.assertIsInstance(cfg.clock.timers[2],"},{"line_number":903,"context_line":"                                      vconfig.LibvirtConfigGuestTimer)"},{"line_number":904,"context_line":"                self.assertEqual(cfg.clock.timers[2].name, \u0027hpet\u0027)"},{"line_number":905,"context_line":"                self.assertEqual(cfg.clock.timers[2].present, False)"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"    def test_get_guest_config_windows(self):"},{"line_number":908,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FEZI%3D","line":905,"updated":"2014-03-10 08:16:45.000000000","message":"Please use self.assertFalse(cfg.clock.timers[2].present)","commit_id":"ae3bf75bf6bf2b3482d0e50116cb89e7bac2fbb9"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f20720053b9b534542b58b28c3f9726095011bae","unresolved":false,"context_lines":[{"line_number":889,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":890,"context_line":"                                            instance_ref)"},{"line_number":891,"context_line":"        image_meta \u003d {}"},{"line_number":892,"context_line":"        archs \u003d (\u0027x86_64\u0027, \u0027i686\u0027)"},{"line_number":893,"context_line":"        for arch in archs:"},{"line_number":894,"context_line":"            with mock.patch.object(libvirt_driver.libvirt_utils,"},{"line_number":895,"context_line":"                                   \u0027get_arch\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FCVQ%3D","line":892,"updated":"2014-03-10 14:35:16.000000000","message":"Rather than having a separate test case with a bogus arch name, IMHO it would be better it we explicitly validated all architectures we care about. eg\n\n expecthpet \u003d (\n   \"x86_64\": True,\n   \"i686\": True,\n   \"ppc\": False,\n   \"ppc64\": False,\n   \"armv7\": False,\n   \"aarch64\": False,\n)\n\nand then iterate for each.","commit_id":"c89b1d8334d0f4987952978d014a6bae08fa25ad"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"69b4e2a916584112629e3ac744eb30e0fc3d43ca","unresolved":false,"context_lines":[{"line_number":889,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":890,"context_line":"                                            instance_ref)"},{"line_number":891,"context_line":"        image_meta \u003d {}"},{"line_number":892,"context_line":"        archs \u003d (\u0027x86_64\u0027, \u0027i686\u0027)"},{"line_number":893,"context_line":"        for arch in archs:"},{"line_number":894,"context_line":"            with mock.patch.object(libvirt_driver.libvirt_utils,"},{"line_number":895,"context_line":"                                   \u0027get_arch\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FB3s%3D","line":892,"in_reply_to":"AAAAVn%2F%2FCVQ%3D","updated":"2014-03-10 15:34:09.000000000","message":"Much better/cleaner solution, thanks Berrange.","commit_id":"c89b1d8334d0f4987952978d014a6bae08fa25ad"}]}