)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7af763c0b44108710c06e6c3155a5099ad41e404","unresolved":true,"context_lines":[{"line_number":5739,"context_line":"        self._create_sriov_networking_rp_tree(hostname, compute_rp_uuid)"},{"line_number":5740,"context_line":""},{"line_number":5741,"context_line":"    def assertPortMatchesAllocation(self, port, allocations, compute_rp_uuid):"},{"line_number":5742,"context_line":"        if port[\u0027binding:vnic_type\u0027] \u003d\u003d \u0027normal\u0027:"},{"line_number":5743,"context_line":"            bw_allocations \u003d allocations["},{"line_number":5744,"context_line":"                self.ovs_bridge_rp_per_host[compute_rp_uuid]][\u0027resources\u0027]"},{"line_number":5745,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"7436c4d3_aabff54b","line":5742,"updated":"2021-07-20 17:34:05.000000000","message":"Comments on this logic would be much appreciated. I assume it\u0027s because bandwidth allocations are associated with the OVS bridge on the compute node when OVS is used, while they\u0027re associated with one of the PFs on the compute node when SR-IOV is used, and we\u0027re using vnic_type as our heuristic for what type we\u0027re looking at","commit_id":"63c0277e2de9fbec5987ccb1a6984fe2e2d4edd3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"49a45990867e4c80992039326fada56d4f379f1d","unresolved":false,"context_lines":[{"line_number":5739,"context_line":"        self._create_sriov_networking_rp_tree(hostname, compute_rp_uuid)"},{"line_number":5740,"context_line":""},{"line_number":5741,"context_line":"    def assertPortMatchesAllocation(self, port, allocations, compute_rp_uuid):"},{"line_number":5742,"context_line":"        if port[\u0027binding:vnic_type\u0027] \u003d\u003d \u0027normal\u0027:"},{"line_number":5743,"context_line":"            bw_allocations \u003d allocations["},{"line_number":5744,"context_line":"                self.ovs_bridge_rp_per_host[compute_rp_uuid]][\u0027resources\u0027]"},{"line_number":5745,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"bcfea5c7_ae61eb13","line":5742,"in_reply_to":"7436c4d3_aabff54b","updated":"2021-07-22 13:20:54.000000000","message":"Yepp. Added a comment explaining this.","commit_id":"63c0277e2de9fbec5987ccb1a6984fe2e2d4edd3"}]}