)]}'
{"id":"openstack%2Fnova~793357","triplet_id":"openstack%2Fnova~stable%2Fvictoria~I55d66c3a6cbd50da90065f4a58f77b5cd29ce9ea","project":"openstack/nova","branch":"stable/victoria","topic":"bug/1928063","attention_set":{},"removed_from_attention_set":{"10135":{"account":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"last_update":"2024-03-05 18:59:52.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I55d66c3a6cbd50da90065f4a58f77b5cd29ce9ea","subject":"image_meta: Provide image_ref as the id when fetching from instance","status":"ABANDONED","created":"2021-05-27 10:02:39.000000000","updated":"2024-03-05 18:59:52.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dcc67d29a29567791b9a28bd7d36296762b296f4","_number":793357,"virtual_id_number":793357,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-05-27 11:40:07.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-27 11:40:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-27 11:54:11.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-05-27 12:53:18.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2024-03-05 18:59:52.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"dbe47d7e45f4c5c8b1d8fe914567653af386f3c4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-05-27 10:02:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9532994597f43578132174ad5684ff5614ab24b7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-27 11:40:07.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/697bb540fb78413aba5212324c00bee7 : SUCCESS in 1h 28m 47s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9e907a10da8e4db2b6a197f6e279ddad : SUCCESS in 15m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4b64a106cbf8449d98c16d0875ed96a1 : SUCCESS in 26m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7ba5616e5fce43799c848d13053a18a1 : FAILURE in 8m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/36203f9e143f4d98894c987d37b806d7 : SUCCESS in 13m 14s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7ac0f3c7559a4364a1dda65864d61d74 : SUCCESS in 13m 48s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/637e8fbf2a8f4c5db9aa8823be289c74 : SUCCESS in 9m 54s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/025f252975764154b952d5c3c6dd75ce : SUCCESS in 1h 24m 41s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/e746817444b14d1da1b9ddf1a3c227ee : SUCCESS in 1h 11m 59s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/283c6b8e54e64d57aec1480782a299a3 : FAILURE in 1h 15m 05s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/d42bf5014f164714865ac840dad96691 : SUCCESS in 49m 20s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/1ebafdac40474fea8622421c8d6678a1 : SUCCESS in 1h 22m 10s\n- nova-next https://zuul.opendev.org/t/openstack/build/54ae7ad2b40a453895196b202a23d4ea : FAILURE in 1h 35m 59s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/c630a9b11ab24d239e42479ed806708c : FAILURE in 17m 43s\n- grenade https://zuul.opendev.org/t/openstack/build/3909d2f4f32b41609acd5909b0a50c6e : SUCCESS in 1h 06m 33s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/5d6f029124e9460fb9026eeb89a4151b : SUCCESS in 1h 01m 41s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/a1c0a65859f84d159b853c92f6d63b89 : SUCCESS in 50m 38s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/beb7275f13c34c49a952320e546e2a36 : SUCCESS in 27m 57s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/ed44e9d32e1348d1bf6e8211b66781c2 : SUCCESS in 47m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"dac31650f70dee5992136380e42909ae52d65159","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-05-27 11:54:11.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/013db9382c924ca0b275288ddece5bf5 : POST_FAILURE in 1h 39m 51s","accounts_in_message":[],"_revision_number":1},{"id":"6c3dcdd45c9c9da5219599313d8b672165d1c84d","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-05-27 12:53:18.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/793357/1/iscsi : SUCCESS in 2h 47m 19s","accounts_in_message":[],"_revision_number":1},{"id":"dcc67d29a29567791b9a28bd7d36296762b296f4","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-03-05 18:59:52.000000000","message":"Abandoned\n\nstable/victoria branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bc579db23a259dd0061fbba3f56655eea2b798e7","revisions":{"bc579db23a259dd0061fbba3f56655eea2b798e7":{"kind":"REWORK","_number":1,"created":"2021-05-27 10:02:39.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/57/793357/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/57/793357/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/57/793357/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/57/793357/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/57/793357/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/57/793357/1"}}},"commit":{"parents":[{"commit":"9c0acadffdf5dba40f3b9070a67fa30fedf18d23","subject":"libvirt: make cross cell resize spawn from snapshot image","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9c0acadffdf5dba40f3b9070a67fa30fedf18d23"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-05-12 12:11:50.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-05-27 10:01:25.000000000","tz":60},"subject":"image_meta: Provide image_ref as the id when fetching from instance","message":"image_meta: Provide image_ref as the id when fetching from instance\n\nAt present various users of instance.image_meta expect it to be a fully\npopulated ImageMeta object. However when the instance is pulled from the\ndatabase the ImageMeta object is only partially populated via\ninstance.system_metadata with a limited set of attributes such as\nmin_ram, min_disk, disk_format and container_format. This can result in\nNotImplementedErrors being raised by o.vo as seen in bug #1928063 when\nan attempt is made to access common attributes such as id or name.\n\nTo avoid this the id is now provided by instance.image_ref when\navailable.\n\nThe majority of the change is test fallout and ensuring that valid UUIDs\nare provided as instance.image_ref and used by instance.image_meta.\n\nNOTE(lyarwood): Conflict as Idc035671892e4668141a93763f8f2bed7a630812\nis not present in stable/victoria.\n\nConflicts:\n  nova/tests/unit/virt/libvirt/test_machine_type_utils.py\n\nRelated-Bug: #1928063\nChange-Id: I55d66c3a6cbd50da90065f4a58f77b5cd29ce9ea\n(cherry picked from commit 9d037f7d199443da0f2c6c1755704e589d52e730)\n(cherry picked from commit a2791fb5d2ae30d2861c2f04627eb48df01a30e7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bc579db23a259dd0061fbba3f56655eea2b798e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bc579db23a259dd0061fbba3f56655eea2b798e7"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
