)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"483cf85270aba12973e91a565f395490dcb8b2a0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: Do not destroy volume secrets during _hard_reboot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ia2007bc63ef09931ea0197cef29d6a5614ed821a unfortunately missed that"},{"line_number":10,"context_line":"resume_state_on_host_boot calls down into _hard_reboot always removing"},{"line_number":11,"context_line":"volume secrets rendering that change useless."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f78609dd_532b8b8a","line":9,"range":{"start_line":9,"start_character":41,"end_line":9,"end_character":42},"updated":"2021-06-08 11:05:33.000000000","message":"(\"libvirt: Skip encryption metadata lookups if secret already exists on host\")","commit_id":"26d65fc882e42b824409dff87ff026dee1debe20"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b66f93eb6812e47f6603d551e943bc04b82ef3ed","unresolved":true,"context_lines":[{"line_number":9061,"context_line":"            destroy_secrets\u003dFalse"},{"line_number":9062,"context_line":"        )"},{"line_number":9063,"context_line":"        drvr._host.delete_secret.assert_not_called()"},{"line_number":9064,"context_line":""},{"line_number":9065,"context_line":"        # assert that the encryptor is used if no secret is found"},{"line_number":9066,"context_line":"        drvr._host.find_secret.reset_mock()"},{"line_number":9067,"context_line":"        drvr._host.delete_secret.reset_mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9cdc9284_6e64db4a","line":9064,"updated":"2021-06-03 10:34:57.000000000","message":"this is really asserting the behaviour of _disconnect_volume in general its not realted to luks specifcally.\n\nso instead of extending this you could alos consider jut having this be a seperate test case.","commit_id":"c83e69a7722b54000c6040a251d5d58262fcc5c3"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3e28132c6caf9f79e749cd765075603c6b39b3e4","unresolved":true,"context_lines":[{"line_number":9061,"context_line":"            destroy_secrets\u003dFalse"},{"line_number":9062,"context_line":"        )"},{"line_number":9063,"context_line":"        drvr._host.delete_secret.assert_not_called()"},{"line_number":9064,"context_line":""},{"line_number":9065,"context_line":"        # assert that the encryptor is used if no secret is found"},{"line_number":9066,"context_line":"        drvr._host.find_secret.reset_mock()"},{"line_number":9067,"context_line":"        drvr._host.delete_secret.reset_mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"88135cf0_3f61e8fe","line":9064,"in_reply_to":"9cdc9284_6e64db4a","updated":"2021-06-04 10:39:31.000000000","message":"Yeah I was just extending a test that was already here, happy to drop it tbh.","commit_id":"c83e69a7722b54000c6040a251d5d58262fcc5c3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b66f93eb6812e47f6603d551e943bc04b82ef3ed","unresolved":true,"context_lines":[{"line_number":10154,"context_line":"        )"},{"line_number":10155,"context_line":"        # Assert that volume secert is deleted"},{"line_number":10156,"context_line":"        mock_delete_secret.assert_called_once_with(\u0027volume\u0027, uuids.volume_id)"},{"line_number":10157,"context_line":""},{"line_number":10158,"context_line":"    def test_allow_native_luksv1(self):"},{"line_number":10159,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":10160,"context_line":"        self.assertFalse(drvr._allow_native_luksv1({}))"}],"source_content_type":"text/x-python","patch_set":4,"id":"201de753_b3acacad","line":10157,"updated":"2021-06-03 10:34:57.000000000","message":"+1","commit_id":"c83e69a7722b54000c6040a251d5d58262fcc5c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"483cf85270aba12973e91a565f395490dcb8b2a0","unresolved":true,"context_lines":[{"line_number":10152,"context_line":"            None,"},{"line_number":10153,"context_line":"            destroy_secrets\u003dTrue"},{"line_number":10154,"context_line":"        )"},{"line_number":10155,"context_line":"        # Assert that volume secert is deleted"},{"line_number":10156,"context_line":"        mock_delete_secret.assert_called_once_with(\u0027volume\u0027, uuids.volume_id)"},{"line_number":10157,"context_line":""},{"line_number":10158,"context_line":"    def test_allow_native_luksv1(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"81e485ad_e817fe95","line":10155,"range":{"start_line":10155,"start_character":29,"end_line":10155,"end_character":35},"updated":"2021-06-08 11:05:33.000000000","message":"secret","commit_id":"26d65fc882e42b824409dff87ff026dee1debe20"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b66f93eb6812e47f6603d551e943bc04b82ef3ed","unresolved":true,"context_lines":[{"line_number":3738,"context_line":"        # With this goal in mind, we tear down all the aspects of an instance"},{"line_number":3739,"context_line":"        # we can here without losing data. This allows us to re-initialise from"},{"line_number":3740,"context_line":"        # scratch, and hopefully fix, most aspects of a non-functioning guest."},{"line_number":3741,"context_line":"        self.destroy(context, instance, network_info, destroy_disks\u003dFalse,"},{"line_number":3742,"context_line":"                     block_device_info\u003dblock_device_info,"},{"line_number":3743,"context_line":"                     destroy_secrets\u003dFalse)"},{"line_number":3744,"context_line":""},{"line_number":3745,"context_line":"        # Convert the system metadata to image metadata"},{"line_number":3746,"context_line":"        # NOTE(mdbooth): This is a workaround for stateless Nova compute"}],"source_content_type":"text/x-python","patch_set":4,"id":"6a1e8ff4_080f1760","line":3743,"range":{"start_line":3741,"start_character":8,"end_line":3743,"end_character":43},"updated":"2021-06-03 10:34:57.000000000","message":"im not seeing a testcase that asserts hard reboot calls destory with destroy_secrets\u003dFalse","commit_id":"c83e69a7722b54000c6040a251d5d58262fcc5c3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"822d65fa22c5c3671a29284ce137d593776ebb6a","unresolved":true,"context_lines":[{"line_number":3738,"context_line":"        # With this goal in mind, we tear down all the aspects of an instance"},{"line_number":3739,"context_line":"        # we can here without losing data. This allows us to re-initialise from"},{"line_number":3740,"context_line":"        # scratch, and hopefully fix, most aspects of a non-functioning guest."},{"line_number":3741,"context_line":"        self.destroy(context, instance, network_info, destroy_disks\u003dFalse,"},{"line_number":3742,"context_line":"                     block_device_info\u003dblock_device_info,"},{"line_number":3743,"context_line":"                     destroy_secrets\u003dFalse)"},{"line_number":3744,"context_line":""},{"line_number":3745,"context_line":"        # Convert the system metadata to image metadata"},{"line_number":3746,"context_line":"        # NOTE(mdbooth): This is a workaround for stateless Nova compute"}],"source_content_type":"text/x-python","patch_set":4,"id":"7fe8bb4d_dbd243f4","line":3743,"range":{"start_line":3741,"start_character":8,"end_line":3743,"end_character":43},"in_reply_to":"6a1e8ff4_080f1760","updated":"2021-06-08 14:51:21.000000000","message":"unless im missing it we still dont have a testcase that mock destory\n\nand does\ndriver.hard_reboot then asset driver.destroy is called with destroy_secrets\u003dFalse\n\nso as it stand i coudl  add a ptach that set destroy_secrets\u003dFalse to destroy_secrets\u003dTrue here and there would not be a unit test to detect that.","commit_id":"c83e69a7722b54000c6040a251d5d58262fcc5c3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0e077dd2b516bde14894d5eb1ce8b073706c7225","unresolved":true,"context_lines":[{"line_number":3738,"context_line":"        # With this goal in mind, we tear down all the aspects of an instance"},{"line_number":3739,"context_line":"        # we can here without losing data. This allows us to re-initialise from"},{"line_number":3740,"context_line":"        # scratch, and hopefully fix, most aspects of a non-functioning guest."},{"line_number":3741,"context_line":"        self.destroy(context, instance, network_info, destroy_disks\u003dFalse,"},{"line_number":3742,"context_line":"                     block_device_info\u003dblock_device_info,"},{"line_number":3743,"context_line":"                     destroy_secrets\u003dFalse)"},{"line_number":3744,"context_line":""},{"line_number":3745,"context_line":"        # Convert the system metadata to image metadata"},{"line_number":3746,"context_line":"        # NOTE(mdbooth): This is a workaround for stateless Nova compute"}],"source_content_type":"text/x-python","patch_set":4,"id":"93884a47_bda25250","line":3743,"range":{"start_line":3741,"start_character":8,"end_line":3743,"end_character":43},"in_reply_to":"7fe8bb4d_dbd243f4","updated":"2021-06-08 15:01:52.000000000","message":"oh this is caught by nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_hard_reboot","commit_id":"c83e69a7722b54000c6040a251d5d58262fcc5c3"}]}