)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"a22a18e6fabd9791ea62b155ab9552464e84e830","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Reject server create with extended resource req"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To prepare for the unlikely event that Neutron merges and an operator"},{"line_number":10,"context_line":"enables the port-resource-request-groups neutron API extension before"},{"line_number":11,"context_line":"nova adds support for it, this patch rejects server creation if such"},{"line_number":12,"context_line":"extension is enabled in Neutron. Enabling that extension has zero"},{"line_number":13,"context_line":"benefits without nova support hence the harsh but simple rejection."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"96cd85b2_d185dc73","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":40},"updated":"2021-08-26 09:25:33.000000000","message":"I99a49b107b1872ddf83d1d8497a26a8d728feb07 specifically right?","commit_id":"e357ad3c2354f1c22cd5b569a2f0ec23c9c06753"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a2916b6a95c6f4061429e9fb2898ed738dfc3427","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Reject server create with extended resource req"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To prepare for the unlikely event that Neutron merges and an operator"},{"line_number":10,"context_line":"enables the port-resource-request-groups neutron API extension before"},{"line_number":11,"context_line":"nova adds support for it, this patch rejects server creation if such"},{"line_number":12,"context_line":"extension is enabled in Neutron. Enabling that extension has zero"},{"line_number":13,"context_line":"benefits without nova support hence the harsh but simple rejection."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"1d9446b2_b9381a4b","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":40},"in_reply_to":"96cd85b2_d185dc73","updated":"2021-08-27 09:46:27.000000000","message":"Yes, that is the patch that implement the extension. However neutron already landed the patch that defines the extension [1] so we can depend on the name of the extension already in this and subsequent patches to detect the new extension. \n\nAfter we land both rejection patches (this and the next one) we are safe from nova perspective as we handled the new extension. Then this patch series gradually enables the use of that extension from nova perspective as implementation is added. \n\nIf neutron does not have this extension (not merged or merged but disable by config) then nova automatically falls back supporting the old extension (port-resource-request) so we are not breaking the legacy scenarios.\n\n[1] https://review.opendev.org/c/openstack/neutron-lib/+/803905","commit_id":"e357ad3c2354f1c22cd5b569a2f0ec23c9c06753"}],"api-guide/source/port_with_resource_request.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":42,"context_line":"Extended resource request"},{"line_number":43,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Since 19.0.0 (Xena), Neutron implements an extended resource request format"},{"line_number":46,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":47,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":48,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"}],"source_content_type":"text/x-rst","patch_set":11,"id":"d6929828_c81da9bb","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":20},"updated":"2021-07-20 17:16:28.000000000","message":"Okay, this is confusing: you\u0027re talking about _neutron_ versions. Could we say:\n\n  Since neutron 19.0.0 (Xena), neutron implements...","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Extended resource request"},{"line_number":43,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Since 19.0.0 (Xena), Neutron implements an extended resource request format"},{"line_number":46,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":47,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":48,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"}],"source_content_type":"text/x-rst","patch_set":11,"id":"6e1946b5_f6b438f8","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":20},"in_reply_to":"d6929828_c81da9bb","updated":"2021-07-22 13:20:20.000000000","message":"Done","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":43,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Since 19.0.0 (Xena), Neutron implements an extended resource request format"},{"line_number":46,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":47,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":48,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"},{"line_number":49,"context_line":"as interface attach operation. So it is suggested not to enable this API"}],"source_content_type":"text/x-rst","patch_set":11,"id":"c5c02857_af34bfa6","line":46,"range":{"start_line":46,"start_character":70,"end_line":46,"end_character":71},"updated":"2021-07-20 17:16:28.000000000","message":"nova","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Since 19.0.0 (Xena), Neutron implements an extended resource request format"},{"line_number":46,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":47,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":48,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"},{"line_number":49,"context_line":"as interface attach operation. So it is suggested not to enable this API"}],"source_content_type":"text/x-rst","patch_set":11,"id":"49659aaa_2a3b5ba2","line":46,"range":{"start_line":46,"start_character":70,"end_line":46,"end_character":71},"in_reply_to":"c5c02857_af34bfa6","updated":"2021-07-22 13:20:20.000000000","message":"Done","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Since 19.0.0 (Xena), Neutron implements an extended resource request format"},{"line_number":46,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":47,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":48,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"},{"line_number":49,"context_line":"as interface attach operation. So it is suggested not to enable this API"},{"line_number":50,"context_line":"extension in Neutron."}],"source_content_type":"text/x-rst","patch_set":11,"id":"c3763eaa_daaefa22","line":47,"range":{"start_line":47,"start_character":69,"end_line":47,"end_character":75},"updated":"2021-07-20 17:16:28.000000000","message":"enabled","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Since 19.0.0 (Xena), Neutron implements an extended resource request format"},{"line_number":46,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":47,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":48,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"},{"line_number":49,"context_line":"as interface attach operation. So it is suggested not to enable this API"},{"line_number":50,"context_line":"extension in Neutron."}],"source_content_type":"text/x-rst","patch_set":11,"id":"066e8835_9a6c9cd7","line":47,"range":{"start_line":47,"start_character":69,"end_line":47,"end_character":75},"in_reply_to":"c3763eaa_daaefa22","updated":"2021-07-22 13:20:20.000000000","message":"Done","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":45,"context_line":"Since 19.0.0 (Xena), Neutron implements an extended resource request format"},{"line_number":46,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":47,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":48,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"},{"line_number":49,"context_line":"as interface attach operation. So it is suggested not to enable this API"},{"line_number":50,"context_line":"extension in Neutron."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"4efddc68_9ead33aa","line":48,"range":{"start_line":48,"start_character":47,"end_line":48,"end_character":48},"updated":"2021-07-20 17:16:28.000000000","message":"nit: drop","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"Since 19.0.0 (Xena), Neutron implements an extended resource request format"},{"line_number":46,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":47,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":48,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"},{"line_number":49,"context_line":"as interface attach operation. So it is suggested not to enable this API"},{"line_number":50,"context_line":"extension in Neutron."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"8acaef5e_903e5313","line":48,"range":{"start_line":48,"start_character":47,"end_line":48,"end_character":48},"in_reply_to":"4efddc68_9ead33aa","updated":"2021-07-22 13:20:20.000000000","message":"Done","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":46,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":47,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":48,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"},{"line_number":49,"context_line":"as interface attach operation. So it is suggested not to enable this API"},{"line_number":50,"context_line":"extension in Neutron."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"See :nova-doc:`the admin guide \u003cadmin/port_with_resource_request.html\u003e` for"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9b8f4ae9_12037740","line":49,"range":{"start_line":49,"start_character":31,"end_line":49,"end_character":57},"updated":"2021-07-20 17:16:28.000000000","message":"Admins should not\n\n(we should be authoritative here)","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":46,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":47,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":48,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"},{"line_number":49,"context_line":"as interface attach operation. So it is suggested not to enable this API"},{"line_number":50,"context_line":"extension in Neutron."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"See :nova-doc:`the admin guide \u003cadmin/port_with_resource_request.html\u003e` for"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5affa7a3_79e1998e","line":49,"range":{"start_line":49,"start_character":31,"end_line":49,"end_character":57},"in_reply_to":"9b8f4ae9_12037740","updated":"2021-07-22 13:20:20.000000000","message":"thanks. Done.","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"}],"doc/source/admin/ports-with-resource-requests.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":64,"context_line":"then the PCI claim will fail on the host and re-schedule will be triggered. It"},{"line_number":65,"context_line":"is suggested not to configure bandwidth inventory in the neutron agents on"},{"line_number":66,"context_line":"these compute hosts to avoid unnecessary reschedule."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Extended resource request"},{"line_number":69,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"f2a49101_4875cc6b","line":67,"updated":"2021-07-20 17:16:28.000000000","message":"Missing newline (since you\u0027re sensibly doing that)","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":64,"context_line":"then the PCI claim will fail on the host and re-schedule will be triggered. It"},{"line_number":65,"context_line":"is suggested not to configure bandwidth inventory in the neutron agents on"},{"line_number":66,"context_line":"these compute hosts to avoid unnecessary reschedule."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Extended resource request"},{"line_number":69,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9f49b590_ec9b44d1","line":67,"in_reply_to":"f2a49101_4875cc6b","updated":"2021-07-22 13:20:20.000000000","message":"Done","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":68,"context_line":"Extended resource request"},{"line_number":69,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Since 19.0.0 (Xena), Neutron implements an extended resource request format"},{"line_number":72,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":73,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":74,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ae486d3e_431fc329","line":71,"range":{"start_line":71,"start_character":5,"end_line":71,"end_character":6},"updated":"2021-07-20 17:16:28.000000000","message":"neutron","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Extended resource request"},{"line_number":69,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Since 19.0.0 (Xena), Neutron implements an extended resource request format"},{"line_number":72,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":73,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":74,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fca88c80_a347b795","line":71,"range":{"start_line":71,"start_character":5,"end_line":71,"end_character":6},"in_reply_to":"ae486d3e_431fc329","updated":"2021-07-22 13:20:20.000000000","message":"Done","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":72,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":73,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":74,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"},{"line_number":75,"context_line":"as interface attach operation. So it is suggested not to enable this API"},{"line_number":76,"context_line":"extension in Neutron."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The extended resource request allows that a single Neutron port requests"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5b8b0dc9_738d5177","line":75,"range":{"start_line":75,"start_character":31,"end_line":75,"end_character":56},"updated":"2021-07-20 17:16:28.000000000","message":"Admins should not","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"via the the ``extended_resource_request`` Neutron API extension. As of 24.0.0"},{"line_number":73,"context_line":"(Xena), Nova does not support the new extension. If the extension is enable"},{"line_number":74,"context_line":"in Neutron, then Nova will reject server create, and move operations, as well"},{"line_number":75,"context_line":"as interface attach operation. So it is suggested not to enable this API"},{"line_number":76,"context_line":"extension in Neutron."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The extended resource request allows that a single Neutron port requests"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9b903b58_11387d32","line":75,"range":{"start_line":75,"start_character":31,"end_line":75,"end_character":56},"in_reply_to":"5b8b0dc9_738d5177","updated":"2021-07-22 13:20:20.000000000","message":"Done","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":75,"context_line":"as interface attach operation. So it is suggested not to enable this API"},{"line_number":76,"context_line":"extension in Neutron."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The extended resource request allows that a single Neutron port requests"},{"line_number":79,"context_line":"resources in more than one request groups. This also means that using just one"},{"line_number":80,"context_line":"port in a server create request already require a group policy to be provided"},{"line_number":81,"context_line":"in the flavor. Today the only case when a single port generates more than one"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9cc2de98_9c4a87bf","line":78,"range":{"start_line":78,"start_character":30,"end_line":78,"end_character":72},"updated":"2021-07-20 17:16:28.000000000","message":"allows a single Neutron port to request","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"as interface attach operation. So it is suggested not to enable this API"},{"line_number":76,"context_line":"extension in Neutron."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The extended resource request allows that a single Neutron port requests"},{"line_number":79,"context_line":"resources in more than one request groups. This also means that using just one"},{"line_number":80,"context_line":"port in a server create request already require a group policy to be provided"},{"line_number":81,"context_line":"in the flavor. Today the only case when a single port generates more than one"}],"source_content_type":"text/x-rst","patch_set":11,"id":"825a3636_3db15fcc","line":78,"range":{"start_line":78,"start_character":30,"end_line":78,"end_character":72},"in_reply_to":"9cc2de98_9c4a87bf","updated":"2021-07-22 13:20:20.000000000","message":"Done","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The extended resource request allows that a single Neutron port requests"},{"line_number":79,"context_line":"resources in more than one request groups. This also means that using just one"},{"line_number":80,"context_line":"port in a server create request already require a group policy to be provided"},{"line_number":81,"context_line":"in the flavor. Today the only case when a single port generates more than one"},{"line_number":82,"context_line":"request groups is when that port has QoS policy with both minimum bandwidth"},{"line_number":83,"context_line":"and minimum packet rate rules. Due to the placement resource modell of these"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7311ff5b_4ea8903a","line":80,"range":{"start_line":80,"start_character":32,"end_line":80,"end_character":39},"updated":"2021-07-20 17:16:28.000000000","message":"would","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The extended resource request allows that a single Neutron port requests"},{"line_number":79,"context_line":"resources in more than one request groups. This also means that using just one"},{"line_number":80,"context_line":"port in a server create request already require a group policy to be provided"},{"line_number":81,"context_line":"in the flavor. Today the only case when a single port generates more than one"},{"line_number":82,"context_line":"request groups is when that port has QoS policy with both minimum bandwidth"},{"line_number":83,"context_line":"and minimum packet rate rules. Due to the placement resource modell of these"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7393f3b6_2be791b3","line":80,"range":{"start_line":80,"start_character":32,"end_line":80,"end_character":39},"in_reply_to":"7311ff5b_4ea8903a","updated":"2021-07-22 13:20:20.000000000","message":"Done","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":80,"context_line":"port in a server create request already require a group policy to be provided"},{"line_number":81,"context_line":"in the flavor. Today the only case when a single port generates more than one"},{"line_number":82,"context_line":"request groups is when that port has QoS policy with both minimum bandwidth"},{"line_number":83,"context_line":"and minimum packet rate rules. Due to the placement resource modell of these"},{"line_number":84,"context_line":"features in this case the two request groups will always be fulfilled from"},{"line_number":85,"context_line":"separate resource providers and therefore neither the ``group_policy\u003dnone``"},{"line_number":86,"context_line":"and the ``group_policy\u003disolate`` flavor extra specs results in any additional"}],"source_content_type":"text/x-rst","patch_set":11,"id":"35eca4f6_04778daf","line":83,"range":{"start_line":83,"start_character":61,"end_line":83,"end_character":67},"updated":"2021-07-20 17:16:28.000000000","message":"model","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":80,"context_line":"port in a server create request already require a group policy to be provided"},{"line_number":81,"context_line":"in the flavor. Today the only case when a single port generates more than one"},{"line_number":82,"context_line":"request groups is when that port has QoS policy with both minimum bandwidth"},{"line_number":83,"context_line":"and minimum packet rate rules. Due to the placement resource modell of these"},{"line_number":84,"context_line":"features in this case the two request groups will always be fulfilled from"},{"line_number":85,"context_line":"separate resource providers and therefore neither the ``group_policy\u003dnone``"},{"line_number":86,"context_line":"and the ``group_policy\u003disolate`` flavor extra specs results in any additional"}],"source_content_type":"text/x-rst","patch_set":11,"id":"e0336561_6a34dc64","line":83,"range":{"start_line":83,"start_character":61,"end_line":83,"end_character":67},"in_reply_to":"35eca4f6_04778daf","updated":"2021-07-22 13:20:20.000000000","message":"Done","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":83,"context_line":"and minimum packet rate rules. Due to the placement resource modell of these"},{"line_number":84,"context_line":"features in this case the two request groups will always be fulfilled from"},{"line_number":85,"context_line":"separate resource providers and therefore neither the ``group_policy\u003dnone``"},{"line_number":86,"context_line":"and the ``group_policy\u003disolate`` flavor extra specs results in any additional"},{"line_number":87,"context_line":"restriction on the placement of the resources. In the multi port case the"},{"line_number":88,"context_line":"Resource Group policy section above still applies."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"4cca760a_a28604b8","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":3},"updated":"2021-07-20 17:16:28.000000000","message":"nor","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":83,"context_line":"and minimum packet rate rules. Due to the placement resource modell of these"},{"line_number":84,"context_line":"features in this case the two request groups will always be fulfilled from"},{"line_number":85,"context_line":"separate resource providers and therefore neither the ``group_policy\u003dnone``"},{"line_number":86,"context_line":"and the ``group_policy\u003disolate`` flavor extra specs results in any additional"},{"line_number":87,"context_line":"restriction on the placement of the resources. In the multi port case the"},{"line_number":88,"context_line":"Resource Group policy section above still applies."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"635b9b1a_b300bc3e","line":86,"range":{"start_line":86,"start_character":52,"end_line":86,"end_character":59},"updated":"2021-07-20 17:16:28.000000000","message":"will result","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":83,"context_line":"and minimum packet rate rules. Due to the placement resource modell of these"},{"line_number":84,"context_line":"features in this case the two request groups will always be fulfilled from"},{"line_number":85,"context_line":"separate resource providers and therefore neither the ``group_policy\u003dnone``"},{"line_number":86,"context_line":"and the ``group_policy\u003disolate`` flavor extra specs results in any additional"},{"line_number":87,"context_line":"restriction on the placement of the resources. In the multi port case the"},{"line_number":88,"context_line":"Resource Group policy section above still applies."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"fd97cde1_64cd0bec","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":3},"in_reply_to":"4cca760a_a28604b8","updated":"2021-07-22 13:20:20.000000000","message":"Done","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":83,"context_line":"and minimum packet rate rules. Due to the placement resource modell of these"},{"line_number":84,"context_line":"features in this case the two request groups will always be fulfilled from"},{"line_number":85,"context_line":"separate resource providers and therefore neither the ``group_policy\u003dnone``"},{"line_number":86,"context_line":"and the ``group_policy\u003disolate`` flavor extra specs results in any additional"},{"line_number":87,"context_line":"restriction on the placement of the resources. In the multi port case the"},{"line_number":88,"context_line":"Resource Group policy section above still applies."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f7c0885_351ac32f","line":86,"range":{"start_line":86,"start_character":52,"end_line":86,"end_character":59},"in_reply_to":"635b9b1a_b300bc3e","updated":"2021-07-22 13:20:20.000000000","message":"Done","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"}],"nova/exception.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":1947,"context_line":""},{"line_number":1948,"context_line":""},{"line_number":1949,"context_line":"class ExtendedResourceRequestNotSupported(Invalid):"},{"line_number":1950,"context_line":"    msg_fmt \u003d _(\"The extended_resource_request neutron API extension not yet \""},{"line_number":1951,"context_line":"                \"supported by Nova. Please turn off this extension in \""},{"line_number":1952,"context_line":"                \"Neutron.\")"},{"line_number":1953,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"48f2baf3_aa5eef65","line":1950,"range":{"start_line":1950,"start_character":68,"end_line":1950,"end_character":69},"updated":"2021-07-20 17:16:28.000000000","message":"is","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":1947,"context_line":""},{"line_number":1948,"context_line":""},{"line_number":1949,"context_line":"class ExtendedResourceRequestNotSupported(Invalid):"},{"line_number":1950,"context_line":"    msg_fmt \u003d _(\"The extended_resource_request neutron API extension not yet \""},{"line_number":1951,"context_line":"                \"supported by Nova. Please turn off this extension in \""},{"line_number":1952,"context_line":"                \"Neutron.\")"},{"line_number":1953,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"d002772d_f7fedc94","line":1950,"range":{"start_line":1950,"start_character":68,"end_line":1950,"end_character":69},"in_reply_to":"48f2baf3_aa5eef65","updated":"2021-07-22 13:20:20.000000000","message":"Done","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"}],"nova/network/neutron.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c57994518e40f2fabcc40905698e974c5967944","unresolved":true,"context_lines":[{"line_number":1993,"context_line":""},{"line_number":1994,"context_line":"        if not utils.support_create_with_neutron_resource_request("},{"line_number":1995,"context_line":"            self, context"},{"line_number":1996,"context_line":"        ):"},{"line_number":1997,"context_line":"            raise exception.ExtendedResourceRequestNotSupported()"},{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"        physnets \u003d set()"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdab4e9_aa228f5d","line":1996,"updated":"2021-07-20 17:16:28.000000000","message":"This is a bit odd. Any reason to place this function in \u0027nova.utils\u0027 instead of here?","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d519dbe4f18283cfea583ebaaa46fe17210cfd","unresolved":false,"context_lines":[{"line_number":1993,"context_line":""},{"line_number":1994,"context_line":"        if not utils.support_create_with_neutron_resource_request("},{"line_number":1995,"context_line":"            self, context"},{"line_number":1996,"context_line":"        ):"},{"line_number":1997,"context_line":"            raise exception.ExtendedResourceRequestNotSupported()"},{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"        physnets \u003d set()"}],"source_content_type":"text/x-python","patch_set":11,"id":"45561126_edf4c149","line":1996,"in_reply_to":"9fdab4e9_aa228f5d","updated":"2021-07-22 13:20:20.000000000","message":"I went over many iterations so I guess this is ad-hoc. Moved it here now.","commit_id":"fc707790537907bac7e9823cb8faa80cbe43f60b"}]}