)]}'
{"gate/live_migration/hooks/ceph.sh":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"70668c3e73c2bb485a621691d59256bc68bc77ac","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function prepare_ceph {"},{"line_number":4,"context_line":"    git clone https://opendev.org/openstack/devstack-plugin-ceph /tmp/devstack-plugin-ceph -b $ZUUL_BRANCH"},{"line_number":5,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/settings"},{"line_number":6,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/lib/ceph"},{"line_number":7,"context_line":"    install_ceph"}],"source_content_type":"text/x-sh","patch_set":1,"id":"870d1670_af155ecf","line":4,"updated":"2021-06-01 15:57:50.000000000","message":"I guess without this we might wrongly get https://github.com/openstack/nova/blob/8b50f48ed2f04b39d416391a72faae8ad7e9d0f0/gate/live_migration/hooks/ceph.sh#L4 in stable branches too.","commit_id":"908721df5874b05bf3166db79428df618374a464"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f63f8f6420262e1a3ec6e15831a200ebd7560b99","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function prepare_ceph {"},{"line_number":4,"context_line":"    git clone https://opendev.org/openstack/devstack-plugin-ceph /tmp/devstack-plugin-ceph -b $ZUUL_BRANCH"},{"line_number":5,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/settings"},{"line_number":6,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/lib/ceph"},{"line_number":7,"context_line":"    install_ceph"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1442f219_e30b290c","line":4,"range":{"start_line":4,"start_character":94,"end_line":4,"end_character":106},"updated":"2021-06-01 18:19:02.000000000","message":"Right devstack-plugin-ceph started branching after the version bump issue covered in I1d029ebe78b16ed2d4345201b515baf3701533d5","commit_id":"908721df5874b05bf3166db79428df618374a464"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"ab1ce51779804bf9206b48168c8d4f91519ef26f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function prepare_ceph {"},{"line_number":4,"context_line":"    git clone https://opendev.org/openstack/devstack-plugin-ceph /tmp/devstack-plugin-ceph -b $ZUUL_BRANCH"},{"line_number":5,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/settings"},{"line_number":6,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/lib/ceph"},{"line_number":7,"context_line":"    install_ceph"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5884eae2_cd25092a","line":4,"range":{"start_line":4,"start_character":94,"end_line":4,"end_character":106},"in_reply_to":"1442f219_e30b290c","updated":"2021-06-01 19:31:56.000000000","message":"This looks like fixed the issue as nova-grenade-multinode job passed and the \u0027Error EPERM: configuring pool size as 1 is disabled by default.\u0027 error is not present.\n\n@Lee: what do you suggest:\n1. should we use similar pinning like the patch you linked above? OR\n2. is it enough to use the proper branch during the clone as in this patch?\n\nI\u0027ll prepare the patch as you\u0027ll suggest. Thanks in advance :)","commit_id":"908721df5874b05bf3166db79428df618374a464"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6b0111a8bca96cc3d21aea0f90ef179947771ed1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function prepare_ceph {"},{"line_number":4,"context_line":"    git clone https://opendev.org/openstack/devstack-plugin-ceph /tmp/devstack-plugin-ceph -b $ZUUL_BRANCH"},{"line_number":5,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/settings"},{"line_number":6,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/lib/ceph"},{"line_number":7,"context_line":"    install_ceph"}],"source_content_type":"text/x-sh","patch_set":1,"id":"8f8f37bc_d9710ba4","line":4,"range":{"start_line":4,"start_character":94,"end_line":4,"end_character":106},"in_reply_to":"5884eae2_cd25092a","updated":"2021-06-02 01:09:23.000000000","message":"IIUC what you\u0027ve proposed here is the right way to address the problem, since devstack-plugin-ceph has branched, we should use the branches. And for problems prior to the branching, the pinning was needed.","commit_id":"908721df5874b05bf3166db79428df618374a464"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f63f8f6420262e1a3ec6e15831a200ebd7560b99","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function prepare_ceph {"},{"line_number":4,"context_line":"    git clone https://opendev.org/openstack/devstack-plugin-ceph /tmp/devstack-plugin-ceph -b $ZUUL_BRANCH"},{"line_number":5,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/settings"},{"line_number":6,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/lib/ceph"},{"line_number":7,"context_line":"    install_ceph"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7bf3d0e8_5877fa8b","line":4,"in_reply_to":"870d1670_af155ecf","updated":"2021-06-01 18:19:02.000000000","message":"I\u0027m not sure what you\u0027re trying to say here, that\u0027s a stable/wallaby commit  and you\u0027re pointing at the same file as this change?","commit_id":"908721df5874b05bf3166db79428df618374a464"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0c913945f4c0da05290b662c1d24b47005fda764","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function prepare_ceph {"},{"line_number":4,"context_line":"    git clone https://opendev.org/openstack/devstack-plugin-ceph /tmp/devstack-plugin-ceph -b $ZUUL_BRANCH"},{"line_number":5,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/settings"},{"line_number":6,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/lib/ceph"},{"line_number":7,"context_line":"    install_ceph"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5715df5b_69759188","line":4,"range":{"start_line":4,"start_character":94,"end_line":4,"end_character":106},"in_reply_to":"8f8f37bc_d9710ba4","updated":"2021-06-02 10:31:44.000000000","message":"Thanks for the feedback melwitt, then I\u0027ll stick to this solution :)","commit_id":"908721df5874b05bf3166db79428df618374a464"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0c913945f4c0da05290b662c1d24b47005fda764","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function prepare_ceph {"},{"line_number":4,"context_line":"    echo \"Cloning devstack-plugin-ceph and selecting its ${ZUUL_BRANCH} branch...\""},{"line_number":5,"context_line":"    git clone https://opendev.org/openstack/devstack-plugin-ceph /tmp/devstack-plugin-ceph --branch ${ZUUL_BRANCH}"},{"line_number":6,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/settings"},{"line_number":7,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/lib/ceph"},{"line_number":8,"context_line":"    install_ceph"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3688eb92_550856e5","line":5,"range":{"start_line":5,"start_character":102,"end_line":5,"end_character":113},"updated":"2021-06-02 10:31:44.000000000","message":"I\u0027m not fond of using a \u0027ZUUL\u0027 variable here, but as far as I see there is no BRANCH variable here that we could use. :/","commit_id":"2216d9bee730e7769b5207177a207ce8246aab3d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5176cf89ed300ab3816bd97aeca27e0c74ceb415","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function prepare_ceph {"},{"line_number":4,"context_line":"    echo \"Cloning devstack-plugin-ceph and selecting its ${ZUUL_BRANCH} branch...\""},{"line_number":5,"context_line":"    git clone https://opendev.org/openstack/devstack-plugin-ceph /tmp/devstack-plugin-ceph --branch ${ZUUL_BRANCH}"},{"line_number":6,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/settings"},{"line_number":7,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/lib/ceph"},{"line_number":8,"context_line":"    install_ceph"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9aec7d49_9099bedd","line":5,"range":{"start_line":5,"start_character":102,"end_line":5,"end_character":113},"in_reply_to":"3688eb92_550856e5","updated":"2021-06-02 17:36:09.000000000","message":"Yeah, agree, can we use the TARGET_BRANCH variable from devstack?","commit_id":"2216d9bee730e7769b5207177a207ce8246aab3d"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"9d279ee81bd45904b6de1a5300eef1b53df1cc32","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function prepare_ceph {"},{"line_number":4,"context_line":"    echo \"Cloning devstack-plugin-ceph and selecting its ${ZUUL_BRANCH} branch...\""},{"line_number":5,"context_line":"    git clone https://opendev.org/openstack/devstack-plugin-ceph /tmp/devstack-plugin-ceph --branch ${ZUUL_BRANCH}"},{"line_number":6,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/settings"},{"line_number":7,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/lib/ceph"},{"line_number":8,"context_line":"    install_ceph"}],"source_content_type":"text/x-sh","patch_set":2,"id":"a42bba83_113b7c98","line":5,"range":{"start_line":5,"start_character":102,"end_line":5,"end_character":113},"in_reply_to":"9aec7d49_9099bedd","updated":"2021-06-02 18:36:07.000000000","message":"I thought that this live migration hook is used other than the grenade jobs, so I was surprised when I now double-checked and saw that this is actually only called in nova-grenade-multinode job. Thanks for the hint! :)","commit_id":"2216d9bee730e7769b5207177a207ce8246aab3d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8b31fbf2544728b06c945e045e650be1042484e5","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function prepare_ceph {"},{"line_number":4,"context_line":"    echo \"Cloning devstack-plugin-ceph and selecting its ${TARGET_BRANCH} branch...\""},{"line_number":5,"context_line":"    git clone https://opendev.org/openstack/devstack-plugin-ceph /tmp/devstack-plugin-ceph --branch ${TARGET_BRANCH}"},{"line_number":6,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/settings"},{"line_number":7,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/lib/ceph"},{"line_number":8,"context_line":"    install_ceph"}],"source_content_type":"text/x-sh","patch_set":3,"id":"0abbeada_fe8064ab","line":5,"updated":"2021-06-02 20:53:48.000000000","message":"Sorry elod, it looks like I have led you astray 😞:\n\n2021-06-02 20:35:44.527358 | primary | 2021-06-02 20:35:44.526 | 4. test with Ceph for root + ephemeral disks\n2021-06-02 20:35:44.794060 | primary | 2021-06-02 20:35:44.793 | Cloning devstack-plugin-ceph and selecting its  branch...\n2021-06-02 20:35:44.797201 | primary | 2021-06-02 20:35:44.796 | error: option `branch\u0027 requires a value\n\nI didn\u0027t think TARGET_BRANCH could be unset for stable branch devstack deploys and I was obviously wrong.\n\nhttps://zuul.opendev.org/t/openstack/build/fe261d5522674cbfad5f46be7f21237b/log/job-output.txt#4662","commit_id":"41c2c0a1daa747cff8a911d797cedc84dffba856"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5b6e78dd3791e9df9330d2836978f5b7b64f74d4","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function prepare_ceph {"},{"line_number":4,"context_line":"    echo \"Cloning devstack-plugin-ceph and selecting its ${TARGET_BRANCH} branch...\""},{"line_number":5,"context_line":"    git clone https://opendev.org/openstack/devstack-plugin-ceph /tmp/devstack-plugin-ceph --branch ${TARGET_BRANCH}"},{"line_number":6,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/settings"},{"line_number":7,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/lib/ceph"},{"line_number":8,"context_line":"    install_ceph"}],"source_content_type":"text/x-sh","patch_set":3,"id":"c987663e_0ffa348f","line":5,"in_reply_to":"0abbeada_fe8064ab","updated":"2021-06-02 22:08:53.000000000","message":"OK, I asked about ZUUL_BRANCH vs TARGET_BRANCH in #openstack-infra a little while ago [1] and tosky recommends backporting the native zuul job to at least stable/ussuri and maybe stable/train. I will attempt to do this, just to see whether it will work.\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2021-06-02.log.html#t2021-06-02T21:41:54","commit_id":"41c2c0a1daa747cff8a911d797cedc84dffba856"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f3aa95d534437fa5397e633b338e356dfd3941c3","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function prepare_ceph {"},{"line_number":4,"context_line":"    echo \"Cloning devstack-plugin-ceph and selecting its ${TARGET_BRANCH} branch...\""},{"line_number":5,"context_line":"    git clone https://opendev.org/openstack/devstack-plugin-ceph /tmp/devstack-plugin-ceph --branch ${TARGET_BRANCH}"},{"line_number":6,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/settings"},{"line_number":7,"context_line":"    source /tmp/devstack-plugin-ceph/devstack/lib/ceph"},{"line_number":8,"context_line":"    install_ceph"}],"source_content_type":"text/x-sh","patch_set":3,"id":"172f2e1e_d4399436","line":5,"in_reply_to":"c987663e_0ffa348f","updated":"2021-06-03 04:50:35.000000000","message":"\u003e I will attempt to do this, just to see whether it will work.\n\nHere\u0027s the attempt to backport, FWIW: https://review.opendev.org/c/openstack/nova/+/794345","commit_id":"41c2c0a1daa747cff8a911d797cedc84dffba856"}]}