)]}'
{"id":"openstack%2Fnova~794624","triplet_id":"openstack%2Fnova~stable%2Fvictoria~Ic03a5336abdced883f62f395690c0feac12075c8","project":"openstack/nova","branch":"stable/victoria","topic":"bug/1928007","hashtags":[],"change_id":"Ic03a5336abdced883f62f395690c0feac12075c8","subject":"rbd: Get rbd_utils unit tests running again","status":"MERGED","created":"2021-06-03 18:04:42.000000000","updated":"2021-06-25 02:41:47.000000000","submitted":"2021-06-25 02:39:50.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"794624-bug/1928007","cherry_pick_of_change":790836,"cherry_pick_of_patch_set":1,"meta_rev_id":"65582d8f85e8ae880e12ab79d61419b89da983d6","_number":794624,"virtual_id_number":794624,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-06-25 02:39:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-06-24 18:16:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2021-06-15 16:53:44.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-06-24 18:16:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-03 19:54:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-03 21:45:39.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-06-15 16:53:44.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2021-06-24 18:16:50.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"da15d66375b6e964cf28e82fdbbd331802fd042c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-06-03 18:04:42.000000000","message":"Patch Set 1: Cherry Picked from branch stable/wallaby.","accounts_in_message":[],"_revision_number":1},{"id":"bfa079a409f42ea58e5ac08f5a7822d0df89379e","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-06-03 18:05:24.000000000","message":"Topic bug/1928007-stable/victoria removed","accounts_in_message":[],"_revision_number":1},{"id":"344097bd7f776df6c5efbf75043d4c2809859f73","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-06-03 18:05:33.000000000","message":"Topic set to bug/1928007","accounts_in_message":[],"_revision_number":1},{"id":"6111011b18069f33b7d25db70856f4e25c5ee1a9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-03 19:54:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5908e1ec67dc4c79b6ba8beeebfbfcf1 : SUCCESS in 18m 13s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2fb0156aff324d7ab36202df02fe6ead : SUCCESS in 15m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/01c7f9d8f02446b7bab67defa0d36544 : SUCCESS in 9m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d4c6241ca8ea4b4992c5571588e176dc : SUCCESS in 14m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/06482b26b18f430992aa51d3e4428907 : SUCCESS in 14m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6c3e07ee9c5c4fb0a5dceab9a104db2a : SUCCESS in 12m 34s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a7eaa21173be470793ddd286147affbe : SUCCESS in 21m 11s","accounts_in_message":[],"_revision_number":1},{"id":"8b1bcc3d9245d14f07d3eee81f571c4ba5d5644e","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-06-03 21:45:39.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/794624/1/iscsi : FAILURE in 2h 27m 34s","accounts_in_message":[],"_revision_number":1},{"id":"9ef7f5fe94d244d73f746febf507747f05204276","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-15 16:53:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e6db90ed38c638c214f4335cb202e2b6f6c1881c","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-06-24 18:16:50.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean cherry pick of a test only fix from Wallaby, where the patch has merged. LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"4fbcb838f0c15dea90e557e48564aab31f7fcbc0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 18:17:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"4d2843cadf5978b64969973aeb9f43874a362e9f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-25 02:39:49.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6c3c92d79c924beab510f3378f480101 : SUCCESS in 15m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef84bb675cce41a78267448d49962c61 : SUCCESS in 10m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ad2f56da44f4484d9595c3e0759e0d47 : SUCCESS in 14m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/209eac8d172a444e922051a5d148c603 : SUCCESS in 15m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/03f6d1fbd72b432fa8cd304e560b56ae : SUCCESS in 12m 06s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/5ebfc075a8b74c9080c85bf37ad90423 : SUCCESS in 20m 43s","accounts_in_message":[],"_revision_number":1},{"id":"f25597fada8f1c5dbeaa2ba0a8e1c717f72dd34b","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-25 02:39:50.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"65582d8f85e8ae880e12ab79d61419b89da983d6","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-25 02:41:47.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ddda169f56df4056892aab3af58de1e8 : SUCCESS in 1m 00s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"04057099991579bccfb2accb6b0952ba589fe092","revisions":{"04057099991579bccfb2accb6b0952ba589fe092":{"kind":"REWORK","_number":1,"created":"2021-06-03 18:04:42.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/24/794624/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/24/794624/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/794624/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/794624/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/794624/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/24/794624/1"}}},"commit":{"parents":[{"commit":"e954a56fec69637ebd671643d41bb0ecc85a2656","subject":"Merge \"guestfs: With libguestfs \u003e\u003d v1.41.1 decode returned bytes to string\" into stable/victoria","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e954a56fec69637ebd671643d41bb0ecc85a2656"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-05-10 17:31:25.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-06-03 18:04:42.000000000","tz":0},"subject":"rbd: Get rbd_utils unit tests running again","message":"rbd: Get rbd_utils unit tests running again\n\nAwhile back, change I25baf5edd25d9e551686b7ed317a63fd778be533 moved\nrbd_utils out from the libvirt driver and into a central location under\nnova/storage. This move missed adding a __init__.py file under\nnova/tests/unit/storage, so unit test discovery wasn\u0027t picking up the\nrbd_utils tests and couldn\u0027t run them.\n\nThis adds a __init__.py file under nova/tests/unit/storage to get the\ntests running again.\n\nThis also fixes a small bug introduced by change\nI3032bbe6bd2d6acc9ba0f0cac4d00ed4b4464ceb in RbdTestCase.setUp() that\npassed nonexistent self.images_rbd_pool to self.flags. It should be\nself.rbd_pool.\n\nCloses-Bug: #1928007\n\nChange-Id: Ic03a5336abdced883f62f395690c0feac12075c8\n(cherry picked from commit 8b647f1b3f56879be221b3925570790a1e0e77f8)\n(cherry picked from commit 8f018d754d5c55e432cd51df99278382b527283e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/04057099991579bccfb2accb6b0952ba589fe092"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/04057099991579bccfb2accb6b0952ba589fe092"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}