)]}'
{"nova/objects/fields.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1ea30f4a4e71892214dcd8d828f157dbca405a18","unresolved":true,"context_lines":[{"line_number":580,"context_line":"    BOCHS \u003d \u0027bochs\u0027"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    ALL \u003d (CIRRUS, QXL, VGA, VMVGA, XEN, VIRTIO, GOP, NONE, BOCHS)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"class VIFModel(BaseNovaEnum):"},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7c2cd5ae_60561c62","line":583,"updated":"2021-06-04 12:54:18.000000000","message":"+1","commit_id":"57d88ba146691e359ef3849f2c3803682ed95e55"}],"nova/objects/image_meta.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1ea30f4a4e71892214dcd8d828f157dbca405a18","unresolved":true,"context_lines":[{"line_number":181,"context_line":"    # Version 1.30: Added \u0027bochs\u0027 as an option to \u0027hw_video_model\u0027"},{"line_number":182,"context_line":"    # NOTE(efried): When bumping this version, the version of"},{"line_number":183,"context_line":"    # ImageMetaPropsPayload must also be bumped. See its docstring for details."},{"line_number":184,"context_line":"    VERSION \u003d \u00271.29\u0027"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":187,"context_line":"        super(ImageMetaProps, self).obj_make_compatible(primitive,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f92d9979_d1cb62c5","line":184,"range":{"start_line":184,"start_character":17,"end_line":184,"end_character":19},"updated":"2021-06-04 12:54:18.000000000","message":"this should be 30","commit_id":"57d88ba146691e359ef3849f2c3803682ed95e55"}],"nova/tests/unit/objects/test_image_meta.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"83d591f843b3ec216ea05d0dd5f5a424bf1302d9","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        obj \u003d objects.ImageMetaProps("},{"line_number":395,"context_line":"            hw_video_model\u003dobjects.fields.VideoModel.BOCHS)"},{"line_number":396,"context_line":"        # \u0027bochs\u0027 was added in 1.30"},{"line_number":397,"context_line":"        self.assertRaises(exception.ObjectActionError,"},{"line_number":398,"context_line":"                                   obj.obj_to_primitive, \u00271.30\u0027)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def test_obj_make_compatible_watchdog_action_not_disabled(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"b07d68df_92e54b9b","line":397,"updated":"2021-06-08 14:45:46.000000000","message":"Can we get a positive test also?","commit_id":"2a674271888ffa716dee123c2aabba69ea52109f"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"bd0ed48e15fa6458ca078992148706b55bfa1a91","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        obj \u003d objects.ImageMetaProps("},{"line_number":395,"context_line":"            hw_video_model\u003dobjects.fields.VideoModel.BOCHS)"},{"line_number":396,"context_line":"        # \u0027bochs\u0027 was added in 1.30"},{"line_number":397,"context_line":"        self.assertRaises(exception.ObjectActionError,"},{"line_number":398,"context_line":"                                   obj.obj_to_primitive, \u00271.30\u0027)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def test_obj_make_compatible_watchdog_action_not_disabled(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"99f1528c_b18b05ed","line":397,"in_reply_to":"b07d68df_92e54b9b","updated":"2021-09-02 13:32:13.000000000","message":"Sure, forgot to respond to this.","commit_id":"2a674271888ffa716dee123c2aabba69ea52109f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5c6e689083e02b779c5d6a1503143a816b3f2b9","unresolved":true,"context_lines":[{"line_number":395,"context_line":"            hw_video_model\u003dobjects.fields.VideoModel.BOCHS)"},{"line_number":396,"context_line":"        # \u0027bochs\u0027 was added in 1.30"},{"line_number":397,"context_line":"        self.assertRaises(exception.ObjectActionError,"},{"line_number":398,"context_line":"                                   obj.obj_to_primitive, \u00271.30\u0027)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def test_obj_make_compatible_watchdog_action_not_disabled(self):"},{"line_number":401,"context_line":"        \"\"\"Tests that we don\u0027t pop the hw_watchdog_action if the value is not"}],"source_content_type":"text/x-python","patch_set":3,"id":"00ec8d9c_443175fd","line":398,"range":{"start_line":398,"start_character":60,"end_line":398,"end_character":62},"updated":"2021-09-02 12:13:52.000000000","message":"29","commit_id":"2a674271888ffa716dee123c2aabba69ea52109f"}],"releasenotes/notes/releasenotes/notes/bochs-ffaa289da97d08c8.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"83d591f843b3ec216ea05d0dd5f5a424bf1302d9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for the ``bochs`` libvirt video model.  For UEFI guests"},{"line_number":5,"context_line":"    the ``bochs`` model is a potential safe option, instead of the"},{"line_number":6,"context_line":"    standard VGA device.  The ``bochs`` firmware will setup a linear"},{"line_number":7,"context_line":"    framebuffer similar to the ``gop`` model, and never use any legacy"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"84075fce_fe8b8454","line":4,"range":{"start_line":4,"start_character":56,"end_line":4,"end_character":71},"updated":"2021-06-08 14:45:46.000000000","message":"This only works with UEFI, right? Shouldn\u0027t be asserting that UEFI is enabled, similar to how we force this check for secure boot?","commit_id":"2a674271888ffa716dee123c2aabba69ea52109f"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"5289b526db934ad5361a29d954bbf3da0130652d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for the ``bochs`` libvirt video model.  For UEFI guests"},{"line_number":5,"context_line":"    the ``bochs`` model is a potential safe option, instead of the"},{"line_number":6,"context_line":"    standard VGA device.  The ``bochs`` firmware will setup a linear"},{"line_number":7,"context_line":"    framebuffer similar to the ``gop`` model, and never use any legacy"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8b595966_5aa36707","line":4,"range":{"start_line":4,"start_character":56,"end_line":4,"end_character":71},"in_reply_to":"84075fce_fe8b8454","updated":"2021-09-01 13:56:28.000000000","message":"Not really; \u0027bochs\u0027 also works for others.  But is usually better-suited for UEFI","commit_id":"2a674271888ffa716dee123c2aabba69ea52109f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"83d591f843b3ec216ea05d0dd5f5a424bf1302d9","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for the ``bochs`` libvirt video model.  For UEFI guests"},{"line_number":5,"context_line":"    the ``bochs`` model is a potential safe option, instead of the"},{"line_number":6,"context_line":"    standard VGA device.  The ``bochs`` firmware will setup a linear"},{"line_number":7,"context_line":"    framebuffer similar to the ``gop`` model, and never use any legacy"},{"line_number":8,"context_line":"    VGA features.  Every guest configured with ``bochs`` display should"},{"line_number":9,"context_line":"    come up with a working display."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ed825af2_6172fd8b","line":9,"range":{"start_line":5,"start_character":4,"end_line":9,"end_character":35},"updated":"2021-06-08 14:45:46.000000000","message":"This feels like a little too much detail to give in a release note. Could we say something as simple as:\n\n  This is a largely legacy-free video model optimized for use with UEFI-based guests.","commit_id":"2a674271888ffa716dee123c2aabba69ea52109f"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"5289b526db934ad5361a29d954bbf3da0130652d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for the ``bochs`` libvirt video model.  For UEFI guests"},{"line_number":5,"context_line":"    the ``bochs`` model is a potential safe option, instead of the"},{"line_number":6,"context_line":"    standard VGA device.  The ``bochs`` firmware will setup a linear"},{"line_number":7,"context_line":"    framebuffer similar to the ``gop`` model, and never use any legacy"},{"line_number":8,"context_line":"    VGA features.  Every guest configured with ``bochs`` display should"},{"line_number":9,"context_line":"    come up with a working display."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d199620c_0406ad91","line":9,"range":{"start_line":5,"start_character":4,"end_line":9,"end_character":35},"in_reply_to":"ed825af2_6172fd8b","updated":"2021-09-01 13:56:28.000000000","message":"Sure, I\u0027d rephrase it.","commit_id":"2a674271888ffa716dee123c2aabba69ea52109f"}]}