)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"5f490c202547ef73c1f9d5a87aab815b024c05f0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[EC2]Correct the return status of attaching volome"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The EC2 API return volume\u0027status as \u0027detached\u0027 in response when"},{"line_number":10,"context_line":"attaching a volume."},{"line_number":11,"context_line":"It should be \u0027attaching\u0027 according to EC2\u0027s API docs."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAVn%2F%2B9Dw%3D","line":9,"updated":"2014-03-11 03:02:29.000000000","message":"volume --\u003e volumes","commit_id":"1ffccf69c3369415bf4eb6fd202d1cd75a3771e4"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"af63790460a0bd28a71fa44f78aff5963ff71e3b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liu-sheng \u003cliusheng@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-27 11:46:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[EC2]Correct the return status of attaching volome"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The EC2 API return volume\u0027s status as \u0027detached\u0027 in response when"},{"line_number":10,"context_line":"attaching a volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAXX%2F%2Fvxg%3D","line":7,"updated":"2014-04-28 09:32:58.000000000","message":"volume","commit_id":"5855dfca8c3629b3d5abcfa6dcd31a31a9544ec6"}],"nova/api/ec2/ec2utils.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"58ab436a937471d7ec742e9aad2a856064de0559","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    if volume_status in (\u0027attaching\u0027, \u0027detaching\u0027):"},{"line_number":245,"context_line":"        ec2_attach_status \u003d volume_status"},{"line_number":246,"context_line":"    else:"},{"line_number":247,"context_line":"        ec2_attach_status \u003d attach_status"},{"line_number":248,"context_line":"    return ec2_attach_status"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_fdc4c093","line":247,"updated":"2014-05-09 23:17:07.000000000","message":"this bare else statement looks like a little risky. Right now this works but what happens if we add another state or change one?\n\nI would prefer to see an elsif and then and else raise an error. or something like that.","commit_id":"ee0723ec5c75dc460fc59b2e2fb30e4206e45244"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"28c8e1226937fef88b0bc7210b8e388729a23090","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    if volume_status in (\u0027attaching\u0027, \u0027detaching\u0027):"},{"line_number":245,"context_line":"        ec2_attach_status \u003d volume_status"},{"line_number":246,"context_line":"    else:"},{"line_number":247,"context_line":"        ec2_attach_status \u003d attach_status"},{"line_number":248,"context_line":"    return ec2_attach_status"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_bb0d153a","line":247,"in_reply_to":"7adec928_a7b05a8c","updated":"2014-05-21 07:30:53.000000000","message":"While I doubt a third state will be added, we should make this code future proof so it won\u0027t silently  begin breaking if we add another state.","commit_id":"ee0723ec5c75dc460fc59b2e2fb30e4206e45244"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"09dba63db207cde15484fb8af3a693f4c18c4fd2","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    if volume_status in (\u0027attaching\u0027, \u0027detaching\u0027):"},{"line_number":245,"context_line":"        ec2_attach_status \u003d volume_status"},{"line_number":246,"context_line":"    else:"},{"line_number":247,"context_line":"        ec2_attach_status \u003d attach_status"},{"line_number":248,"context_line":"    return ec2_attach_status"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_e42b5c92","line":247,"in_reply_to":"7adec928_bb0d153a","updated":"2014-05-22 04:06:45.000000000","message":"Hi liusheng, I also think Joe\u0027s suggestion is better.:)","commit_id":"ee0723ec5c75dc460fc59b2e2fb30e4206e45244"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"b12dee4c9b47dfd8e03bbe968fc449b993763592","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    if volume_status in (\u0027attaching\u0027, \u0027detaching\u0027):"},{"line_number":245,"context_line":"        ec2_attach_status \u003d volume_status"},{"line_number":246,"context_line":"    else:"},{"line_number":247,"context_line":"        ec2_attach_status \u003d attach_status"},{"line_number":248,"context_line":"    return ec2_attach_status"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_a7b05a8c","line":247,"in_reply_to":"7adec928_fdc4c093","updated":"2014-05-12 03:06:28.000000000","message":"Hi Joe Gordon, IMHO, I personally think, the attach_status in cinder mast be one of \"attached\" and \"detached\", Actually, in cinder code, many place seem to hardcode this. So I doubt if it will be added the third sttach_status? \nIf the that is necessary, I will upload a new patchset.\n\nthanks. liusheng","commit_id":"ee0723ec5c75dc460fc59b2e2fb30e4206e45244"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"530c51bdd43dee598a88def94bd1b2b413749881","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"def status_to_ec2_attach_status(volume):"},{"line_number":241,"context_line":"    \"\"\"Get the corresponding EC2 attachment state."},{"line_number":242,"context_line":"    According to EC2 API, the valid attachment status in response is:"},{"line_number":243,"context_line":"    attaching | attached | detaching | detached"},{"line_number":244,"context_line":"    \"\"\""},{"line_number":245,"context_line":"    volume_status \u003d volume.get(\u0027status\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_39ec6d29","line":242,"updated":"2014-05-23 00:55:55.000000000","message":"There should be a blank line about this line.","commit_id":"cdce0a3e0edb062202a93362661f8e5102b84734"}],"nova/tests/api/ec2/test_cinder_cloud.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"530c51bdd43dee598a88def94bd1b2b413749881","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def test_volume_status_of_attaching_volume(self):"},{"line_number":268,"context_line":"        \"\"\"Test the volume\u0027s status in response when attaching a volume."},{"line_number":269,"context_line":"        \"\"\""},{"line_number":270,"context_line":"        vol1 \u003d self.cloud.create_volume(self.context,"},{"line_number":271,"context_line":"                                        size\u003d1,"},{"line_number":272,"context_line":"                                        name\u003d\u0027test-ls\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_79f6f5fa","line":269,"updated":"2014-05-23 00:55:55.000000000","message":"The close quote should be on the previous line.","commit_id":"cdce0a3e0edb062202a93362661f8e5102b84734"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"530c51bdd43dee598a88def94bd1b2b413749881","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def test_volume_status_of_detaching_volume(self):"},{"line_number":289,"context_line":"        \"\"\"Test the volume\u0027s status in response when detaching a volume."},{"line_number":290,"context_line":"        \"\"\""},{"line_number":291,"context_line":"        vol1 \u003d self.cloud.create_volume(self.context,"},{"line_number":292,"context_line":"                                        size\u003d1,"},{"line_number":293,"context_line":"                                        name\u003d\u0027test-ls\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_b9d79d4e","line":290,"updated":"2014-05-23 00:55:55.000000000","message":"Ditto","commit_id":"cdce0a3e0edb062202a93362661f8e5102b84734"}]}