)]}'
{"nova/tests/virt/xenapi/test_vm_utils.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"4f3ce70b30c10b3277a560a0610ef7bdb1d820bf","unresolved":false,"context_lines":[{"line_number":571,"context_line":"    def test_get_partitions(self, mock_execute):"},{"line_number":572,"context_line":"        parted_return \u003d \"BYT;\\n...\\n\""},{"line_number":573,"context_line":"        parted_return +\u003d \"1:2s:11s:10s:ext3::boot;\\n\""},{"line_number":574,"context_line":"        parted_return +\u003d \"2:20s:11s:10s::bob:;\\n\""},{"line_number":575,"context_line":"        mock_execute.return_value \u003d (parted_return, None)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        partitions \u003d vm_utils._get_partitions(\"abc\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Fck%3D","line":574,"updated":"2014-03-12 14:00:38.000000000","message":"Nit: string concatenation not required.\n\n parted_return \u003d (\"BYT;\\n...\\n\"\n                               \"1:2s:11s:10s:ext3::boot;\\n\"\n                               \"2:20s:11s:10s::bob:;\\n\")","commit_id":"d0a66d9eb1511e723a6fba41bd27505cc21c6301"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"837a23a99359885d9be849db4ec7f23da2ba2486","unresolved":false,"context_lines":[{"line_number":578,"context_line":""},{"line_number":579,"context_line":"        self.assertEqual(2, len(partitions))"},{"line_number":580,"context_line":"        self.assertEqual((\u00271\u0027, 2, 10, \"ext3\"), partitions[0])"},{"line_number":581,"context_line":"        self.assertEqual((\u00272\u0027, 20, 10, \"\"), partitions[1])"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"class CheckVDISizeTestCase(VMUtilsTestBase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F0bY%3D","line":581,"updated":"2014-03-13 15:57:57.000000000","message":"Nit, no need to do more work and compare the list length and index each row individually:\n\n        expected \u003d [\n            (\u00271\u0027, 2, 10, \u0027ext3\u0027),\n            (\u00272\u0027, 20, 10, \u0027\u0027),\n        ]\n        self.assertEquals(expected, partitions)","commit_id":"d0a66d9eb1511e723a6fba41bd27505cc21c6301"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"d789edfb330bab67240a083f29a45f5ba78a6a90","unresolved":false,"context_lines":[{"line_number":571,"context_line":"    def test_get_partitions(self, mock_execute):"},{"line_number":572,"context_line":"        parted_return \u003d \"BYT;\\n...\\n\""},{"line_number":573,"context_line":"        parted_return +\u003d \"1:2s:11s:10s:ext3::boot;\\n\""},{"line_number":574,"context_line":"        parted_return +\u003d \"2:20s:11s:10s::bob:;\\n\""},{"line_number":575,"context_line":"        mock_execute.return_value \u003d (parted_return, None)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        partitions \u003d vm_utils._get_partitions(\"abc\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9jWs%3D","line":574,"updated":"2014-04-03 18:34:38.000000000","message":"I much prefer a list of parts with a \"\".join(...) at the end but this is fine for here, though it looks like you got a similar comment in a previous patch","commit_id":"5351dc9b55c82a823fb0e4a2cd74cb3b80759c86"}]}