)]}'
{"id":"openstack%2Fnova~796262","triplet_id":"openstack%2Fnova~stable%2Fussuri~I856268b371f7ba712b02189db3c927cd762a4dc3","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1905701","attention_set":{},"removed_from_attention_set":{"10135":{"account":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"last_update":"2024-02-07 12:53:17.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I856268b371f7ba712b02189db3c927cd762a4dc3","subject":"virt: Add destroy_secrets kwarg to destroy and cleanup","status":"ABANDONED","created":"2021-06-14 11:05:17.000000000","updated":"2024-02-07 12:53:17.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a2017080a235f30b73cb25f66f4d52a544c26bb1","_number":796262,"virtual_id_number":796262,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-06-17 18:56:14.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-14 13:04:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-14 13:54:21.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-06-14 16:56:47.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2024-02-07 12:53:17.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"f15f058688d523fa0ce7f8d8ddcd2afbd1abee16","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-14 11:05:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"575395e451a5b616f24c7b87bbd0b6350e30b468","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-14 13:04:57.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/08383d0e29c44da7987ddf955e27a35d : SUCCESS in 1h 19m 26s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4e82dd35b64c44a68d5aa90990705333 : FAILURE in 14m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a5a7876781fc41faa68ec617d0833fb1 : FAILURE in 16m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1fe2f984496145efbc4a02a87b36bdee : FAILURE in 8m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/628f6d7587564e1cafa1a5298f72fb2c : FAILURE in 12m 58s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/90b80a2032284247aa99120122f5e928 : FAILURE in 18m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2231d850194d4fbd8a802c31a7e11f8b : SUCCESS in 12m 30s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/ab7178cbd6544f7587e8c131c408c285 : SUCCESS in 1h 00m 02s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/948c01412e8e430dac9d6b5bb2fb55ea : SUCCESS in 1h 54m 16s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/ac2d208ed5bf469083ea85b7cbdc0c72 : FAILURE in 1h 36m 55s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/75e326a7f153445788bb7a4e1d279b8d : SUCCESS in 51m 06s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/9901617997194c60b013853daeb2c796 : SUCCESS in 54m 36s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/f26b11b490c34a2e888c2d1299b8edd3 : SUCCESS in 1h 16m 48s\n- nova-next https://zuul.opendev.org/t/openstack/build/b1da289d9b084c6dbef0d7ffc79075ba : SUCCESS in 1h 41m 53s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/91dffc8dc7cb4a92b3a4a65c59559c80 : SUCCESS in 19m 32s\n- grenade https://zuul.opendev.org/t/openstack/build/cbd15d29fca248b4b6ea56be8e93d10a : SUCCESS in 1h 04m 21s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/aef686f3588947b383820162a4f4e2bc : SUCCESS in 53m 54s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/b7911e0c2dd34e31a475748b5c8daf8e : SUCCESS in 49m 07s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/5c5bed1bd15b444d88c4ad11a5eef474 : FAILURE in 28m 35s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"642b7d33d5584aea5bd5832641ba48d3b6515189","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-14 13:54:21.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/62/796262/1/check/tempest-dsvm-full-bionic/02bda21/ : SUCCESS in 2h 15m 25s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/62/796262/1/check/tempest-dsvm-full-bionic-py3/9748cee/ : SUCCESS in 2h 24m 38s","accounts_in_message":[],"_revision_number":1},{"id":"228f8a6602eaad096fea7d55e45def47235576f4","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-06-14 16:56:47.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/796262/1/iscsi : SUCCESS in 4h 01m 14s","accounts_in_message":[],"_revision_number":1},{"id":"c7051669cf84bd011b610b33dcc311674cd542ac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-17 16:50:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9ed054e148c6f9c01e5a4b71da0aee8b8e98e5ef","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-17 17:20:03.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"cba2de88b64f4ff01752a42ba463e87b330eee20","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-17 18:56:14.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/ae358d3b0aa64234adcaef3e52756e9a : SUCCESS in 1h 15m 20s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f2458f0d23774947a90366b634d94f7f : SUCCESS in 17m 18s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/558dddd3167d4b51aa38921d69c61cc6 : SUCCESS in 16m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/91b0e8df2b9c414ba66784d7fc0207ab : FAILURE in 9m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/be03fea5c1fa49a78d983f403266ab59 : SUCCESS in 13m 39s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ead88bb90c2b419685b3b1adc313a484 : SUCCESS in 14m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5632eb1cee8a4e6ba41c2f073ee14e77 : SUCCESS in 12m 34s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/19774f741cb746e18c3e90591b3abdb3 : SUCCESS in 1h 08m 52s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/ba5e6937182642a4bd2ac67be8609dc1 : SUCCESS in 1h 19m 00s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/beadb8bba43345c2b7e38501a16c72a8 : FAILURE in 1h 18m 54s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/7684b02742f342bca40098b2c9f8b83d : SUCCESS in 52m 55s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/a4abe4f66e00496d855d6dae05a75a98 : SUCCESS in 53m 54s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/dddaaac44f664466b6f1faf4a4fca4af : SUCCESS in 1h 27m 53s\n- nova-next https://zuul.opendev.org/t/openstack/build/45855920a72a42208f738d4ce128d9ef : SUCCESS in 1h 30m 17s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/b365a308c23f459bb62539b5b3fd95e3 : SUCCESS in 19m 12s\n- grenade https://zuul.opendev.org/t/openstack/build/542f73f512e445afae29fa562892bf2e : SUCCESS in 1h 06m 07s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1d80366325f8415eb33bd3a96082d2b7 : SUCCESS in 51m 44s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/e07ebce2198748d7a0579089dcf699fe : SUCCESS in 53m 04s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/71ef3dc51f154a629d3d1237e71a1e85 : FAILURE in 29m 13s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"1e8c0cd238025746b12888fa1f2dfd8eb0f03fa3","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-06-17 22:00:46.000000000","message":"Patch Set 3:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/796262/3/iscsi : SUCCESS in 2h 30m 56s","accounts_in_message":[],"_revision_number":3},{"id":"4c2f62193bbd49db523f949c5dc23634da4b655e","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-18 00:58:48.000000000","message":"Patch Set 3:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic finger://zuul-v3-executor.novalocal/c5eaa501185240ff9df1cfaf43d319fc : POST_FAILURE in 2h 08m 13s\n- tempest-dsvm-full-bionic-py3 finger://zuul-v3-executor.novalocal/ab59a2e01b0f4362b97be98d06ed52c3 : POST_FAILURE in 1h 56m 50s","accounts_in_message":[],"_revision_number":3},{"id":"d22092e2abd0d06b93f901c61810841a67473879","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-08-16 17:15:58.000000000","message":"Topic set to bug/1905701","accounts_in_message":[],"_revision_number":3},{"id":"a2017080a235f30b73cb25f66f4d52a544c26bb1","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-02-07 12:53:17.000000000","message":"Abandoned\n\nstable/ussuri branch of openstack/nova transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"94dd3679f9a78f45edd11dd3d6bb2b3f4caec41b","revisions":{"47ccb6ff108cc391a57f3ec95d639135fee7a8a5":{"kind":"REWORK","_number":1,"created":"2021-06-14 11:05:17.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/62/796262/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/796262/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/796262/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/796262/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/796262/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/796262/1"}}},"commit":{"parents":[{"commit":"ba6789e458f5da1e7b792866120128c609ca8537","subject":"Merge \"Update image_base_image_ref during rebuild.\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba6789e458f5da1e7b792866120128c609ca8537"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-02 14:33:40.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-14 11:01:09.000000000","tz":60},"subject":"virt: Add destroy_secrets kwarg to destroy and cleanup","message":"virt: Add destroy_secrets kwarg to destroy and cleanup\n\nThis change adds a simple optional kwarg to the virt driver signature of\ndestroy and cleanup to allow for callers to control when secrets should\nbe removed.\n\nChange-Id: I856268b371f7ba712b02189db3c927cd762a4dc3\n(cherry picked from commit 1cc52fd2f22ec37194519e473c88260bf90a3c8c)\n(cherry picked from commit f2ba67184d3801fdca4a33aa744a3471bcd21de2)\n(cherry picked from commit 813bee5a9df762a08c393b269b9b0d32096183d8)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/47ccb6ff108cc391a57f3ec95d639135fee7a8a5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/47ccb6ff108cc391a57f3ec95d639135fee7a8a5"}]},"branch":"refs/heads/stable/ussuri"},"196973dfc8b0576ea1e62a9dcfdd1fd28ba7d686":{"kind":"REWORK","_number":2,"created":"2021-06-17 16:50:26.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/62/796262/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/796262/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/796262/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/796262/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/796262/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/796262/2"}}},"commit":{"parents":[{"commit":"ba6789e458f5da1e7b792866120128c609ca8537","subject":"Merge \"Update image_base_image_ref during rebuild.\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba6789e458f5da1e7b792866120128c609ca8537"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-02 14:33:40.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-17 16:49:55.000000000","tz":60},"subject":"virt: Add destroy_secrets kwarg to destroy and cleanup","message":"virt: Add destroy_secrets kwarg to destroy and cleanup\n\nThis change adds a simple optional kwarg to the virt driver signature of\ndestroy and cleanup to allow for callers to control when secrets should\nbe removed.\n\nNOTE(lyarwood): The xenapi driver cleanup and destroy methods are also\nextended to take the destroy_secrets kwarg. This driver was later\nremoved during Victoria thus the \u003c\u003d stable/ussuri specific change.\n\nChange-Id: I856268b371f7ba712b02189db3c927cd762a4dc3\n(cherry picked from commit 1cc52fd2f22ec37194519e473c88260bf90a3c8c)\n(cherry picked from commit f2ba67184d3801fdca4a33aa744a3471bcd21de2)\n(cherry picked from commit 813bee5a9df762a08c393b269b9b0d32096183d8)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/196973dfc8b0576ea1e62a9dcfdd1fd28ba7d686"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/196973dfc8b0576ea1e62a9dcfdd1fd28ba7d686"}]},"branch":"refs/heads/stable/ussuri"},"94dd3679f9a78f45edd11dd3d6bb2b3f4caec41b":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2021-06-17 17:20:03.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/62/796262/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/796262/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/796262/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/796262/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/796262/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/796262/3"}}},"commit":{"parents":[{"commit":"8e9859b95c537738d97ade41a8d09670de27ef8d","subject":"Reproduce bug 1897528","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8e9859b95c537738d97ade41a8d09670de27ef8d"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-02 14:33:40.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-17 17:19:42.000000000","tz":60},"subject":"virt: Add destroy_secrets kwarg to destroy and cleanup","message":"virt: Add destroy_secrets kwarg to destroy and cleanup\n\nThis change adds a simple optional kwarg to the virt driver signature of\ndestroy and cleanup to allow for callers to control when secrets should\nbe removed.\n\nNOTE(lyarwood): The xenapi driver cleanup and destroy methods are also\nextended to take the destroy_secrets kwarg. This driver was later\nremoved during Victoria thus the \u003c\u003d stable/ussuri specific change.\n\nChange-Id: I856268b371f7ba712b02189db3c927cd762a4dc3\n(cherry picked from commit 1cc52fd2f22ec37194519e473c88260bf90a3c8c)\n(cherry picked from commit f2ba67184d3801fdca4a33aa744a3471bcd21de2)\n(cherry picked from commit f805779363b9933386eee4222de15466c547ba38)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/94dd3679f9a78f45edd11dd3d6bb2b3f4caec41b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/94dd3679f9a78f45edd11dd3d6bb2b3f4caec41b"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}