)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d443080644f6eb3abdffe5cbb49b986df261434f","unresolved":true,"context_lines":[{"line_number":13,"context_line":"Deployers can workaround this by overriding allow_headers,"},{"line_number":14,"context_line":"but we should provide a better experience out of the box."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes: #1931908"},{"line_number":17,"context_line":"Change-Id: Idf4650f36952331f02d7512580c21451f3ee3b63"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b2cfbbb9_a89c186a","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":6},"updated":"2021-06-14 22:55:33.000000000","message":"Need this to be Closes-Bug to link this to launchpad to make it easier to get to the problem statement for this change","commit_id":"529d93d67d3112a9026fbe2390e9ccabd6b2d34e"}],"nova/middleware.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8e525a11cefd810e73b6be8affe441e1f72e044e","unresolved":true,"context_lines":[{"line_number":25,"context_line":"                       \u0027X-Service-Catalog\u0027,"},{"line_number":26,"context_line":"                       \u0027X-User-Id\u0027,"},{"line_number":27,"context_line":"                       \u0027X-Tenant-Id\u0027,"},{"line_number":28,"context_line":"                       \u0027X-OpenStack-Nova-API-Version\u0027],"},{"line_number":29,"context_line":"        expose_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":30,"context_line":"                        \u0027X-Openstack-Request-Id\u0027,"},{"line_number":31,"context_line":"                        \u0027X-Subject-Token\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"381f9092_3c928b23","line":28,"range":{"start_line":28,"start_character":53,"end_line":28,"end_character":54},"updated":"2021-06-15 00:41:08.000000000","message":"let\u0027s add new style microversion header also. Initially I thought we could add only new style header but that is supported from 2.27 microversion only so for deployment with \u003c2.27 we still need old style header too. \n\n\u0027OpenStack-API-Version\u0027","commit_id":"529d93d67d3112a9026fbe2390e9ccabd6b2d34e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8e525a11cefd810e73b6be8affe441e1f72e044e","unresolved":true,"context_lines":[{"line_number":29,"context_line":"        expose_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":30,"context_line":"                        \u0027X-Openstack-Request-Id\u0027,"},{"line_number":31,"context_line":"                        \u0027X-Subject-Token\u0027,"},{"line_number":32,"context_line":"                        \u0027X-Service-Token\u0027],"},{"line_number":33,"context_line":"        allow_methods\u003d[\u0027GET\u0027,"},{"line_number":34,"context_line":"                       \u0027PUT\u0027,"},{"line_number":35,"context_line":"                       \u0027POST\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e4f03e6b_adca3e1e","line":32,"range":{"start_line":32,"start_character":41,"end_line":32,"end_character":42},"updated":"2021-06-15 00:41:08.000000000","message":"we can add these new headers in expose_header too.","commit_id":"529d93d67d3112a9026fbe2390e9ccabd6b2d34e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3bdaeb680c5d0fd4a6579f4868a5bfa89b12aff1","unresolved":true,"context_lines":[{"line_number":32,"context_line":"                        \u0027X-Subject-Token\u0027,"},{"line_number":33,"context_line":"                        \u0027X-Service-Token\u0027,"},{"line_number":34,"context_line":"                        \u0027X-OpenStack-Nova-API-Version\u0027,"},{"line_number":35,"context_line":"                        \u0027OpenStack-API-Version\u0027],"},{"line_number":36,"context_line":"        allow_methods\u003d[\u0027GET\u0027,"},{"line_number":37,"context_line":"                       \u0027PUT\u0027,"},{"line_number":38,"context_line":"                       \u0027POST\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"8c315989_040b8270","line":35,"updated":"2021-06-16 02:24:12.000000000","message":"These are consistent with the API version request header names [1]:\n\n # Names of headers used by clients to request a specific version\n # of the REST API\n API_VERSION_REQUEST_HEADER \u003d \u0027OpenStack-API-Version\u0027\n LEGACY_API_VERSION_REQUEST_HEADER \u003d \u0027X-OpenStack-Nova-API-Version\u0027\n\n[1] https://github.com/openstack/nova/blob/7f83cbe9e2a0e95fc0b7bc10d3eee7528e27b943/nova/api/openstack/wsgi.py#L64-L67","commit_id":"b02a95a18b5da37db6d4f30a5dea07e2a4187245"}]}