)]}'
{"id":"openstack%2Fnova~796618","triplet_id":"openstack%2Fnova~stable%2Fussuri~I11131a3f90b8af85e7151b519fb26d225629c391","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1930734","attention_set":{},"removed_from_attention_set":{"10135":{"account":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"last_update":"2024-02-07 12:53:28.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I11131a3f90b8af85e7151b519fb26d225629c391","subject":"libvirt: Set driver_iommu when attaching virtio devices to SEV instance","status":"ABANDONED","created":"2021-06-16 09:44:34.000000000","updated":"2024-02-07 12:53:28.000000000","total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"116457dd4ce915a89a7b68b80f615f8c805a71a0","_number":796618,"virtual_id_number":796618,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-06-16 13:04:45.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2021-06-16 10:05:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-16 10:05:46.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2021-06-16 13:04:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-16 13:12:28.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-06-16 15:25:01.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2024-02-07 12:53:28.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"f43fe6608fb1930d1bcd87d55642a0c403e42d88","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-16 09:44:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"301cb440613ce3b7162f263573bc1f259a7a2274","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-16 09:53:44.000000000","message":"Topic set to bug/1930734","accounts_in_message":[],"_revision_number":1},{"id":"81379e68cff690ec69ddb220608326638fb28e2e","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-16 10:05:46.000000000","message":"Patch Set 1: Code-Review+1\n\n(6 comments)\n\nConflicts weren\u0027t as bad as I feared after reading the commit message. Good thing there aren\u0027t any functional tests here, eh? ;-)","accounts_in_message":[],"_revision_number":1},{"id":"9bbcc54e25e5c3366c3cfef846d99012f3b00034","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-16 13:04:45.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/d616fb486c3b4160b652a0d053bc538c : SUCCESS in 1h 13m 16s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/946c499f33804c64851e4e61bbd6172e : SUCCESS in 18m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7fadf7e009124cd4b6beb1435df559c8 : SUCCESS in 17m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c39b6fce1b33489493d564675b16d675 : FAILURE in 7m 51s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8ca4beee1c55438d8d1130001b559204 : SUCCESS in 14m 17s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/d0e2d5b11b384f46a087445806846ee3 : SUCCESS in 13m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0621902672ab490fac435979a36f3bc1 : SUCCESS in 13m 32s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/f33c8f0a6390429eb0c9265221c4112b : SUCCESS in 58m 59s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/d76aa3af9ed1414191cf53f1c991fd65 : SUCCESS in 1h 18m 07s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/ce96b8848b8a4f288f985cee4959ecad : FAILURE in 1h 25m 01s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/1363087783d24592bfd2378d4aa8c805 : SUCCESS in 54m 42s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/e4a3d7a45d20423d82da364a6cdf3d76 : FAILURE in 52m 20s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/7039521ae5b240088ba1b99ccb5c4626 : SUCCESS in 1h 25m 53s\n- nova-next https://zuul.opendev.org/t/openstack/build/31a764ddb9e1418bbc34f0400204d25c : SUCCESS in 1h 24m 49s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/1d0ae9fc5352478387c7c29beb6f1bfe : SUCCESS in 21m 19s\n- grenade https://zuul.opendev.org/t/openstack/build/b0970d44ff394795a96e50b86898b888 : SUCCESS in 1h 06m 56s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f406aca3323c4810a66a7e2c5d0c4876 : SUCCESS in 52m 52s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/62a8e51c65734291b642ef25a59f52ef : SUCCESS in 54m 05s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/d73d78f68e4e4b61964299339fd2e7cb : FAILURE in 27m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"126a29fe5a8970a381f2469077a5913528c044bf","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-16 13:12:28.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic finger://zuul-v3-executor.novalocal/11a908d1f3894873aba95542511c3c23 : POST_FAILURE in 2h 07m 46s\n- tempest-dsvm-full-bionic-py3 finger://zuul-v3-executor.novalocal/f7ef62436c9c479099569af315fcf004 : POST_FAILURE in 2h 12m 23s","accounts_in_message":[],"_revision_number":1},{"id":"4e582551341b1c9c609f33ddde52dade8815845e","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-06-16 15:25:01.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/796618/1/iscsi : SUCCESS in 2h 47m 27s","accounts_in_message":[],"_revision_number":1},{"id":"116457dd4ce915a89a7b68b80f615f8c805a71a0","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-02-07 12:53:28.000000000","message":"Abandoned\n\nstable/ussuri branch of openstack/nova transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4c38a3c2d5194dbddc94339f3992dc5b70a52556","revisions":{"4c38a3c2d5194dbddc94339f3992dc5b70a52556":{"kind":"REWORK","_number":1,"created":"2021-06-16 09:44:34.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/18/796618/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/18/796618/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/796618/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/796618/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/796618/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/18/796618/1"}}},"commit":{"parents":[{"commit":"ba6789e458f5da1e7b792866120128c609ca8537","subject":"Merge \"Update image_base_image_ref during rebuild.\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba6789e458f5da1e7b792866120128c609ca8537"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-03 15:37:45.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-16 09:44:05.000000000","tz":60},"subject":"libvirt: Set driver_iommu when attaching virtio devices to SEV instance","message":"libvirt: Set driver_iommu when attaching virtio devices to SEV instance\n\nAs called out in the original spec [1] virtio devices attached to a SEV\nenabled instance must have the iommu attribute enabled. This was done\nwithin the original implementation of the spec for all virtio devices\ndefined when initially spawning the instance but does not include volume\nand interfaces that are later hot plugged.\n\nThis change corrects this for both volumes and nics and in doing so\nslightly refactors the original designer code to make it usable in both\ncases.\n\n[1] https://specs.openstack.org/openstack/nova-specs/specs/train/implemented/amd-sev-libvirt-support.html#proposed-change\n\nNOTE(lyarwood): Conflicts caused by I5c84f3c9b4137c84c36bb4e755ffad9c0e9f8a2b\nand Ic509d3f342a49dbd53dceac9ddcfc838ec165d6d not being present in\nstable/ussuri.\n\nConflicts:\n  nova/tests/unit/virt/libvirt/test_driver.py\n  nova/virt/libvirt/driver.py\n  nova/virt/libvirt/migration.py\n\nCloses-Bug: #1930734\nChange-Id: I11131a3f90b8af85e7151b519fb26d225629c391\n(cherry picked from commit 4d8bf15fec15dc3416023e577e0f2c277c216506)\n(cherry picked from commit 5d65680095298764466af532381b81b604429426)\n(cherry picked from commit 4985667efced966d0a47ac9f8d31d73ae7409b0a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4c38a3c2d5194dbddc94339f3992dc5b70a52556"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4c38a3c2d5194dbddc94339f3992dc5b70a52556"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}