)]}'
{"id":"openstack%2Fnova~796642","triplet_id":"openstack%2Fnova~stable%2Ftrain~I11131a3f90b8af85e7151b519fb26d225629c391","project":"openstack/nova","branch":"stable/train","hashtags":[],"change_id":"I11131a3f90b8af85e7151b519fb26d225629c391","subject":"libvirt: Set driver_iommu when attaching virtio devices to SEV instance","status":"ABANDONED","created":"2021-06-16 12:28:19.000000000","updated":"2023-09-01 17:03:54.000000000","total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"08fbbd559f1161a502019ae574522ddee7928720","_number":796642,"virtual_id_number":796642,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-06-16 15:13:55.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2021-06-16 16:22:19.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-16 15:02:59.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-06-16 15:13:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-16 16:22:19.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2021-06-16 16:31:25.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"}],"messages":[{"id":"7e649d295717345302197922acab9434e778d294","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-16 12:28:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5953f87b24561640eb0ac3ade5fc93b3ff1f7c36","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-16 15:02:59.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 finger://zuul-v3-executor.novalocal/271d0315aa644e03a67d9eced18c4e91 : POST_FAILURE in 1h 46m 30s","accounts_in_message":[],"_revision_number":1},{"id":"4ad8f994a414af7ec77176a7b1beb89bc1e64a48","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-16 15:13:55.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/c73191d42b494e74a1b3a42f584059f3 : SUCCESS in 1h 11m 26s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9970180766a5461aa009c07c665fadc1 : SUCCESS in 17m 02s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e9f7d33bd68641ce8adda01fae2cf756 : SUCCESS in 16m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d693181261a14673a495ba4cc9745990 : FAILURE in 11m 54s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/08fb30a32e0d4d6ebd82a84af98db554 : SUCCESS in 16m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/781c59d2285c4da2a15536969b6e7cb2 : SUCCESS in 14m 21s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/90fc4fc9dd284d0ab0914c0a3089a23f : SUCCESS in 16m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5c3acf08ef5e47a988bb55802a7d9029 : SUCCESS in 10m 36s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/151e0d52dfd84b90a1b8d6a6059faba6 : FAILURE in 1h 08m 32s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/fe65e1d431204c229d9ce5db8827df47 : FAILURE in 1h 15m 10s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/1142b82fd40b4f6b98cd8204153dd089 : SUCCESS in 1h 02m 38s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/3117c9ffda404b5bad919fcde6723703 : FAILURE in 49m 54s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/b197334815e5435c8381a6ada4a4a9eb : FAILURE in 48m 59s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/fa3225122e804953b3e249139882c0e5 : SUCCESS in 53m 00s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/df95aea2aa8f42b8b75ca17c4a3e25a9 : SUCCESS in 1h 22m 35s\n- nova-next https://zuul.opendev.org/t/openstack/build/9508d17fae73480bb63f6b3ad22afc26 : SUCCESS in 1h 33m 37s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/b1beef071f184d4a9f1530e7276dacbd : SUCCESS in 22m 51s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/81859253c7344a81bf1b314ccf306768 : SUCCESS in 18m 32s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/b5dc68dca429480ca93ae8cb8254795f : SUCCESS in 1h 55m 05s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/cd3d8851e4594139bb24bd9efa19c8e3 : SUCCESS in 1h 03m 40s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/26633fde84f9437f80d2dc2dd8c9727d : SUCCESS in 52m 01s","accounts_in_message":[],"_revision_number":1},{"id":"65cf98cdef74e87fc16d05faf1768275e0add87f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-16 16:22:19.000000000","message":"Patch Set 1: Code-Review+1\n\n(5 comments)\n\nanother sensible backport. No issues from what I can see","accounts_in_message":[],"_revision_number":1},{"id":"a42650197bf29e58e7279b054eb1679ce210992f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-16 16:23:32.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"1e680d3a954007c5681b7f4c4801f145d6be4cb6","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-06-16 16:31:25.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/796642/1/iscsi : SUCCESS in 2h 47m 21s","accounts_in_message":[],"_revision_number":1},{"id":"08fbbd559f1161a502019ae574522ddee7928720","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-09-01 17:03:54.000000000","message":"Abandoned\n\nstable/train branch of nova projects\u0027 have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9587cad6a1d58045394c4e669a0949baf016d7ac","revisions":{"9587cad6a1d58045394c4e669a0949baf016d7ac":{"kind":"REWORK","_number":1,"created":"2021-06-16 12:28:19.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/42/796642/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/42/796642/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/42/796642/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/42/796642/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/42/796642/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/42/796642/1"}}},"commit":{"parents":[{"commit":"b095ed1cf3bc090fe74d98c9660ea6a40e6adab1","subject":"Merge \"Set migrate_data.vifs only when using multiple port bindings\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b095ed1cf3bc090fe74d98c9660ea6a40e6adab1"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-03 15:37:45.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-16 12:25:23.000000000","tz":60},"subject":"libvirt: Set driver_iommu when attaching virtio devices to SEV instance","message":"libvirt: Set driver_iommu when attaching virtio devices to SEV instance\n\nAs called out in the original spec [1] virtio devices attached to a SEV\nenabled instance must have the iommu attribute enabled. This was done\nwithin the original implementation of the spec for all virtio devices\ndefined when initially spawning the instance but does not include volume\nand interfaces that are later hot plugged.\n\nThis change corrects this for both volumes and nics and in doing so\nslightly refactors the original designer code to make it usable in both\ncases.\n\n[1] https://specs.openstack.org/openstack/nova-specs/specs/train/implemented/amd-sev-libvirt-support.html#proposed-change\n\nNOTE(lyarwood): Conflicts caused by I5c346e690148678a2f0dc63f4f516a944c3db8cd,\nI8e8035dcf508f5215bba9b7575c5c6abfe41da31 and\nI3448b89f58f3c3a85d15ee5a870c24b4b7f201df not being present in\nstable/train.\n\nConflicts:\n  nova/tests/unit/virt/libvirt/test_driver.py\n  nova/virt/libvirt/driver.py\n  nova/virt/libvirt/migration.py\n\nCloses-Bug: #1930734\nChange-Id: I11131a3f90b8af85e7151b519fb26d225629c391\n(cherry picked from commit 4d8bf15fec15dc3416023e577e0f2c277c216506)\n(cherry picked from commit 5d65680095298764466af532381b81b604429426)\n(cherry picked from commit 4985667efced966d0a47ac9f8d31d73ae7409b0a)\n(cherry picked from commit 4c38a3c2d5194dbddc94339f3992dc5b70a52556)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9587cad6a1d58045394c4e669a0949baf016d7ac"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9587cad6a1d58045394c4e669a0949baf016d7ac"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}