)]}'
{"id":"openstack%2Fnova~796935","triplet_id":"openstack%2Fnova~stable%2Ftrain~I856268b371f7ba712b02189db3c927cd762a4dc3","project":"openstack/nova","branch":"stable/train","topic":"bug/1905701","hashtags":[],"change_id":"I856268b371f7ba712b02189db3c927cd762a4dc3","subject":"virt: Add destroy_secrets kwarg to destroy and cleanup","status":"ABANDONED","created":"2021-06-17 18:19:07.000000000","updated":"2023-09-01 16:57:50.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cee26a12b56eccfa9848bb461e10a268e0600625","_number":796935,"virtual_id_number":796935,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-06-17 20:32:10.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-17 20:32:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-17 22:56:01.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-06-17 23:45:54.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"444d2de6cf8b50f4c42813e3953244477141cff2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-17 18:19:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0d9dab45791cf3a40af2040add6d7fbdfd078a06","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-17 20:32:10.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/7e52be2a50c744f39809a0837bec9a14 : SUCCESS in 1h 26m 49s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/18f332c10c79435aaff531ee16ca4034 : SUCCESS in 19m 38s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7241a198245b42a8ab95ba816973f47a : SUCCESS in 16m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2be9d731cce247b1b7c6c3422d2a10d8 : FAILURE in 11m 33s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/be2f03ce1caa43839c21de115864487d : SUCCESS in 17m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c00998bd97ce4c28adee8a6ecf8dbc7a : SUCCESS in 13m 32s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/103871af6830460db628aca4953db5cb : SUCCESS in 17m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a7658f31c74440e0a1eab045f2192201 : SUCCESS in 10m 59s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/4e1f80523e284f83ab33f2a55fec0b1c : SUCCESS in 1h 03m 08s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/585814e4d5aa4623b7194689f61380ac : SUCCESS in 1h 15m 08s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/0f495f424a9c45de86c20f86a91e3eea : SUCCESS in 1h 09m 58s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/fbaef494998b4482b1a6a05125426fb9 : SUCCESS in 1h 08m 05s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/63703a454624440d8abf4ffd4f322dbf : SUCCESS in 47m 36s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/3204919f22d848febc949ce31c99fefc : FAILURE in 1h 04m 12s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/fbaa62ec1b944b119bf4725c5687627c : SUCCESS in 1h 16m 11s\n- nova-next https://zuul.opendev.org/t/openstack/build/bdf0948d608747c7b1d4458596b3f827 : SUCCESS in 1h 08m 11s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/bf4341880c26424ca6dcabb5b67edfd7 : SUCCESS in 19m 23s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/5b3372f245054e8f849d845c877cee9e : SUCCESS in 16m 31s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/bd643a3afc364eb384b27c15a3f8f859 : SUCCESS in 2h 08m 35s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/3a34597828b142fd8910ce86cb835a24 : SUCCESS in 57m 02s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/0c225c8a87654858ad1f0421638d31ab : SUCCESS in 52m 56s","accounts_in_message":[],"_revision_number":1},{"id":"bdef54a127fe5ae2c7afaa01e987c1fcafc1bf87","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-06-17 22:56:01.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/796935/1/iscsi : SUCCESS in 2h 50m 06s","accounts_in_message":[],"_revision_number":1},{"id":"a1040badf78cfb84f2789c49d8f118630fbe397e","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-17 23:45:54.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 finger://zuul-v3-executor.novalocal/6b2abe97363b4478bf8473a3c74e6004 : POST_FAILURE in 1h 42m 39s","accounts_in_message":[],"_revision_number":1},{"id":"27fad8b6e5a9d9b43ccd7e1074d7cb9ca09f211b","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-08-16 17:16:10.000000000","message":"Topic set to bug/1905701","accounts_in_message":[],"_revision_number":1},{"id":"cee26a12b56eccfa9848bb461e10a268e0600625","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-09-01 16:57:50.000000000","message":"Abandoned\n\nstable/train branch of nova projects\u0027 have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2944675d63a796de8c60efdddfe55dfb4912451e","revisions":{"2944675d63a796de8c60efdddfe55dfb4912451e":{"kind":"REWORK","_number":1,"created":"2021-06-17 18:19:07.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/35/796935/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/35/796935/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/35/796935/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/35/796935/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/35/796935/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/35/796935/1"}}},"commit":{"parents":[{"commit":"b095ed1cf3bc090fe74d98c9660ea6a40e6adab1","subject":"Merge \"Set migrate_data.vifs only when using multiple port bindings\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b095ed1cf3bc090fe74d98c9660ea6a40e6adab1"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-02 14:33:40.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-17 17:21:38.000000000","tz":60},"subject":"virt: Add destroy_secrets kwarg to destroy and cleanup","message":"virt: Add destroy_secrets kwarg to destroy and cleanup\n\nThis change adds a simple optional kwarg to the virt driver signature of\ndestroy and cleanup to allow for callers to control when secrets should\nbe removed.\n\nNOTE(lyarwood): Conflict as Ia5892e1d2cb7c7685e104466f83df7bb00b168c0\nisn\u0027t present on stable/train.\n\nConflicts:\n  nova/virt/fake.py\n\nChange-Id: I856268b371f7ba712b02189db3c927cd762a4dc3\n(cherry picked from commit 1cc52fd2f22ec37194519e473c88260bf90a3c8c)\n(cherry picked from commit f2ba67184d3801fdca4a33aa744a3471bcd21de2)\n(cherry picked from commit f805779363b9933386eee4222de15466c547ba38)\n(cherry picked from commit 94dd3679f9a78f45edd11dd3d6bb2b3f4caec41b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2944675d63a796de8c60efdddfe55dfb4912451e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2944675d63a796de8c60efdddfe55dfb4912451e"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}