)]}'
{"id":"openstack%2Fnova~796939","triplet_id":"openstack%2Fnova~stable%2Ftrain~I3d1b21ba6eb3f5eb728693197c24b4b315eef821","project":"openstack/nova","branch":"stable/train","topic":"bug/1905701","hashtags":[],"change_id":"I3d1b21ba6eb3f5eb728693197c24b4b315eef821","subject":"libvirt: Do not destroy volume secrets during _hard_reboot","status":"ABANDONED","created":"2021-06-17 18:19:07.000000000","updated":"2023-09-01 16:57:58.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"faf79f3a4fac9cbf8fc7783297e582ba3f0d8068","_number":796939,"virtual_id_number":796939,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-06-17 20:34:00.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-17 20:34:00.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-18 00:19:48.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-06-18 01:22:49.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"c4fe33708db404ee9f1c96c899c110ec2d5d0717","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-17 18:19:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ce11aafc9e872aa18ad7b002b84cc002c2b36f6c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-17 20:34:00.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/ba6a011ae53c43acae2a99721c63fa2b : SUCCESS in 1h 13m 21s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d833548a90da4b008ee15ae69d7cf85a : SUCCESS in 18m 07s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/45f603244bef4e15807fc5ae9af1f774 : SUCCESS in 14m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d342535eb4244c4097eb63011df78a93 : FAILURE in 13m 08s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/b1be9115d148413ea2c8bab1b81c21bb : SUCCESS in 12m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a5321bf8b5764eedb22debaf7e1ff4b9 : SUCCESS in 11m 37s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/30affbdfe4874043bb03724b8c554faf : SUCCESS in 15m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b8395ef3198d4d6998001cf4ba4a813c : SUCCESS in 9m 43s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/02d6a3e82d3e462aafca80f013563731 : SUCCESS in 1h 09m 15s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/74f826cc8dd94a9485c1d45b1ade1229 : SUCCESS in 1h 13m 32s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/e7ea6a0930b144eda170522b7f2633aa : SUCCESS in 53m 26s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/9d96239305fc4bd3a3416f28d0401d4d : SUCCESS in 1h 02m 13s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/44481eb1a17d497dad41d613aab6b3d2 : SUCCESS in 48m 41s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/c7062e2b61664ffd99dc1728b78a1835 : SUCCESS in 44m 12s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/6b2e618fc6a745af99f7888a06f915eb : SUCCESS in 1h 17m 43s\n- nova-next https://zuul.opendev.org/t/openstack/build/9fdc74152afd4af799e672847daab4d7 : SUCCESS in 59m 36s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/3d24e748ff734ae08ff6da783f80b1d7 : SUCCESS in 19m 10s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/e93b9aa107a34b78b5acfb9f9f727da3 : SUCCESS in 19m 35s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/b1acfe312fb841419f651f402355affc : SUCCESS in 2h 07m 28s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/41917e05eee84674a11b7bde0375eca9 : SUCCESS in 53m 04s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2a66c6a4105b4a6181b16c8bafce9cdf : SUCCESS in 57m 40s","accounts_in_message":[],"_revision_number":1},{"id":"e603973a20031f519fa168630d1890f91da6fcda","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-06-18 00:19:48.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/796939/1/iscsi : SUCCESS in 2h 37m 06s","accounts_in_message":[],"_revision_number":1},{"id":"f71205730601cce253e5a902b5808cecea809361","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-18 01:22:49.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 finger://zuul-v3-executor.novalocal/25aa66e556044b4facfce97d8fc862f9 : POST_FAILURE in 1h 44m 19s","accounts_in_message":[],"_revision_number":1},{"id":"edb242c40138e29c1f3104b4e813389a8269bdb1","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-08-16 17:16:18.000000000","message":"Topic set to bug/1905701","accounts_in_message":[],"_revision_number":1},{"id":"faf79f3a4fac9cbf8fc7783297e582ba3f0d8068","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-09-01 16:57:58.000000000","message":"Abandoned\n\nstable/train branch of nova projects\u0027 have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"780f5e8b3df203795b73d7fb6d4c5092f596399e","revisions":{"780f5e8b3df203795b73d7fb6d4c5092f596399e":{"kind":"REWORK","_number":1,"created":"2021-06-17 18:19:07.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/39/796939/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/39/796939/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/39/796939/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/39/796939/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/39/796939/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/39/796939/1"}}},"commit":{"parents":[{"commit":"fc87d7eb7cd9f257fbcd62d5c7aff110dbcc656e","subject":"Trival Change: Remove redundant code in instance delete","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fc87d7eb7cd9f257fbcd62d5c7aff110dbcc656e"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-05-27 15:47:26.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-17 18:15:24.000000000","tz":60},"subject":"libvirt: Do not destroy volume secrets during _hard_reboot","message":"libvirt: Do not destroy volume secrets during _hard_reboot\n\nIa2007bc63ef09931ea0197cef29d6a5614ed821a unfortunately missed that\nresume_state_on_host_boot calls down into _hard_reboot always removing\nvolume secrets rendering that change useless.\n\nThis change seeks to address this by using the destroy_secrets kwarg\nintroduced by I856268b371f7ba712b02189db3c927cd762a4dc3 within the\n_hard_reboot method of the libvirt driver to ensure secrets are not\nremoved during a hard reboot.\n\nThis resolves the original issue in bug #1905701 *and* allows admins to\nhard reboot a users instance when that instance has encrypted volumes\nattached with secrets stored in Barbican. This latter use case being\nsomething we can easily test within tempest unlike the compute reboot in\nbug #1905701.\n\nThis change is kept small as it should ideally be backported alongside\nIa2007bc63ef09931ea0197cef29d6a5614ed821a to stable/queens. Follow up\nchanges on master will improve formatting, doc text and introduce\nfunctional tests to further validate this new behaviour of hard reboot\nwithin the libvirt driver.\n\nNOTE(lyarwood): Conflict as I41b7c1653c6a887ee4b08e588c5d422409aebfba\nisn\u0027t present on stable/train.\n\nConflicts:\n  nova/tests/unit/virt/libvirt/test_driver.py\n\nCloses-Bug: #1905701\nChange-Id: I3d1b21ba6eb3f5eb728693197c24b4b315eef821\n(cherry picked from commit 26d65fc882e42b824409dff87ff026dee1debe20)\n(cherry picked from commit 9cac2a8822ab81b7a0aa1f5b4472b306e4b68f93)\n(cherry picked from commit ac3fc65f5ee62dd60525fce3e8b881e1389cca43)\n(cherry picked from commit 7a69f9800b97606cd05068d3ad4fc6d0061a7a55)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/780f5e8b3df203795b73d7fb6d4c5092f596399e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/780f5e8b3df203795b73d7fb6d4c5092f596399e"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}