)]}'
{"nova/objects/migrate_data.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"081ccd6b8a3a7261d4b1715cf3901efd561e4c8d","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    def supports_os_vif_delegation(self, supported):"},{"line_number":89,"context_line":"        # we can\u0027t simply set the attribute using dict notation since the"},{"line_number":90,"context_line":"        # getter returns a copy of the data, not the data itself"},{"line_number":91,"context_line":"        self.profile \u003d dict("},{"line_number":92,"context_line":"            self.profile or {}, **{OS_VIF_DELEGATION: supported})"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def get_dest_vif(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"77acb458_882afbec","line":91,"updated":"2021-06-21 09:26:29.000000000","message":"another way of doing this would have been to use the internal attribute (profile_json) directly here instead of calling the another \u0027profile\u0027 priority.\n\n  _p \u003d jsonutils.loads(self.profile_json)\n  _p[OS_VIF_DELEGATION] \u003d supported\n  self.profile_json \u003d jsonutils.dumps(_p)\n\nHere, we need to understand why we need to recreate the dict but OK.","commit_id":"99cf5292c782828ea33a3448ae0e7da028d5d176"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"718cfd7635d98bccf81184776546c541ab83757f","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    def supports_os_vif_delegation(self, supported):"},{"line_number":89,"context_line":"        # we can\u0027t simply set the attribute using dict notation since the"},{"line_number":90,"context_line":"        # getter returns a copy of the data, not the data itself"},{"line_number":91,"context_line":"        self.profile \u003d dict("},{"line_number":92,"context_line":"            self.profile or {}, **{OS_VIF_DELEGATION: supported})"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def get_dest_vif(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9336f9f0_399ed925","line":91,"in_reply_to":"77acb458_882afbec","updated":"2021-06-21 09:27:39.000000000","message":"s/\u0027profile\u0027 priority/\u0027profile\u0027 property/ of course","commit_id":"99cf5292c782828ea33a3448ae0e7da028d5d176"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fe4c368b0ea274b877091965efa25d5e0dfddf6d","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    def supports_os_vif_delegation(self, supported):"},{"line_number":89,"context_line":"        # we can\u0027t simply set the attribute using dict notation since the"},{"line_number":90,"context_line":"        # getter returns a copy of the data, not the data itself"},{"line_number":91,"context_line":"        self.profile \u003d dict("},{"line_number":92,"context_line":"            self.profile or {}, **{OS_VIF_DELEGATION: supported})"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def get_dest_vif(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f3213b63_f695da8b","line":91,"in_reply_to":"9336f9f0_399ed925","updated":"2021-06-21 10:55:40.000000000","message":"yes that is what i orginally suggested on irc.\n\ndata \u003d jsonutils.loads(self.profile_json)\ndata[OS_VIF_DELEGATION]\u003dsupported\nself.profile_json \u003d jsonutils.dumps(data)\n\nbut this should also workand its slightly shorter.","commit_id":"99cf5292c782828ea33a3448ae0e7da028d5d176"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b48e5a60b9d8478a26796dcf361d957c7a1776e7","unresolved":true,"context_lines":[{"line_number":10907,"context_line":"    @mock.patch.object("},{"line_number":10908,"context_line":"        libvirt_driver.LibvirtDriver,"},{"line_number":10909,"context_line":"        \u0027_create_shared_storage_test_file\u0027,"},{"line_number":10910,"context_line":"        return_value\u003d\u0027fake\u0027)"},{"line_number":10911,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver, \u0027_compare_cpu\u0027)"},{"line_number":10912,"context_line":"    def test_check_can_live_migrate_dest_create_dummy_vif("},{"line_number":10913,"context_line":"        self, mock_cpu, mock_test_file,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3dcc30a0_1e18909d","line":10910,"range":{"start_line":10910,"start_character":8,"end_line":10910,"end_character":27},"updated":"2021-06-21 09:02:35.000000000","message":"nit - can\u0027t this just be new\u003dmock.Mock(return_value\u003d\u0027fake\u0027)?","commit_id":"99cf5292c782828ea33a3448ae0e7da028d5d176"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"928b7e270e70e45647719d0ca243ca39bc3da142","unresolved":false,"context_lines":[{"line_number":10907,"context_line":"    @mock.patch.object("},{"line_number":10908,"context_line":"        libvirt_driver.LibvirtDriver,"},{"line_number":10909,"context_line":"        \u0027_create_shared_storage_test_file\u0027,"},{"line_number":10910,"context_line":"        return_value\u003d\u0027fake\u0027)"},{"line_number":10911,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver, \u0027_compare_cpu\u0027)"},{"line_number":10912,"context_line":"    def test_check_can_live_migrate_dest_create_dummy_vif("},{"line_number":10913,"context_line":"        self, mock_cpu, mock_test_file,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7492a76_b6db316a","line":10910,"range":{"start_line":10910,"start_character":8,"end_line":10910,"end_character":27},"in_reply_to":"3dcc30a0_1e18909d","updated":"2021-06-21 10:53:49.000000000","message":"Ah, it could. This is copy-paste from earlier tests above which is why I didn\u0027t spot it. I\u0027ve already squashed this into a preemptive backport though so I\u0027d rather keep this as-is now to preserve my sanity 😄","commit_id":"99cf5292c782828ea33a3448ae0e7da028d5d176"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fe4c368b0ea274b877091965efa25d5e0dfddf6d","unresolved":true,"context_lines":[{"line_number":10907,"context_line":"    @mock.patch.object("},{"line_number":10908,"context_line":"        libvirt_driver.LibvirtDriver,"},{"line_number":10909,"context_line":"        \u0027_create_shared_storage_test_file\u0027,"},{"line_number":10910,"context_line":"        return_value\u003d\u0027fake\u0027)"},{"line_number":10911,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver, \u0027_compare_cpu\u0027)"},{"line_number":10912,"context_line":"    def test_check_can_live_migrate_dest_create_dummy_vif("},{"line_number":10913,"context_line":"        self, mock_cpu, mock_test_file,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2d2b2788_bfc68433","line":10910,"range":{"start_line":10910,"start_character":8,"end_line":10910,"end_character":27},"in_reply_to":"3dcc30a0_1e18909d","updated":"2021-06-21 10:55:40.000000000","message":"since they are not used firestly yes but i think this is ok.\nreally that is just avoiding extra parmater.\n\nits nice to d othat but not required but i guess thats why you listed it as a nit.","commit_id":"99cf5292c782828ea33a3448ae0e7da028d5d176"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b48e5a60b9d8478a26796dcf361d957c7a1776e7","unresolved":true,"context_lines":[{"line_number":10908,"context_line":"        libvirt_driver.LibvirtDriver,"},{"line_number":10909,"context_line":"        \u0027_create_shared_storage_test_file\u0027,"},{"line_number":10910,"context_line":"        return_value\u003d\u0027fake\u0027)"},{"line_number":10911,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver, \u0027_compare_cpu\u0027)"},{"line_number":10912,"context_line":"    def test_check_can_live_migrate_dest_create_dummy_vif("},{"line_number":10913,"context_line":"        self, mock_cpu, mock_test_file,"},{"line_number":10914,"context_line":"    ):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5c942c_50c5db18","line":10911,"range":{"start_line":10911,"start_character":4,"end_line":10911,"end_character":68},"updated":"2021-06-21 09:02:35.000000000","message":"nit - Ditto.","commit_id":"99cf5292c782828ea33a3448ae0e7da028d5d176"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"928b7e270e70e45647719d0ca243ca39bc3da142","unresolved":false,"context_lines":[{"line_number":10908,"context_line":"        libvirt_driver.LibvirtDriver,"},{"line_number":10909,"context_line":"        \u0027_create_shared_storage_test_file\u0027,"},{"line_number":10910,"context_line":"        return_value\u003d\u0027fake\u0027)"},{"line_number":10911,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver, \u0027_compare_cpu\u0027)"},{"line_number":10912,"context_line":"    def test_check_can_live_migrate_dest_create_dummy_vif("},{"line_number":10913,"context_line":"        self, mock_cpu, mock_test_file,"},{"line_number":10914,"context_line":"    ):"}],"source_content_type":"text/x-python","patch_set":1,"id":"92441a4e_36a2748f","line":10911,"range":{"start_line":10911,"start_character":4,"end_line":10911,"end_character":68},"in_reply_to":"5a5c942c_50c5db18","updated":"2021-06-21 10:53:49.000000000","message":"As above","commit_id":"99cf5292c782828ea33a3448ae0e7da028d5d176"}]}