)]}'
{"id":"openstack%2Fnova~797144","triplet_id":"openstack%2Fnova~stable%2Fvictoria~I11fb5d3ada7f27b39c183157ea73c8b72b4e672e","project":"openstack/nova","branch":"stable/victoria","topic":"bug/1815989","hashtags":[],"change_id":"I11fb5d3ada7f27b39c183157ea73c8b72b4e672e","subject":"libvirt: Delegate OVS plug to os-vif","status":"ABANDONED","created":"2021-06-18 17:38:56.000000000","updated":"2022-10-05 15:47:45.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d68eef9ca26d60e1b31d5c36332239b5a7bef5ff","_number":797144,"virtual_id_number":797144,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-06-18 19:45:55.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":-1,"date":"2021-06-18 17:40:01.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-18 19:45:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-18 20:04:53.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-06-18 21:34:41.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"3383d36e7501049da99b17e22c0910efdba6c388","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-18 17:38:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0d50850f43df4c62f788dc74aa77073e9c0b325a","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-18 17:40:01.000000000","message":"Patch Set 1: Workflow-1\n\nThis should wait until the stable/wallaby change has landed. Just stacking it up to see how bad the test failures are","accounts_in_message":[],"_revision_number":1},{"id":"c7e5cf1a7638066146f473032056189d6734bacc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-18 19:45:55.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/c3ae31bf6cf44a7ba7b46e5e4b267996 : SUCCESS in 1h 28m 19s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/22aae256c4354a15b5866ef936125d0d : SUCCESS in 18m 28s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4b3f157d9ec24438ac3195538b2716db : SUCCESS in 16m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2c808539140d47feaee55cc15f274ac2 : FAILURE in 9m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/076f0e7a1c48478da7a5ed22a5b2e974 : SUCCESS in 14m 15s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2127432755114ed78ab6a5401ca1a642 : SUCCESS in 14m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5346ab0ea22a4edda5f8ec19f47ca4dd : SUCCESS in 11m 50s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a683ac56c3d7488b9b1d987f19609640 : SUCCESS in 19m 32s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/003f2f2b33734e928c8f79f38de65565 : SUCCESS in 1h 30m 35s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/f3cfec747e3a4618a5de9ecd3cb0baf6 : SUCCESS in 1h 35m 09s\n- neutron-tempest-linuxbridge https://zuul.opendev.org/t/openstack/build/8fa4626e1a134e488306286b4415e75b : SUCCESS in 1h 09m 02s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/479cc8dfd8f547d2bafbcf33cafbfbd8 : FAILURE in 57m 03s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/1e7c1b10dac74262a2749db2c80a89d3 : SUCCESS in 1h 11m 46s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/a55ba012f01348c7a30e6f27d22249e5 : SUCCESS in 1h 24m 09s\n- nova-next https://zuul.opendev.org/t/openstack/build/1d5e10f02cfb49b09ada7fc686c68723 : SUCCESS in 2h 00m 58s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/357bc8646578420fb7d8284c790b3886 : SUCCESS in 18m 33s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/5b3b0ac7e0bf4f959e5594888ca1906c : FAILURE in 1h 17m 05s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/743b05fdea54461e86f5aad50bb902ce : SUCCESS in 50m 27s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/dbd63e068d0a486abf72d733d67eeb9e : SUCCESS in 59m 44s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/4e584634af5d49bebadc3590f5f35d87 : SUCCESS in 32m 48s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/768b0723d45f43b3a5b2c0dfb0a1626f : SUCCESS in 40m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"907d1e0b8cb59111b8f3819e2e26fee45b1a603f","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-06-18 20:04:53.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/797144/1/iscsi : SUCCESS in 2h 24m 50s","accounts_in_message":[],"_revision_number":1},{"id":"be7ba929efc58a072f4234b04a8efd2f83b4fe42","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-18 21:34:41.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/995c9071fad34db4a93bdbeb95eec558 : POST_FAILURE in 1h 58m 29s","accounts_in_message":[],"_revision_number":1},{"id":"30e07245afd6c6cbd862d9fcdfdeae39b77f02ab","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-21 11:04:54.000000000","message":"Patch Set 1:\n\nFailures look like unrelated volume issues. Both nova-live-migration and nova-grenade-multinode appear to be working as expected.\n\nnova-live-migration [1]:\n\n  Jun 18 18:25:34.701857 ...: DEBUG nova.virt.libvirt.migration [-] [instance: ad7b53f9-4e35-4e38-9016-cae09227e56c] Updating guest XML with vif config: \u003cinterface type\u003d\"ethernet\"\u003e\n  Jun 18 18:25:34.701857 ...:   \u003cmac address\u003d\"fa:16:3e:d2:f9:f8\"/\u003e\n  Jun 18 18:25:34.701857 ...:   \u003cmodel type\u003d\"virtio\"/\u003e\n  Jun 18 18:25:34.701857 ...:   \u003cdriver name\u003d\"qemu\"/\u003e\n  Jun 18 18:25:34.701857 ...:   \u003cmtu size\u003d\"1400\"/\u003e\n  Jun 18 18:25:34.701857 ...:   \u003ctarget dev\u003d\"tap34abe86a-19\"/\u003e\n  Jun 18 18:25:34.701857 ...: \u003c/interface\u003e\n  Jun 18 18:25:34.701857 ...:  {{(pid\u003d52918) _update_vif_xml /opt/stack/nova/nova/virt/libvirt/migration.py:373}}\n  Jun 18 18:25:34.702362 ...: DEBUG nova.virt.libvirt.driver [-] [instance: ad7b53f9-4e35-4e38-9016-cae09227e56c] About to invoke the migrate API {{(pid\u003d52918) _live_migration_operation /opt/stack/nova/nova/virt/libvirt/driver.py:9216}}\n\nnova-grenade-multinode [2]:\n\n  Jun 18 18:39:46.915858 ...: DEBUG nova.virt.libvirt.migration [-] [instance: f2dc4f94-b175-4db4-b385-07f3d5b3a1e7] Updating guest XML with vif config: \u003cinterface type\u003d\"bridge\"\u003e\n  Jun 18 18:39:46.915858 ...:   \u003cmac address\u003d\"fa:16:3e:e0:55:e8\"/\u003e\n  Jun 18 18:39:46.915858 ...:   \u003cmodel type\u003d\"virtio\"/\u003e\n  Jun 18 18:39:46.915858 ...:   \u003cdriver name\u003d\"qemu\"/\u003e\n  Jun 18 18:39:46.915858 ...:   \u003csource bridge\u003d\"br-int\"/\u003e\n  Jun 18 18:39:46.915858 ...:   \u003cmtu size\u003d\"1400\"/\u003e\n  Jun 18 18:39:46.915858 ...:   \u003ctarget dev\u003d\"tap83aa99f8-a6\"/\u003e\n  Jun 18 18:39:46.915858 ...:   \u003cvirtualport type\u003d\"openvswitch\"\u003e\n  Jun 18 18:39:46.915858 ...:     \u003cparameters interfaceid\u003d\"83aa99f8-a605-4e6c-a23e-1922e814f640\"/\u003e\n  Jun 18 18:39:46.915858 ...:   \u003c/virtualport\u003e\n  Jun 18 18:39:46.915858 ...: \u003c/interface\u003e\n  Jun 18 18:39:46.915858 ...:  {{(pid\u003d15569) _update_vif_xml /opt/stack/old/nova/nova/virt/libvirt/migration.py:401}}\n  Jun 18 18:39:46.916647 ...: DEBUG nova.virt.libvirt.driver [-] [instance: f2dc4f94-b175-4db4-b385-07f3d5b3a1e7] About to invoke the migrate API {{(pid\u003d15569) _live_migration_operation /opt/stack/old/nova/nova/virt/libvirt/driver.py:9045}}\n\n[1] https://zuul.opendev.org/t/openstack/build/479cc8dfd8f547d2bafbcf33cafbfbd8/log/compute1/logs/screen-n-cpu.txt#8135\n[2] https://zuul.opendev.org/t/openstack/build/5b3b0ac7e0bf4f959e5594888ca1906c/log/compute1/logs/screen-n-cpu.txt#9340","accounts_in_message":[],"_revision_number":1},{"id":"d68eef9ca26d60e1b31d5c36332239b5a7bef5ff","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-10-05 15:47:45.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"749ce863886329364305edfee375a2b5b44de187","revisions":{"749ce863886329364305edfee375a2b5b44de187":{"kind":"REWORK","_number":1,"created":"2021-06-18 17:38:56.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/44/797144/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/44/797144/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/44/797144/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/44/797144/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/44/797144/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/44/797144/1"}}},"commit":{"parents":[{"commit":"78a63c264475c00813d58ada14be248b089c1f2c","subject":"Merge \"Ignore PCI devices with 32bit domain\" into stable/victoria","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/78a63c264475c00813d58ada14be248b089c1f2c"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-04-30 11:51:35.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-06-18 17:37:34.000000000","tz":60},"subject":"libvirt: Delegate OVS plug to os-vif","message":"libvirt: Delegate OVS plug to os-vif\n\nos-vif 1.15.0 added the ability to create an OVS port during plugging\nby specifying the \u0027create_port\u0027 attribute in the \u0027port_profile\u0027 field.\nBy delegating port creation to os-vif, we can rely on it\u0027s \u0027isolate_vif\u0027\nconfig option [1] that will temporarily configure the VLAN to 4095\n(0xfff), which is reserved for implementation use [2] and is used by\nneutron to as a dead VLAN [3]. By doing this, we ensure VIFs are plugged\nsecurely, preventing guests from accessing other tenants\u0027 networks\nbefore the neutron OVS agent can wire up the port.\n\nThis change requires a little dance as part of the live migration flow.\nSince we can\u0027t be certain the destination host has a version of os-vif\nthat supports this feature, we need to use a sentinel to indicate when\nit does. Typically we would do so with a field in\n\u0027LibvirtLiveMigrateData\u0027, such as the \u0027src_supports_numa_live_migration\u0027\nand \u0027dst_supports_numa_live_migration\u0027 fields used to indicate support\nfor NUMA-aware live migration. However, doing this prevents us\nbackporting this important fix since o.vo changes are not backportable.\nInstead, we (somewhat evilly) rely on the free-form nature of the\n\u0027VIFMigrateData.profile_json\u0027 string field, which stores JSON blobs and\nis included in \u0027LibvirtLiveMigrateData\u0027 via the \u0027vifs\u0027 attribute, to\ntransport this sentinel. This is a hack but is necessary to work around\nthe lack of a free-form \"capabilities\" style dict that would allow us do\nbackportable fixes to live migration features.\n\nNote that this change has the knock on effect of modifying the XML\ngenerated for OVS ports: when hybrid plug is false will now be of type\n\u0027ethernet\u0027 rather than \u0027bridge\u0027 as before. This explains the larger than\nexpected test damage but should not affect users.\n\nConflicts:\n  nova/tests/unit/virt/libvirt/fakelibvirt.py\n  nova/tests/unit/virt/libvirt/test_driver.py\n  nova/tests/unit/virt/libvirt/test_vif.py\n  nova/virt/libvirt/driver.py\n\nChanges:\n  nova/tests/unit/virt/libvirt/test_driver.py\n\nNOTE(stephenfin): Conflicts in the fake libvirt fixture are due to the\nabsence of I7f2b6330decb92e2838aa7cee47fb228f00f47da (\"Replace blind\nretry with libvirt event waiting in detach\"), which significantly beefed\nup this fixture. We use the beefed up version here since it works and is\narguably more correct that what we had previously. The conflicts in the\nother files are trivial conflicts caused by the removal of \u0027six\u0027 imports\nin changes I779bd1446dc1f070fa5100ccccda7881fa508d79 (\"Remove\nsix.text_type (2/2)\") and I23bb9e539d08f5c6202909054c2dd49b6c7a7a0e\n(\"Remove six.text_type (1/2)\") on stable/wallaby. The additional change\nis a trivial addition of a mock to two tests that no longer existed on\nstable/wallaby due to change I952f36fe201aad37297c7630ed562b579c90f64a\n(\"libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION\").\n\n[1] https://opendev.org/openstack/os-vif/src/tag/2.4.0/vif_plug_ovs/ovs.py#L90-L93\n[2] https://en.wikipedia.org/wiki/IEEE_802.1Q#Frame_format\n[3] https://answers.launchpad.net/neutron/+question/231806\n\nChange-Id: I11fb5d3ada7f27b39c183157ea73c8b72b4e672e\nDepends-On: Id12486b3127ab4ac8ad9ef2b3641da1b79a25a50\nCloses-Bug: #1734320\nCloses-Bug: #1815989\n(cherry picked from commit a62dd42c0dbb6b2ab128e558e127d76962738446)\n(cherry picked from commit d16ded1f5bbfa27d96c36978c6cedd0c050ab106)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/749ce863886329364305edfee375a2b5b44de187"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/749ce863886329364305edfee375a2b5b44de187"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[]}