)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a13912242356e9ec5413dde821dfafbd4f70deb6","unresolved":true,"context_lines":[{"line_number":7497,"context_line":"        # attached on the dest so we can skip this."},{"line_number":7498,"context_line":"        if bdm.connection_info is None:"},{"line_number":7499,"context_line":"            return"},{"line_number":7500,"context_line":""},{"line_number":7501,"context_line":"        driver_bdm \u003d driver_block_device.convert_volume(bdm)"},{"line_number":7502,"context_line":"        driver_bdm.driver_detach(context, instance,"},{"line_number":7503,"context_line":"                                 self.volume_api, self.driver)"}],"source_content_type":"text/x-python","patch_set":1,"id":"409630b5_124d3f46","line":7500,"updated":"2021-06-23 17:33:37.000000000","message":"ok so this is our early out in the case that we did not even get as far as updating the bdms in pre live migrate at dest.\n\nthere is one other thng that we could maybe do to make this cleaner\nwe could introduce a property on the bdm object that would tell you if the bdm is in a detachable state.\n\nso this would be \nif not bdm.detachable:\n  return\n\nwhere detachable is\n\n@property\ndef detachable(self):\n return self.connection_info is not None\n\n\nim not sure that is require given the code comment but if we would be check this else where i think it would be more self documenting \n\njust a tought i think this is fine as is again thanks to the code comment.","commit_id":"d8975b80433373da71bc0d506dfd64bd62e3da69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a13912242356e9ec5413dde821dfafbd4f70deb6","unresolved":true,"context_lines":[{"line_number":8420,"context_line":"        for bdm in bdms:"},{"line_number":8421,"context_line":"            if bdm.is_volume:"},{"line_number":8422,"context_line":"                bdm.connection_info \u003d None"},{"line_number":8423,"context_line":"                bdm.save()"},{"line_number":8424,"context_line":""},{"line_number":8425,"context_line":"        migrate_data \u003d self._do_pre_live_migration_from_source("},{"line_number":8426,"context_line":"            context, dest, instance, block_migration, migration, migrate_data,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2ec65caf_09155d05","line":8423,"updated":"2021-06-23 17:33:37.000000000","message":"and here you are nulling it out.","commit_id":"d8975b80433373da71bc0d506dfd64bd62e3da69"}]}