)]}'
{"nova/tests/image/test_glance.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ef5984b4914a2d32d90ba4bbece5e3df745ce96","unresolved":false,"context_lines":[{"line_number":791,"context_line":"        # We emulate warlock validation that throws an AttributeError"},{"line_number":792,"context_line":"        # if you try to call is_public on an image model returned by"},{"line_number":793,"context_line":"        # a call to V2 image.get()"},{"line_number":794,"context_line":"        img \u003d mock.MagicMock(is_public\u003dAttributeError,"},{"line_number":795,"context_line":"                             visibility\u003d\u0027PUBLIC\u0027)"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"        res \u003d glance.GlanceImageService._is_image_available(ctx, img)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B0bk%3D","line":794,"updated":"2014-03-11 23:41:25.000000000","message":"Good, testing against this regressing back to the old behavior.","commit_id":"bce6254160f8396e8c09e71c9351507413200f30"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ef5984b4914a2d32d90ba4bbece5e3df745ce96","unresolved":false,"context_lines":[{"line_number":799,"context_line":""},{"line_number":800,"context_line":"    def test_v1_is_public(self):"},{"line_number":801,"context_line":"        ctx \u003d mock.MagicMock(auth_token\u003dFalse, is_admin\u003dTrue)"},{"line_number":802,"context_line":"        img \u003d mock.MagicMock(is_public\u003dTrue, visibility\u003dFalse)"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        res \u003d glance.GlanceImageService._is_image_available(ctx, img)"},{"line_number":805,"context_line":"        self.assertTrue(res)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B0bQ%3D","line":802,"updated":"2014-03-11 23:41:25.000000000","message":"I was actually expecting there to be no visibility attribute here, why is it needed?  If it\u0027s v1 the attribute wouldn\u0027t be there right?  Maybe need a test for both, is_public\u003dTrue but no visibility attribute for v1.","commit_id":"bce6254160f8396e8c09e71c9351507413200f30"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"338f3dd7ba1eaffdb735ef63b3944db65845432c","unresolved":false,"context_lines":[{"line_number":799,"context_line":""},{"line_number":800,"context_line":"    def test_v1_is_public(self):"},{"line_number":801,"context_line":"        ctx \u003d mock.MagicMock(auth_token\u003dFalse, is_admin\u003dTrue)"},{"line_number":802,"context_line":"        img \u003d mock.MagicMock(is_public\u003dTrue, visibility\u003dFalse)"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        res \u003d glance.GlanceImageService._is_image_available(ctx, img)"},{"line_number":805,"context_line":"        self.assertTrue(res)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B0Ys%3D","line":802,"in_reply_to":"AAAAVn%2F%2B0bQ%3D","updated":"2014-03-11 23:46:03.000000000","message":"Gah, copy paste error. Will fix up.","commit_id":"bce6254160f8396e8c09e71c9351507413200f30"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fa37a4ffea639977601a4839fcc24d05204ee1a4","unresolved":false,"context_lines":[{"line_number":799,"context_line":"        # We emulate warlock validation that throws an AttributeError"},{"line_number":800,"context_line":"        # if you try to call is_public on an image model returned by"},{"line_number":801,"context_line":"        # a call to V2 image.get()"},{"line_number":802,"context_line":"        img \u003d mock.MagicMock(is_public\u003dAttributeError,"},{"line_number":803,"context_line":"                             visibility\u003d\u0027PUBLIC\u0027,"},{"line_number":804,"context_line":"                             spec\u003dTestIsImageAvailable.ImageSpecV2)"},{"line_number":805,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2BzuA%3D","line":802,"updated":"2014-03-12 01:38:25.000000000","message":"If I understand the spec kwarg correctly, you don\u0027t need this now since trying to access is_public on the mock will result in an AttributeError because it\u0027s not in the V2 spec.\n\n\"Mock has many other ways you can configure it and control its behaviour. For example the spec argument configures the mock to take its specification from another object. Attempting to access attributes or methods on the mock that don’t exist on the spec will fail with an AttributeError.\"","commit_id":"491f110c79074732cc48157f3cb869094310aa24"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9c6e801e056e0fe4ce32f0311b538600a4bd24f4","unresolved":false,"context_lines":[{"line_number":799,"context_line":"        # We emulate warlock validation that throws an AttributeError"},{"line_number":800,"context_line":"        # if you try to call is_public on an image model returned by"},{"line_number":801,"context_line":"        # a call to V2 image.get()"},{"line_number":802,"context_line":"        img \u003d mock.MagicMock(is_public\u003dAttributeError,"},{"line_number":803,"context_line":"                             visibility\u003d\u0027PUBLIC\u0027,"},{"line_number":804,"context_line":"                             spec\u003dTestIsImageAvailable.ImageSpecV2)"},{"line_number":805,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2BztA%3D","line":802,"in_reply_to":"AAAAVn%2F%2BzuA%3D","updated":"2014-03-12 01:42:57.000000000","message":"Ah, cheers. Will fix.","commit_id":"491f110c79074732cc48157f3cb869094310aa24"}]}