)]}'
{"id":"openstack%2Fnova~797879","triplet_id":"openstack%2Fnova~stable%2Fussuri~Ia81a0fdbd950b51dbcc70c65ba492549a224ce2b","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1910466","hashtags":[],"change_id":"Ia81a0fdbd950b51dbcc70c65ba492549a224ce2b","subject":"Fix max cpu topologies with numa affinity","status":"ABANDONED","created":"2021-06-24 11:24:53.000000000","updated":"2022-10-05 15:44:24.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"378194b37a5fb261e46d76c114ecada59f16914e","_number":797879,"virtual_id_number":797879,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-06-24 13:27:01.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-24 11:24:53.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2021-06-24 13:27:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-24 14:45:23.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-06-24 16:03:48.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"7f85f407cc71121e129935407f7ecf0a7e7e1801","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-24 11:24:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"829d795f92b560ca16bb9365e4c3b4746ab9cb00","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 13:27:01.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/d6c6988b4db74f4492c25897b5d39196 : SUCCESS in 1h 14m 50s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/67735bfb7a1540199c7512df922b12f5 : SUCCESS in 19m 02s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ce157373dbff4e9ea0ea9c28a517fe5d : SUCCESS in 17m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/66089a35428c46419ea0583a0b22f9a9 : FAILURE in 10m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6515ffc9200c4801a7aa2ea813603cfe : SUCCESS in 14m 54s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/fdce916fedba45da814ce871e660ec75 : SUCCESS in 16m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6c11e88ef7ad44eb941cd3b2347e72f2 : SUCCESS in 13m 07s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/280921aba9eb498abca076afe17dbe4f : SUCCESS in 19m 02s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/8fa50b5fc86d4f99bde56c1d95b52828 : SUCCESS in 57m 16s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/5f1c109c520e4e2bba043f0d53c8e425 : SUCCESS in 1h 24m 50s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/16fea3a5079542d8a74a419f7f526262 : FAILURE in 1h 31m 01s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/bb79fea9131f4fb5adfdc037f3398fb2 : SUCCESS in 52m 00s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/111b235667594b378e6bab84591f9943 : FAILURE in 50m 09s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/b0ed81941d464867abaae3de2beb0b40 : SUCCESS in 1h 20m 55s\n- nova-next https://zuul.opendev.org/t/openstack/build/4819096fa1dd4737bf101f621bb45c79 : SUCCESS in 1h 25m 24s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/6528f5558c464019994c548798b96f83 : SUCCESS in 20m 10s\n- grenade https://zuul.opendev.org/t/openstack/build/97793857985740be83dc9c47c818e18c : SUCCESS in 1h 07m 12s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/36440a9eb4c74364b28de7ef8df54bf6 : SUCCESS in 1h 13m 29s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/d8e6d1675e6a49a2b0e032668a21de22 : SUCCESS in 59m 27s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/15764652d56c4981804154d1fe793a1a : FAILURE in 32m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5b62217ed3ec2adde73f9840d82ef7756071f6b7","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-06-24 14:45:23.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/797879/1/iscsi : SUCCESS in 3h 16m 10s","accounts_in_message":[],"_revision_number":1},{"id":"cde86d0c9feb28aa8aefe7911937e4b4f34b7a70","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-24 16:03:48.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic finger://zuul-v3-executor.novalocal/929b7502e4394a398c84006206a7d75c : POST_FAILURE in 2h 10m 48s\n- tempest-dsvm-full-bionic-py3 finger://zuul-v3-executor.novalocal/b5af452dbdc443c8858f444be67871e1 : POST_FAILURE in 2h 19m 58s","accounts_in_message":[],"_revision_number":1},{"id":"378194b37a5fb261e46d76c114ecada59f16914e","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-10-05 15:44:24.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cfceb61c976c7f6a80426d29c956515cbc6fa8fb","revisions":{"cfceb61c976c7f6a80426d29c956515cbc6fa8fb":{"kind":"REWORK","_number":1,"created":"2021-06-24 11:24:53.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/79/797879/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/79/797879/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/797879/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/797879/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/797879/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/79/797879/1"}}},"commit":{"parents":[{"commit":"334a310e2096e699d3c327e95b1c0a83cf77691b","subject":"Test numa and vcpu topologies bug: #1910466","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/334a310e2096e699d3c327e95b1c0a83cf77691b"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2021-01-06 19:49:56.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-06-24 09:56:17.000000000","tz":60},"subject":"Fix max cpu topologies with numa affinity","message":"Fix max cpu topologies with numa affinity\n\nNova has never supported specifying per numa node\ncpu toplogies. Logically the  cpu toplogy of a guest\nis independent of its numa toplogy and there is no\nway to model different cpu toplogies per numa node\nor implement that in hardware.\n\nThe presence of the code in nova that allowed the generation\nof these invalid configuration has now been removed as it\nbroke the automatic selection of cpu topologies based\non hw:max_[cpus|sockets|threads] flavor and image properties.\n\nThis change removed the incorrect code and related unit\ntests with assert nova could generate invalid topologies.\n\nConflicts:\n  nova/tests/unit/virt/test_hardware.py\n  nova/virt/hardware.py\n\nChanges:\n  nova/virt/hardware.py\n\nNOTE(stephenfin): Conflicts in \u0027nova/tests/unit/virt/test_hardware.py\u0027\nare due to missing changes from the use-pcpu-and-vcpu-in-one-instance\nseries, specifically changes Ia651cf9f51ff7265c5e3bfec79bc695aa3fe3394\n(\"hardware: Remove \u0027_numa_fit_instance_cell_with_pinning\u0027\") and\nI901fbd7df00e45196395ff4c69e7b8aa3359edf6 (\"objects: Introduce \u0027pcpuset\u0027\nfield for InstanceNUMACell\"). Both the conflict and change (removal of\nan unnecessary import) in \u0027nova/virt/hardware.py\u0027 are due to the absence\nof change Iccce0ab50eee515e533ab36c8e7adc10cb3f7019 (\"Remove six.PY2 and\nsix.PY3\").\n\nCloses-Bug: #1910466\nChange-Id: Ia81a0fdbd950b51dbcc70c65ba492549a224ce2b\n(cherry picked from commit 387823b36d091abbaa37efb930fc98b94a5bbb93)\n(cherry picked from commit c9826ca6eb10fc36fb563a42f55715ff5ac51684)\n(cherry picked from commit 6c858fa6b53526e92013980817716934b14e65df)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cfceb61c976c7f6a80426d29c956515cbc6fa8fb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cfceb61c976c7f6a80426d29c956515cbc6fa8fb"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
