)]}'
{"id":"openstack%2Fnova~797976","triplet_id":"openstack%2Fnova~stable%2Fstein~Ia81a0fdbd950b51dbcc70c65ba492549a224ce2b","project":"openstack/nova","branch":"stable/stein","topic":"bug/1910466","hashtags":[],"change_id":"Ia81a0fdbd950b51dbcc70c65ba492549a224ce2b","subject":"Fix max cpu topologies with numa affinity","status":"ABANDONED","created":"2021-06-24 16:19:49.000000000","updated":"2022-10-05 15:44:15.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cefbd1c591e941773a0a60bcf18c60691635ba5d","_number":797976,"virtual_id_number":797976,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-06-24 19:04:44.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-24 16:19:49.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2021-06-24 19:04:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-24 19:27:42.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"beca8da7bc3569d44c3d152712e7cbe61d78cec7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-24 16:19:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"99ee7ec93e00ce3fbe3b47e1b74c99ff28a48984","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-24 16:23:52.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"c6b1f5a427a830a3da2ccaee62e4a51daa4ed4c2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 19:04:44.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/fdfd7641a82b4dd3ad79a23dc43bc362 : SUCCESS in 1h 15m 50s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/13f0fef1f7f54eb1b3eada79ca8be8ed : SUCCESS in 18m 24s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c34d6e67f6204c24929ac5ac1b9a2d41 : SUCCESS in 15m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/aaeb785b5b6545d4a99d85730b751c27 : FAILURE in 12m 25s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/b7b1edd2b4c5498e8ba35191370e5149 : SUCCESS in 16m 09s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/cde2729a420b474da5be269cfa977db4 : SUCCESS in 14m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f8af39deb6ac42889a5109bf60506f0e : SUCCESS in 16m 06s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/3d638abb01cf4a7aa463fd8022b7a5dd : SUCCESS in 14m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/aa5efb3a95bf4526aca398148b98d0e5 : SUCCESS in 9m 05s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a0ee44a1598b4a3aa1afdd52f7cbc78e : SUCCESS in 23m 10s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/f751c3280467474296434b5ba7fd9ca5 : SUCCESS in 53m 15s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/22cca9930c8542f0b7d7146b202cc44d : SUCCESS in 1h 07m 57s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/251245cceb6941c696b2453797748dd4 : SUCCESS in 1h 08m 11s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/3f2812643d06405ba64894596ed499f3 : SUCCESS in 49m 57s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/fcc719c546254a6aa753794eb126def6 : SUCCESS in 1h 03m 02s (non-voting)\n- nova-next https://zuul.opendev.org/t/openstack/build/dd7ac2d0dc9345e5b488db3f8e328455 : SUCCESS in 1h 14m 14s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/9faa041870644b4a82291b30fee2441e : SUCCESS in 22m 52s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/9d13e5088d53437a9e64866b0f050150 : SUCCESS in 21m 39s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/38d2b34660314a33abc6cc2c4e5c4096 : FAILURE in 1h 28m 36s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/4613acfa56d34b1b9abcef05de4cd0c8 : FAILURE in 2h 34m 09s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/9a04ac60ab8140f1995e4fbc1ff2d00c : SUCCESS in 1h 01m 37s","accounts_in_message":[],"_revision_number":2},{"id":"50d5c4b07d7530d8257c626041b6e29b8c424418","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-24 19:27:42.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 finger://zuul-v3-executor.novalocal/2a3d3adb31dd459da080857394557ca5 : POST_FAILURE in 1h 31m 22s","accounts_in_message":[],"_revision_number":2},{"id":"cefbd1c591e941773a0a60bcf18c60691635ba5d","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-10-05 15:44:15.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1ad30eeaf8b0670036252f36cb28e101e1a8ff89","revisions":{"05d478cfd563b970324807318a2e731a63c4640c":{"kind":"REWORK","_number":1,"created":"2021-06-24 16:19:49.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/76/797976/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/797976/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/797976/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/797976/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/797976/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/797976/1"}}},"commit":{"parents":[{"commit":"c24897b2388afbbf0a6602f000d13248539a01a8","subject":"Test numa and vcpu topologies bug: #1910466","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c24897b2388afbbf0a6602f000d13248539a01a8"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2021-01-06 19:49:56.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-06-24 16:13:27.000000000","tz":60},"subject":"Fix max cpu topologies with numa affinity","message":"Fix max cpu topologies with numa affinity\n\nNova has never supported specifying per numa node\ncpu toplogies. Logically the  cpu toplogy of a guest\nis independent of its numa toplogy and there is no\nway to model different cpu toplogies per numa node\nor implement that in hardware.\n\nThe presence of the code in nova that allowed the generation\nof these invalid configuration has now been removed as it\nbroke the automatic selection of cpu topologies based\non hw:max_[cpus|sockets|threads] flavor and image properties.\n\nThis change removed the incorrect code and related unit\ntests with assert nova could generate invalid topologies.\n\nConflicts:\n  nova/tests/functional/libvirt/test_numa_servers.py\n  nova/virt/hardware.py\n\nNOTE(stephenfin): As expected, this was the hairiest of the backports so\nfar due to the absence of changes from \u0027cpu-resources\u0027 series. With that\nsaid, most of the \"hairiness\" is in the functional test, given we\u0027re\nmissing tests from change Ie38aa625dff543b5980fd437ad2febeba3b50079\n(\"Add support for translating CPU policy extra specs, image meta\") and\nits ilk. The actual test itself is unchanged from stable/train, however.\nThe conflicts in the code itself are far more trivial and are caused by\nthe absence of changes Ie38aa625dff543b5980fd437ad2febeba3b50079 and\nI6381365ff882cf23808e8dabfce41143c5e35192 (\"hacking: Resolve W503 (line\nbreak occurred before a binary operator)\"). They\u0027re easily resolved.\n\nCloses-Bug: #1910466\nChange-Id: Ia81a0fdbd950b51dbcc70c65ba492549a224ce2b\n(cherry picked from commit 387823b36d091abbaa37efb930fc98b94a5bbb93)\n(cherry picked from commit c9826ca6eb10fc36fb563a42f55715ff5ac51684)\n(cherry picked from commit 6c858fa6b53526e92013980817716934b14e65df)\n(cherry picked from commit cfceb61c976c7f6a80426d29c956515cbc6fa8fb)\n(cherry picked from commit 5973c09b7abbcd8ff3a0214cf3429737d266dabc)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/05d478cfd563b970324807318a2e731a63c4640c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/05d478cfd563b970324807318a2e731a63c4640c"}]},"branch":"refs/heads/stable/stein"},"1ad30eeaf8b0670036252f36cb28e101e1a8ff89":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-06-24 16:23:52.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/76/797976/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/797976/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/797976/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/797976/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/797976/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/797976/2"}}},"commit":{"parents":[{"commit":"34d48d3d3732061f6be6e4842a09847d57d7f37a","subject":"Test numa and vcpu topologies bug: #1910466","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/34d48d3d3732061f6be6e4842a09847d57d7f37a"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2021-01-06 19:49:56.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-06-24 16:23:39.000000000","tz":60},"subject":"Fix max cpu topologies with numa affinity","message":"Fix max cpu topologies with numa affinity\n\nNova has never supported specifying per numa node\ncpu toplogies. Logically the  cpu toplogy of a guest\nis independent of its numa toplogy and there is no\nway to model different cpu toplogies per numa node\nor implement that in hardware.\n\nThe presence of the code in nova that allowed the generation\nof these invalid configuration has now been removed as it\nbroke the automatic selection of cpu topologies based\non hw:max_[cpus|sockets|threads] flavor and image properties.\n\nThis change removed the incorrect code and related unit\ntests with assert nova could generate invalid topologies.\n\nConflicts:\n  nova/tests/functional/libvirt/test_numa_servers.py\n  nova/virt/hardware.py\n\nNOTE(stephenfin): As expected, this was the hairiest of the backports so\nfar due to the absence of changes from \u0027cpu-resources\u0027 series. With that\nsaid, most of the \"hairiness\" is in the functional test, given we\u0027re\nmissing tests from change Ie38aa625dff543b5980fd437ad2febeba3b50079\n(\"Add support for translating CPU policy extra specs, image meta\") and\nits ilk. The actual test itself is unchanged from stable/train, however.\nThe conflicts in the code itself are far more trivial and are caused by\nthe absence of changes Ie38aa625dff543b5980fd437ad2febeba3b50079 and\nI6381365ff882cf23808e8dabfce41143c5e35192 (\"hacking: Resolve W503 (line\nbreak occurred before a binary operator)\"). They\u0027re easily resolved.\n\nCloses-Bug: #1910466\nChange-Id: Ia81a0fdbd950b51dbcc70c65ba492549a224ce2b\n(cherry picked from commit 387823b36d091abbaa37efb930fc98b94a5bbb93)\n(cherry picked from commit c9826ca6eb10fc36fb563a42f55715ff5ac51684)\n(cherry picked from commit 6c858fa6b53526e92013980817716934b14e65df)\n(cherry picked from commit cfceb61c976c7f6a80426d29c956515cbc6fa8fb)\n(cherry picked from commit 5973c09b7abbcd8ff3a0214cf3429737d266dabc)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1ad30eeaf8b0670036252f36cb28e101e1a8ff89"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1ad30eeaf8b0670036252f36cb28e101e1a8ff89"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}