)]}'
{"id":"openstack%2Fnova~797982","triplet_id":"openstack%2Fnova~stable%2Frocky~Ia81a0fdbd950b51dbcc70c65ba492549a224ce2b","project":"openstack/nova","branch":"stable/rocky","topic":"bug/1910466","hashtags":[],"change_id":"Ia81a0fdbd950b51dbcc70c65ba492549a224ce2b","subject":"Fix max cpu topologies with numa affinity","status":"ABANDONED","created":"2021-06-24 16:46:56.000000000","updated":"2022-10-05 15:44:12.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6451f52c1df8c2aea7ebfed5d985dbe68d4b3853","_number":797982,"virtual_id_number":797982,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-06-24 18:47:11.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-24 16:46:56.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2021-06-24 18:47:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-24 19:37:38.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"226f9be969ca48af53cc0a65ce257414fbdfe0e7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-24 16:46:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ff5af6bccf3f214d2c06f407f2e57f4c7b7016a6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 18:47:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ea2d0b5bec0a4bdc8d48529a8c31dab2 : FAILURE in 11m 06s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/de84b6a419684994a703f77e5525c731 : SUCCESS in 17m 44s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/50a355258c3c49008eea88d104638903 : SUCCESS in 19m 09s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/60d8f669fedb4a36a524c9064686f3e1 : SUCCESS in 11m 22s\n- tempest-full https://zuul.opendev.org/t/openstack/build/01ee86fa85814432935ec3f1a75ad2f9 : FAILURE in 1h 09m 40s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/de42952b4d6f48f98d3bce0d198d2f25 : SUCCESS in 51m 52s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b1a91e56868d40d88a6c7ce87a922242 : SUCCESS in 1h 25m 39s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/36e64908a2414dffa6fef82cfb99927b : SUCCESS in 18m 47s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/76dda49a76ba4c8a9e343852eb90b639 : SUCCESS in 44m 33s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/de15d3f75f9a48e39fd702ac3bc564df : SUCCESS in 54m 35s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/c1d8dbc7be03469bae9f2ec68f9975cb : SUCCESS in 51m 52s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/8aec0bcd2fbd49f694191e204610169a : SUCCESS in 46m 10s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/6324de15e243493d9d954d920bfa8173 : SUCCESS in 52m 15s (non-voting)\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/10da0bcd41474a20949584a46eb898d7 : SUCCESS in 1h 03m 36s\n- nova-next https://zuul.opendev.org/t/openstack/build/ac41e39b151b43a583e161b6116bfa50 : SUCCESS in 1h 20m 40s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/c176808bbacb495abdc4dadb53adbb1b : SUCCESS in 1h 57m 28s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/f061c476e23e4e1d8fef553d11dc2e04 : FAILURE in 17m 10s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/0615b9b66e4944678eea805e30747e78 : SUCCESS in 17m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/857933bf5d524b759fef22929ebcdbc6 : FAILURE in 6m 47s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/c2c96da71fc54dc2a1038f0f138ff4c5 : SUCCESS in 59m 48s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/37f9a8c6b0584873895cacd0af962e34 : SUCCESS in 1h 31m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c2d7040ca060fe2882c2b1ac1b4973322be18814","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-24 19:37:38.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 finger://zuul-v3-executor.novalocal/c325febbf1554f978d0d326df9b35554 : POST_FAILURE in 1h 35m 04s","accounts_in_message":[],"_revision_number":1},{"id":"6451f52c1df8c2aea7ebfed5d985dbe68d4b3853","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-10-05 15:44:12.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5ccea552a0f3858786a0760ac7f0e8267fce2a7e","revisions":{"5ccea552a0f3858786a0760ac7f0e8267fce2a7e":{"kind":"REWORK","_number":1,"created":"2021-06-24 16:46:56.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/82/797982/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/82/797982/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/797982/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/797982/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/797982/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/82/797982/1"}}},"commit":{"parents":[{"commit":"c4d9a7581ab11fd1510d0fccfd869d14169bf31f","subject":"Test numa and vcpu topologies bug: #1910466","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c4d9a7581ab11fd1510d0fccfd869d14169bf31f"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2021-01-06 19:49:56.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-06-24 16:46:00.000000000","tz":60},"subject":"Fix max cpu topologies with numa affinity","message":"Fix max cpu topologies with numa affinity\n\nNova has never supported specifying per numa node\ncpu toplogies. Logically the  cpu toplogy of a guest\nis independent of its numa toplogy and there is no\nway to model different cpu toplogies per numa node\nor implement that in hardware.\n\nThe presence of the code in nova that allowed the generation\nof these invalid configuration has now been removed as it\nbroke the automatic selection of cpu topologies based\non hw:max_[cpus|sockets|threads] flavor and image properties.\n\nThis change removed the incorrect code and related unit\ntests with assert nova could generate invalid topologies.\n\nConflicts:\n  nova/tests/functional/libvirt/test_numa_servers.py\n  nova/virt/hardware.py\n\nNOTE(stephenfin): Test conflicts are due to the absence of change\nI3b4c1153bebdeab2eb8bc2108aa177732f5c6a97 (\"tests: Move mocking to\nsetUp\") and the changes we made to the functional test added in\nI333b3d85deed971678141307dd06545e308cf989 to handle this. The other\nconflict is due to change Ib3dd924e967bc9b48d81dc81e1fcdeba0120985c\n(\"Use math.gcd starting with python 3.5\"), which affects code that we\u0027re\nremoving here and therefore isn\u0027t something we should backport.\n\nCloses-Bug: #1910466\nChange-Id: Ia81a0fdbd950b51dbcc70c65ba492549a224ce2b\n(cherry picked from commit 387823b36d091abbaa37efb930fc98b94a5bbb93)\n(cherry picked from commit c9826ca6eb10fc36fb563a42f55715ff5ac51684)\n(cherry picked from commit 6c858fa6b53526e92013980817716934b14e65df)\n(cherry picked from commit cfceb61c976c7f6a80426d29c956515cbc6fa8fb)\n(cherry picked from commit 5973c09b7abbcd8ff3a0214cf3429737d266dabc)\n(cherry picked from commit 1ad30eeaf8b0670036252f36cb28e101e1a8ff89)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5ccea552a0f3858786a0760ac7f0e8267fce2a7e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5ccea552a0f3858786a0760ac7f0e8267fce2a7e"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}