)]}'
{"id":"openstack%2Fnova~797988","triplet_id":"openstack%2Fnova~stable%2Fqueens~Ia81a0fdbd950b51dbcc70c65ba492549a224ce2b","project":"openstack/nova","branch":"stable/queens","topic":"bug/1910466","hashtags":[],"change_id":"Ia81a0fdbd950b51dbcc70c65ba492549a224ce2b","subject":"Fix max cpu topologies with numa affinity","status":"ABANDONED","created":"2021-06-24 16:57:47.000000000","updated":"2022-10-05 15:44:03.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5cce55afd6ac8b707674a3427e956b9afac4e9a3","_number":797988,"virtual_id_number":797988,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-06-24 19:00:32.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-24 16:57:47.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2021-06-24 19:00:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-24 20:34:57.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"34840cde08a25c5544df8a300730efee64c78bef","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-24 16:57:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"498aa08b0a86cdf95629ee15b7ba4f7434392377","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 19:00:32.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/409c55f1d3d34d7f917816e582b71dc1 : FAILURE in 12m 16s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/96f826a08f634228a6cc42fd289cb956 : SUCCESS in 16m 19s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/74640044a94142e29dbd7ba857f4649f : SUCCESS in 16m 00s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/968dbe5d2a124bd19235b2af8196c9d6 : SUCCESS in 10m 14s\n- tempest-full https://zuul.opendev.org/t/openstack/build/575b9d3f1f6946e482c0c66539f40ec9 : SUCCESS in 1h 17m 41s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/c677408130184197bef1b15e7f33a3e8 : SUCCESS in 52m 11s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/a2888b6d71ea4551a1714bea084b92a8 : SUCCESS in 1h 19m 16s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d6abafc4710f4f758d170a604b259ef9 : SUCCESS in 18m 44s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/42f09b1b67e1430487e841ed948a0351 : SUCCESS in 50m 32s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/07c1edefb4b84a60bd65bab28bec7bc7 : SUCCESS in 45m 51s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/1e6a0e24de9a4aa6bd71cb7010132de6 : SUCCESS in 58m 10s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/7a942a0ec3ee451693bbd986a03ca1ba : SUCCESS in 46m 57s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/20a7943d78f04262afa17c40037a5a2c : SUCCESS in 57m 16s\n- nova-next https://zuul.opendev.org/t/openstack/build/2ca7a57cc5cb44b3afe223533df562d8 : SUCCESS in 1h 13m 16s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/573ed610ba1f4234b5e2e437690720fd : SUCCESS in 1h 56m 26s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/6cb2765aaff2421e8887424387955953 : SUCCESS in 20m 58s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/abb99dd7fccd4dd982f6d7b43b14fe2f : FAILURE in 19m 49s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/f6138c3be48f4bb898d7e0f832c735de : SUCCESS in 1h 01m 43s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/9a5697d18fc64496bfea0d8a9c07a19a : SUCCESS in 1h 27m 54s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"825448c9bb285cd0590e0331b0ed0040a6de6a04","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-24 20:34:57.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial finger://zuul-v3-executor.novalocal/05d87ee716994682baeebf9bb97a30e2 : POST_FAILURE in 32m 22s\n- tempest-dsvm-full-xenial-py3 finger://zuul-v3-executor.novalocal/a5721a38af8041d99c7d6f87ef9fb4db : POST_FAILURE in 22m 07s","accounts_in_message":[],"_revision_number":1},{"id":"5cce55afd6ac8b707674a3427e956b9afac4e9a3","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-10-05 15:44:03.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"828a8d67540de6227d22edd0db6a79eaa9ecda0a","revisions":{"828a8d67540de6227d22edd0db6a79eaa9ecda0a":{"kind":"REWORK","_number":1,"created":"2021-06-24 16:57:47.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/88/797988/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/88/797988/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/88/797988/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/88/797988/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/88/797988/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/88/797988/1"}}},"commit":{"parents":[{"commit":"c89050c567477fd321d93aea2bf11a53bb3fe6eb","subject":"Test numa and vcpu topologies bug: #1910466","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c89050c567477fd321d93aea2bf11a53bb3fe6eb"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2021-01-06 19:49:56.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-06-24 16:53:32.000000000","tz":60},"subject":"Fix max cpu topologies with numa affinity","message":"Fix max cpu topologies with numa affinity\n\nNova has never supported specifying per numa node\ncpu toplogies. Logically the  cpu toplogy of a guest\nis independent of its numa toplogy and there is no\nway to model different cpu toplogies per numa node\nor implement that in hardware.\n\nThe presence of the code in nova that allowed the generation\nof these invalid configuration has now been removed as it\nbroke the automatic selection of cpu topologies based\non hw:max_[cpus|sockets|threads] flavor and image properties.\n\nThis change removed the incorrect code and related unit\ntests with assert nova could generate invalid topologies.\n\nConflicts:\n  nova/virt/hardware.py\n\nNOTE(stephenfin): Conflicts are due to the absence of changes\nIa99d2e4e502d6fa13572727a9dabc617f472cb0f (\"hardware: Rework\n\u0027_get_cpu_topology_constraints\u0027\") and\nI021ce59048d6292055af49457ba642022f648c81 (\"Ensure emulator threads are\nalways calculated\"), both of which are too invasive to backport.\n\nCloses-Bug: #1910466\nChange-Id: Ia81a0fdbd950b51dbcc70c65ba492549a224ce2b\n(cherry picked from commit 387823b36d091abbaa37efb930fc98b94a5bbb93)\n(cherry picked from commit c9826ca6eb10fc36fb563a42f55715ff5ac51684)\n(cherry picked from commit 6c858fa6b53526e92013980817716934b14e65df)\n(cherry picked from commit cfceb61c976c7f6a80426d29c956515cbc6fa8fb)\n(cherry picked from commit 5973c09b7abbcd8ff3a0214cf3429737d266dabc)\n(cherry picked from commit 1ad30eeaf8b0670036252f36cb28e101e1a8ff89)\n(cherry picked from commit 5ccea552a0f3858786a0760ac7f0e8267fce2a7e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/828a8d67540de6227d22edd0db6a79eaa9ecda0a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/828a8d67540de6227d22edd0db6a79eaa9ecda0a"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
