)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"17b14feab152d5429e1d21302ea9da4e8fd933c9","unresolved":true,"context_lines":[{"line_number":12,"context_line":"configuration is not be set to true in production environment. So"},{"line_number":13,"context_line":" the warning log should be added."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iff44abf002aac548340ffab0a6f85bc4906738a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"780ebb3d_e8b46867","line":15,"updated":"2021-07-01 13:48:14.000000000","message":"If you want to backport this fix then you need to open a bug on Launchpad [1] and link it here, i.e.\n\n Closes-Bug: #????\n\n[1] https://bugs.launchpad.net/nova/+filebug","commit_id":"cfb3c4e8b2512433e1075926ab2f326f65fe8ee1"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"f3e4e2b6e43d986e2aba6e04541a5f72f2893c65","unresolved":false,"context_lines":[{"line_number":12,"context_line":"configuration is not be set to true in production environment. So"},{"line_number":13,"context_line":" the warning log should be added."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iff44abf002aac548340ffab0a6f85bc4906738a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"eb970639_230cb0ee","line":15,"in_reply_to":"780ebb3d_e8b46867","updated":"2021-07-03 02:39:24.000000000","message":"Done","commit_id":"cfb3c4e8b2512433e1075926ab2f326f65fe8ee1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80d199bdbe487a95a5991aa22173c4e55badae6f","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When \u0027host_topology\u0027 can not be satified with \u0027requested_topology\u0027,"},{"line_number":10,"context_line":"nova-compute returns the msg to nova-conductor but there is no logs"},{"line_number":11,"context_line":"in nova-compute.log. Thouth there are some debug logs, but `debug`"},{"line_number":12,"context_line":"configuration is not be set to true in production environment. So"},{"line_number":13,"context_line":" the warning log should be added."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fc15df95_8db1896b","line":11,"updated":"2021-07-03 09:55:13.000000000","message":"just a nit but there are several large public clouds that do run with debug on in production.","commit_id":"7a0771a5b29ad9786e2e68769fddab2f54c1f91e"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"ef487bf3ff44c54fab0b179e2c9b3f5dbe4cac27","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When \u0027host_topology\u0027 can not be satified with \u0027requested_topology\u0027,"},{"line_number":10,"context_line":"nova-compute returns the msg to nova-conductor but there is no logs"},{"line_number":11,"context_line":"in nova-compute.log. Thouth there are some debug logs, but `debug`"},{"line_number":12,"context_line":"configuration is not be set to true in production environment. So"},{"line_number":13,"context_line":" the warning log should be added."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"737ae2b4_89c2e841","line":11,"in_reply_to":"fc15df95_8db1896b","updated":"2021-07-05 01:13:35.000000000","message":"Done","commit_id":"7a0771a5b29ad9786e2e68769fddab2f54c1f91e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80d199bdbe487a95a5991aa22173c4e55badae6f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"nova-compute returns the msg to nova-conductor but there is no logs"},{"line_number":11,"context_line":"in nova-compute.log. Thouth there are some debug logs, but `debug`"},{"line_number":12,"context_line":"configuration is not be set to true in production environment. So"},{"line_number":13,"context_line":" the warning log should be added."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1934412"},{"line_number":16,"context_line":"Change-Id: Iff44abf002aac548340ffab0a6f85bc4906738a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ae2a68d3_2dcba16b","line":13,"updated":"2021-07-03 09:55:13.000000000","message":"warning is proably to hi as that is intended to signal that there is a action that operators need to take but info would be appropriate","commit_id":"7a0771a5b29ad9786e2e68769fddab2f54c1f91e"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"ef487bf3ff44c54fab0b179e2c9b3f5dbe4cac27","unresolved":false,"context_lines":[{"line_number":10,"context_line":"nova-compute returns the msg to nova-conductor but there is no logs"},{"line_number":11,"context_line":"in nova-compute.log. Thouth there are some debug logs, but `debug`"},{"line_number":12,"context_line":"configuration is not be set to true in production environment. So"},{"line_number":13,"context_line":" the warning log should be added."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1934412"},{"line_number":16,"context_line":"Change-Id: Iff44abf002aac548340ffab0a6f85bc4906738a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"57ebfcd7_a9b3313c","line":13,"in_reply_to":"ae2a68d3_2dcba16b","updated":"2021-07-05 01:13:35.000000000","message":"Done","commit_id":"7a0771a5b29ad9786e2e68769fddab2f54c1f91e"}],"nova/compute/claims.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"17b14feab152d5429e1d21302ea9da4e8fd933c9","unresolved":true,"context_lines":[{"line_number":111,"context_line":"        reasons \u003d [self._test_numa_topology(compute_node, numa_topology_limit),"},{"line_number":112,"context_line":"                   self._test_pci()]"},{"line_number":113,"context_line":"        reasons \u003d [r for r in reasons if r is not None]"},{"line_number":114,"context_line":"        if len(reasons) \u003e 0:"},{"line_number":115,"context_line":"            raise exception.ComputeResourcesUnavailable(reason\u003d"},{"line_number":116,"context_line":"                    \"; \".join(reasons))"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fec4f9ab_1b4c9d41","line":114,"updated":"2021-07-01 13:48:14.000000000","message":"here","commit_id":"cfb3c4e8b2512433e1075926ab2f326f65fe8ee1"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"f3e4e2b6e43d986e2aba6e04541a5f72f2893c65","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        reasons \u003d [self._test_numa_topology(compute_node, numa_topology_limit),"},{"line_number":112,"context_line":"                   self._test_pci()]"},{"line_number":113,"context_line":"        reasons \u003d [r for r in reasons if r is not None]"},{"line_number":114,"context_line":"        if len(reasons) \u003e 0:"},{"line_number":115,"context_line":"            raise exception.ComputeResourcesUnavailable(reason\u003d"},{"line_number":116,"context_line":"                    \"; \".join(reasons))"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"82842683_b729bddd","line":114,"in_reply_to":"fec4f9ab_1b4c9d41","updated":"2021-07-03 02:39:24.000000000","message":"Done","commit_id":"cfb3c4e8b2512433e1075926ab2f326f65fe8ee1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"17b14feab152d5429e1d21302ea9da4e8fd933c9","unresolved":true,"context_lines":[{"line_number":148,"context_line":"                if pci_requests.requests:"},{"line_number":149,"context_line":"                    LOG.warning(\"Requested instance NUMA topology together \""},{"line_number":150,"context_line":"                                \"with requested PCI devices cannot fit the \""},{"line_number":151,"context_line":"                                \"given host NUMA topology\")"},{"line_number":152,"context_line":"                    return (_(\"Requested instance NUMA topology together with \""},{"line_number":153,"context_line":"                              \"requested PCI devices cannot fit the given \""},{"line_number":154,"context_line":"                              \"host NUMA topology\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3d2e6319_93182ee7","line":151,"updated":"2021-07-01 13:48:14.000000000","message":"This isn\u0027t where you want to do this. The return type of the function should be the giveaway. Instead, you want to raise a log where this function is called i.e. line 115 above","commit_id":"cfb3c4e8b2512433e1075926ab2f326f65fe8ee1"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"f3e4e2b6e43d986e2aba6e04541a5f72f2893c65","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                if pci_requests.requests:"},{"line_number":149,"context_line":"                    LOG.warning(\"Requested instance NUMA topology together \""},{"line_number":150,"context_line":"                                \"with requested PCI devices cannot fit the \""},{"line_number":151,"context_line":"                                \"given host NUMA topology\")"},{"line_number":152,"context_line":"                    return (_(\"Requested instance NUMA topology together with \""},{"line_number":153,"context_line":"                              \"requested PCI devices cannot fit the given \""},{"line_number":154,"context_line":"                              \"host NUMA topology\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"2d07ebf6_eecc43bd","line":151,"in_reply_to":"3d2e6319_93182ee7","updated":"2021-07-03 02:39:24.000000000","message":"Done","commit_id":"cfb3c4e8b2512433e1075926ab2f326f65fe8ee1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80d199bdbe487a95a5991aa22173c4e55badae6f","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                   self._test_pci()]"},{"line_number":113,"context_line":"        reasons \u003d [r for r in reasons if r is not None]"},{"line_number":114,"context_line":"        if len(reasons) \u003e 0:"},{"line_number":115,"context_line":"            LOG.warning(\u0027Failed to claim: %s\u0027, \u0027, \u0027.join(reasons),"},{"line_number":116,"context_line":"                        instance\u003dself.instance)"},{"line_number":117,"context_line":"            raise exception.ComputeResourcesUnavailable(reason\u003d"},{"line_number":118,"context_line":"                    \"; \".join(reasons))"}],"source_content_type":"text/x-python","patch_set":3,"id":"45574b18_a17c3074","line":115,"updated":"2021-07-03 09:55:13.000000000","message":"LOG.info","commit_id":"7a0771a5b29ad9786e2e68769fddab2f54c1f91e"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"ef487bf3ff44c54fab0b179e2c9b3f5dbe4cac27","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                   self._test_pci()]"},{"line_number":113,"context_line":"        reasons \u003d [r for r in reasons if r is not None]"},{"line_number":114,"context_line":"        if len(reasons) \u003e 0:"},{"line_number":115,"context_line":"            LOG.warning(\u0027Failed to claim: %s\u0027, \u0027, \u0027.join(reasons),"},{"line_number":116,"context_line":"                        instance\u003dself.instance)"},{"line_number":117,"context_line":"            raise exception.ComputeResourcesUnavailable(reason\u003d"},{"line_number":118,"context_line":"                    \"; \".join(reasons))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f62794d_bd42893c","line":115,"in_reply_to":"45574b18_a17c3074","updated":"2021-07-05 01:13:35.000000000","message":"Done","commit_id":"7a0771a5b29ad9786e2e68769fddab2f54c1f91e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5593e9fed367193e2bc66cefb0f9dbd7b96f8c68","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                   self._test_pci()]"},{"line_number":113,"context_line":"        reasons \u003d [r for r in reasons if r is not None]"},{"line_number":114,"context_line":"        if len(reasons) \u003e 0:"},{"line_number":115,"context_line":"            LOG.info(\u0027Failed to claim: %s\u0027, \u0027; \u0027.join(reasons),"},{"line_number":116,"context_line":"                     instance\u003dself.instance)"},{"line_number":117,"context_line":"            raise exception.ComputeResourcesUnavailable(reason\u003d"},{"line_number":118,"context_line":"                    \"; \".join(reasons))"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"216c7127_8c192eb9","line":116,"range":{"start_line":115,"start_character":11,"end_line":116,"end_character":44},"updated":"2021-07-05 10:29:31.000000000","message":"this mirrors the log on success below so +1 from me","commit_id":"97a566ad9c3a6ab059dc94d154fb747e4b7d9ccd"}]}