)]}'
{"nova/api/openstack/compute/contrib/aggregates.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"24773045f57b632fbda42d7dcb88a03385985ebe","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            LOG.info(e)"},{"line_number":85,"context_line":"            raise exc.HTTPConflict()"},{"line_number":86,"context_line":"        except exception.InvalidAggregateAction as e:"},{"line_number":87,"context_line":"            LOG.info(e)"},{"line_number":88,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":89,"context_line":"        return self._marshall_aggregate(aggregate)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAW3%2F%2F7kg%3D","line":87,"updated":"2014-04-09 12:24:58.000000000","message":"LOG.info(e) seems unnecessary because log is not output in most BadRequest cases. In production environments, operators might not want to see a lot of log message for BadRequest.","commit_id":"054491a9fb0a611d3ce03ec2fdcc656c0276c1e7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f0417f86a4471a72265b0bc9c94955c7879681b2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            aggregate \u003d self.api.create_aggregate(context, name, avail_zone)"},{"line_number":83,"context_line":"        except exception.AggregateNameExists as e:"},{"line_number":84,"context_line":"            raise exc.HTTPConflict()"},{"line_number":85,"context_line":"        except exception.InvalidAggregateAction as e:"},{"line_number":86,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":87,"context_line":"        return self._marshall_aggregate(aggregate)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2F16M%3D","line":84,"updated":"2014-04-10 01:27:18.000000000","message":"I agree to removing LOG.info(e) for HTTPConflict also. but if doing it, here needs to be changed to\n\n raise exc.HTTPConflict(explanation\u003de.format_message())","commit_id":"7d8b8774063be0d0fe1d18a1904788610305ac44"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"cb62b25623ca2dbb44da45efd95137b56b0484e8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            aggregate \u003d self.api.create_aggregate(context, name, avail_zone)"},{"line_number":83,"context_line":"        except exception.AggregateNameExists as e:"},{"line_number":84,"context_line":"            raise exc.HTTPConflict()"},{"line_number":85,"context_line":"        except exception.InvalidAggregateAction as e:"},{"line_number":86,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":87,"context_line":"        return self._marshall_aggregate(aggregate)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2F148%3D","line":84,"in_reply_to":"AAAAW3%2F%2F16M%3D","updated":"2014-04-10 01:33:57.000000000","message":"agree, shy to not pay attention to.... thanks","commit_id":"7d8b8774063be0d0fe1d18a1904788610305ac44"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"581ba1c7fcb802ea823d0194deb1719f097ff0b0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            aggregate \u003d self.api.create_aggregate(context, name, avail_zone)"},{"line_number":83,"context_line":"        except exception.AggregateNameExists as e:"},{"line_number":84,"context_line":"            LOG.info(e)"},{"line_number":85,"context_line":"            raise exc.HTTPConflict()"},{"line_number":86,"context_line":"        except exception.InvalidAggregateAction as e:"},{"line_number":87,"context_line":"            LOG.info(e)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad9bd40_5ed5e441","side":"PARENT","line":84,"updated":"2014-04-30 08:19:00.000000000","message":"out of the scope, but ok ;)","commit_id":"1372397d4f5f8c155af6f1f4ab5dc68be00c9c01"}]}