)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"26758f3701e20b4af1d9c799312837341f1dcdf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73634fc1_f425738a","updated":"2021-11-18 09:59:52.000000000","message":"I wasn\u0027t around for the meeting on Tuesday but could someone tl;dr it here?\n\nI\u0027m assuming the outcome was that we are happy to change this default *without* caching the existing model anywhere as cirrus is considered harmful by the QEMU folks?","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"cbd0710bf39b351d7146d04ec3051c9933e27322","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b28045db_4c439fad","updated":"2021-11-18 13:58:31.000000000","message":"Thanks to Sean for the context, this LGTM now given the fallback within QEMU to a sane VGA default if the guestOS doesn\u0027t support the virtio device.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3cff9e4136a985d3f4ba339667f78414ed629051","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0b4fdd0a_f7d6eba7","updated":"2021-11-15 13:01:55.000000000","message":"based on our irc conversation ill remove my -1 as it appears we are ok to change the direction","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"da2cd831d05110c5985575b4c03eb5fa809e6a48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9c6351b2_f9c3e4da","updated":"2021-11-16 11:23:06.000000000","message":"lets get the bp approved today and I then I will upgrade my +1 to +2","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"09504fc23aa02cb817e258b7b758c6e2cd039181","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"52900752_f7a5e663","updated":"2021-11-16 16:49:56.000000000","message":"we agreed on today\u0027s IRC meeting that the bp is approved for Yoga, so I\u0027m upgrading my vote to +2","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"245c850452755510db59b1d44405e051b24d21ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db954e3a_f8d70c32","in_reply_to":"73634fc1_f425738a","updated":"2021-11-18 13:06:16.000000000","message":"no that is not the rational\n\nthe effect is the same but the reason we are now ok to just change the default for all instnace on x86 is that virtio provide a vga compatible interface in addtion to the more capable virtio-gpu specific interface such that a generic vga drvier can be used with a virtio gpu model.\n\n\nwhat that measn is any operating system the supprot genreic vga will work transparently with virtio gpu.\n\nthe only way there could be an upgrade impack as a result is if teh guest previously had a cirrus vga driver an no generic vga dirver or virtio gpu driver.\n\ndownstream windows and linux guest were tested and both seam to work fine with the changed video model so based on that finding the decision was made to just change it by default instead of recording the current model and only chaning new vms.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"cbd0710bf39b351d7146d04ec3051c9933e27322","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7add60a3_7ada0d7a","in_reply_to":"db954e3a_f8d70c32","updated":"2021-11-18 13:58:31.000000000","message":"ACK thanks Sean, this makes sense in that case.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e4e3a040e899cf3822bb37a53882443304ecd4b","unresolved":true,"context_lines":[{"line_number":2055,"context_line":"        super(LibvirtConfigGuestVideo, self).__init__(root_name\u003d\"video\","},{"line_number":2056,"context_line":"                                                      **kwargs)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        self.type \u003d \u0027virtio\u0027"},{"line_number":2059,"context_line":"        self.vram \u003d None"},{"line_number":2060,"context_line":"        self.heads \u003d None"},{"line_number":2061,"context_line":"        self.driver_iommu \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"6ec96673_e28804ac","line":2058,"updated":"2021-07-09 21:08:10.000000000","message":"this should not be updated.\nas we discussed on irc previously","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c49e3e495f6b30fe0dfad39790731e6cc1703665","unresolved":true,"context_lines":[{"line_number":2055,"context_line":"        super(LibvirtConfigGuestVideo, self).__init__(root_name\u003d\"video\","},{"line_number":2056,"context_line":"                                                      **kwargs)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        self.type \u003d \u0027virtio\u0027"},{"line_number":2059,"context_line":"        self.vram \u003d None"},{"line_number":2060,"context_line":"        self.heads \u003d None"},{"line_number":2061,"context_line":"        self.driver_iommu \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"6b93f9c3_db342853","line":2058,"in_reply_to":"1b7eef37_e7be4076","updated":"2021-08-04 17:40:14.000000000","message":"leaving cirros is what we had orginally agree to do.\nthat would be my prefeernce\n\nthis approch was suggested because we wanted to ensure that any instance that currently uses cirrus continues too. and the the new default only took effect for new instances.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"373b060b36ba4e84df8537d43e6ca9506896a121","unresolved":false,"context_lines":[{"line_number":2055,"context_line":"        super(LibvirtConfigGuestVideo, self).__init__(root_name\u003d\"video\","},{"line_number":2056,"context_line":"                                                      **kwargs)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        self.type \u003d \u0027virtio\u0027"},{"line_number":2059,"context_line":"        self.vram \u003d None"},{"line_number":2060,"context_line":"        self.heads \u003d None"},{"line_number":2061,"context_line":"        self.driver_iommu \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"dd96255b_f2497330","line":2058,"in_reply_to":"258cac2e_1a719b4f","updated":"2021-08-09 10:03:41.000000000","message":"Okay, Stephen double-confirmed on IRC.  We CAN change the self.type to \u0027virtio\u0027.\n\nIn other words, when you change the self.type \u003d \u0027virtio\u0027, and if the existing instance indeed has \u0027cirrus\u0027, then it\u0027ll retain \u0027cirrus\u0027 for that instance, because those classes are used to build XML for *new* instances only.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b55eb3068d328e9f922088e668e8310be8542345","unresolved":true,"context_lines":[{"line_number":2055,"context_line":"        super(LibvirtConfigGuestVideo, self).__init__(root_name\u003d\"video\","},{"line_number":2056,"context_line":"                                                      **kwargs)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        self.type \u003d \u0027virtio\u0027"},{"line_number":2059,"context_line":"        self.vram \u003d None"},{"line_number":2060,"context_line":"        self.heads \u003d None"},{"line_number":2061,"context_line":"        self.driver_iommu \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"5262d486_b4b3a49f","line":2058,"in_reply_to":"3fd52856_23959958","updated":"2021-11-15 12:21:11.000000000","message":"yes we re create the xml using this class on hard reboot so unless we have recorded the video model before that happens it could change from cirros to virtio for existing instnace this patch is still not correct .","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"589b6b744a6551f49831718537b6e93ae0670a82","unresolved":false,"context_lines":[{"line_number":2055,"context_line":"        super(LibvirtConfigGuestVideo, self).__init__(root_name\u003d\"video\","},{"line_number":2056,"context_line":"                                                      **kwargs)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        self.type \u003d \u0027virtio\u0027"},{"line_number":2059,"context_line":"        self.vram \u003d None"},{"line_number":2060,"context_line":"        self.heads \u003d None"},{"line_number":2061,"context_line":"        self.driver_iommu \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"b5398381_454d9766","line":2058,"in_reply_to":"5262d486_b4b3a49f","updated":"2021-11-15 12:47:48.000000000","message":"Sean: As I\u0027ve said a few times, the ABI change is *harmless*, and the QEMU folks have also confirmed.  So I don\u0027t see anything wrong with the general direction here.\n\n@Gibi: you\u0027re right - on hard reboot it *will* change from \u0027cirros\u0027 to \u0027virtio\u0027, and that is acceptable, as it is benign.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"31f1b85f4dbcc7d217a6a80d6cd2b732301c826e","unresolved":true,"context_lines":[{"line_number":2055,"context_line":"        super(LibvirtConfigGuestVideo, self).__init__(root_name\u003d\"video\","},{"line_number":2056,"context_line":"                                                      **kwargs)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        self.type \u003d \u0027virtio\u0027"},{"line_number":2059,"context_line":"        self.vram \u003d None"},{"line_number":2060,"context_line":"        self.heads \u003d None"},{"line_number":2061,"context_line":"        self.driver_iommu \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"258cac2e_1a719b4f","line":2058,"in_reply_to":"56dbd637_92e96942","updated":"2021-08-09 09:51:15.000000000","message":"Thinko:\n\n\"it\u0027s the only default\" --\u003e \"it the default only ... for new instances\"","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"102733d15720b22f60c1850cb2fedcdc1229d38d","unresolved":true,"context_lines":[{"line_number":2055,"context_line":"        super(LibvirtConfigGuestVideo, self).__init__(root_name\u003d\"video\","},{"line_number":2056,"context_line":"                                                      **kwargs)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        self.type \u003d \u0027virtio\u0027"},{"line_number":2059,"context_line":"        self.vram \u003d None"},{"line_number":2060,"context_line":"        self.heads \u003d None"},{"line_number":2061,"context_line":"        self.driver_iommu \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"56dbd637_92e96942","line":2058,"in_reply_to":"6b93f9c3_db342853","updated":"2021-08-09 09:48:34.000000000","message":"Wait: as near as I see, updating this should be harmless, because it\u0027s the only default in the Python class for *new* instances.  So it should still get overridden if the actual VM has a different value.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"55e6dc3feceb2cab486fd01e95cf36c7e6d7c2d7","unresolved":true,"context_lines":[{"line_number":2055,"context_line":"        super(LibvirtConfigGuestVideo, self).__init__(root_name\u003d\"video\","},{"line_number":2056,"context_line":"                                                      **kwargs)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        self.type \u003d \u0027virtio\u0027"},{"line_number":2059,"context_line":"        self.vram \u003d None"},{"line_number":2060,"context_line":"        self.heads \u003d None"},{"line_number":2061,"context_line":"        self.driver_iommu \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"1b7eef37_e7be4076","line":2058,"in_reply_to":"6ec96673_e28804ac","updated":"2021-08-04 14:27:23.000000000","message":"I think you\u0027re saying \"not to update\" it so that it\u0027ll change it for existing instances?  Leaving it \"cirrus\" does not feel correct either.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b3ed3c3d7e48dc6dde93520cd594167beee522dc","unresolved":true,"context_lines":[{"line_number":2055,"context_line":"        super(LibvirtConfigGuestVideo, self).__init__(root_name\u003d\"video\","},{"line_number":2056,"context_line":"                                                      **kwargs)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        self.type \u003d \u0027virtio\u0027"},{"line_number":2059,"context_line":"        self.vram \u003d None"},{"line_number":2060,"context_line":"        self.heads \u003d None"},{"line_number":2061,"context_line":"        self.driver_iommu \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fd52856_23959958","line":2058,"in_reply_to":"dd96255b_f2497330","updated":"2021-11-15 11:55:47.000000000","message":"don\u0027t we rebuild the xml for hard reboot? If an instance that is hard rebooted then will it change from cirros -\u003e virtio? Is it an ABI change for the guest?","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e4e3a040e899cf3822bb37a53882443304ecd4b","unresolved":true,"context_lines":[{"line_number":4145,"context_line":"    def poll_rebooting_instances(self, timeout, instances):"},{"line_number":4146,"context_line":"        pass"},{"line_number":4147,"context_line":""},{"line_number":4148,"context_line":"    def spawn(self, context, instance, image_meta, injected_files,"},{"line_number":4149,"context_line":"              admin_password, allocations, network_info\u003dNone,"},{"line_number":4150,"context_line":"              block_device_info\u003dNone, power_on\u003dTrue, accel_info\u003dNone):"},{"line_number":4151,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"e39d5160_d6add638","line":4148,"updated":"2021-07-09 21:08:10.000000000","message":"when spawn is called during an initial vm creation the task state of the vm will be in building which is set here in _do_build_and_run_instance\nhttps://github.com/openstack/nova/blob/stable/train/nova/compute/manager.py#L2185","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e4e3a040e899cf3822bb37a53882443304ecd4b","unresolved":true,"context_lines":[{"line_number":4180,"context_line":"                # as we\u0027ll perform a redundant key manager API call later when"},{"line_number":4181,"context_line":"                # we create the domain but the alternative is an ugly mess"},{"line_number":4182,"context_line":"                crypto.ensure_vtpm_secret(context, instance)"},{"line_number":4183,"context_line":""},{"line_number":4184,"context_line":"        xml \u003d self._get_guest_xml(context, instance, network_info,"},{"line_number":4185,"context_line":"                                  disk_info, image_meta,"},{"line_number":4186,"context_line":"                                  block_device_info\u003dblock_device_info,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5be2d086_9bf33fc4","line":4183,"updated":"2021-07-09 21:08:10.000000000","message":"before we call _get_guest_xml here we should check if its a new vm and only then set the new virtio default\n\n\nif instance.vm_state \u003d\u003d vm_states.BUILDING and not ‘hw_video_model’ in image_meta:\n    image_meta.properties.hw_video_model \u003d ‘virtio’\n    instance.system_metadata.set(‘image_hw_video_model’, ‘virtio’)\n    instance.save()\n\nyou should use the constant for “virtio”  but you get the idea.\ni’m not sure if this is the correct way to set and save the image system metadata value by the way. its something like that but its simpele to find an example in the code you can copy.\n\nyou set the value in memory so its used later when the video model is bing used added to the xml and you commit it to the db explictly for future boots.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e4e3a040e899cf3822bb37a53882443304ecd4b","unresolved":true,"context_lines":[{"line_number":5920,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":5921,"context_line":"        if CONF.libvirt.virt_type \u003d\u003d \u0027parallels\u0027:"},{"line_number":5922,"context_line":"            video.type \u003d \u0027vga\u0027"},{"line_number":5923,"context_line":"        # NOTE(kchamart): \u0027virtio\u0027 is a sensible default whether or not"},{"line_number":5924,"context_line":"        # the guest has the native kernel driver (called \"virtio-gpu\" in"},{"line_number":5925,"context_line":"        # Linux) -- i.e. if the guest has the VirtIO GPU driver, it\u0027ll"},{"line_number":5926,"context_line":"        # be used; otherwise, the \u0027virtio\u0027 model will gracefully"}],"source_content_type":"text/x-python","patch_set":3,"id":"a8a6c740_64fa5630","line":5923,"updated":"2021-07-09 21:08:10.000000000","message":"this should also be un modified.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"cbd0710bf39b351d7146d04ec3051c9933e27322","unresolved":false,"context_lines":[{"line_number":5925,"context_line":"        # Linux) -- i.e. if the guest has the VirtIO GPU driver, it\u0027ll"},{"line_number":5926,"context_line":"        # be used; otherwise, the \u0027virtio\u0027 model will gracefully"},{"line_number":5927,"context_line":"        # fallback to VGA compatibiliy mode."},{"line_number":5928,"context_line":"        elif (guestarch in (fields.Architecture.I686,"},{"line_number":5929,"context_line":"                            fields.Architecture.X86_64) and not"},{"line_number":5930,"context_line":"                            CONF.spice.enabled):"},{"line_number":5931,"context_line":"            video.type \u003d \u0027virtio\u0027"},{"line_number":5932,"context_line":"        elif guestarch in (fields.Architecture.PPC,"},{"line_number":5933,"context_line":"                           fields.Architecture.PPC64,"},{"line_number":5934,"context_line":"                           fields.Architecture.PPC64LE):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ac2fda28_166226b1","line":5931,"range":{"start_line":5928,"start_character":0,"end_line":5931,"end_character":33},"updated":"2021-11-18 13:58:31.000000000","message":"You technically don\u0027t need this given the config class default is virtio now but I guess it\u0027s better to be explicit here.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e4e3a040e899cf3822bb37a53882443304ecd4b","unresolved":true,"context_lines":[{"line_number":5941,"context_line":"            video.type \u003d \u0027virtio\u0027"},{"line_number":5942,"context_line":"        elif CONF.spice.enabled:"},{"line_number":5943,"context_line":"            video.type \u003d \u0027qxl\u0027"},{"line_number":5944,"context_line":"        if image_meta.properties.get(\u0027hw_video_model\u0027):"},{"line_number":5945,"context_line":"            video.type \u003d image_meta.properties.hw_video_model"},{"line_number":5946,"context_line":"            if not self._video_model_supported(video.type):"},{"line_number":5947,"context_line":"                raise exception.InvalidVideoMode(model\u003dvideo.type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c6963859_3e5db9f5","line":5944,"updated":"2021-07-09 21:08:10.000000000","message":"the design we discussed previously on irc relies on making this the default path through this function.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"cbd0710bf39b351d7146d04ec3051c9933e27322","unresolved":false,"context_lines":[{"line_number":5941,"context_line":"            video.type \u003d \u0027virtio\u0027"},{"line_number":5942,"context_line":"        elif CONF.spice.enabled:"},{"line_number":5943,"context_line":"            video.type \u003d \u0027qxl\u0027"},{"line_number":5944,"context_line":"        if image_meta.properties.get(\u0027hw_video_model\u0027):"},{"line_number":5945,"context_line":"            video.type \u003d image_meta.properties.hw_video_model"},{"line_number":5946,"context_line":"            if not self._video_model_supported(video.type):"},{"line_number":5947,"context_line":"                raise exception.InvalidVideoMode(model\u003dvideo.type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9393abec_2c84407c","line":5944,"in_reply_to":"c6963859_3e5db9f5","updated":"2021-11-18 13:58:31.000000000","message":"Things have changed since you wrote this but it essentially is still as it overwrites anything set prior.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e4e3a040e899cf3822bb37a53882443304ecd4b","unresolved":true,"context_lines":[{"line_number":6664,"context_line":""},{"line_number":6665,"context_line":"        if self._guest_add_video_device(guest):"},{"line_number":6666,"context_line":"            self._add_video_driver(guest, image_meta, flavor)"},{"line_number":6667,"context_line":""},{"line_number":6668,"context_line":"            self._guest_add_pointer_device(guest, image_meta)"},{"line_number":6669,"context_line":"            self._guest_add_keyboard_device(guest, image_meta)"},{"line_number":6670,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"93443b56_338de71d","line":6667,"updated":"2021-07-09 21:08:10.000000000","message":"here you should save the video model returns by _add_video_model then update image_meta and save the value to the instance_system_metadata if the video mode returned is not present in the image_meta already\n\nvideo \u003d self._add_video_driver(guest, image_meta, flavor)\nif ‘hw_video_model’ not in image_meta.properties or video.type !\u003d image_meta.properties.hw_video_model:\n    instance.system_meta.set(‘image_hw_video_model’, video.type)\n    instance.save()","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"}],"releasenotes/notes/virtio-as-default-display-device-5341d3d5180036e2.yaml":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"cbd0710bf39b351d7146d04ec3051c9933e27322","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    From this release, Nova instances will get ``virtio`` as the default"},{"line_number":5,"context_line":"    display device (instead of ``cirrus``, which has many limitations)."},{"line_number":6,"context_line":"    If your guest has a native kernel (called \"virtio-gpu\" in Linux;"},{"line_number":7,"context_line":"    available since  Linux 4.4 and above) driver, then it\u0027ll be used;"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a867b469_04816581","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":21},"updated":"2021-11-18 13:58:31.000000000","message":"supernit - it\u0027s always better to reference the actual release.","commit_id":"cc59698d6903b0ed3778826d6704758294abbd69"}]}