)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e9a007cbaeac3b8b5bbe9237b2774c7ae8efa5e6","unresolved":true,"context_lines":[{"line_number":5874,"context_line":"                    compute_rp_uuid]"},{"line_number":5875,"context_line":"            else:"},{"line_number":5876,"context_line":"                # SRIOV ports are expected to have allocation on the PF2 RP"},{"line_number":5877,"context_line":"                # see _create_sriov_networking_rp_tree() for details."},{"line_number":5878,"context_line":"                expected_allocation \u003d self.sriov_dev_rp_per_host["},{"line_number":5879,"context_line":"                    compute_rp_uuid][self.PF2]"},{"line_number":5880,"context_line":"            self.assertEqual("}],"source_content_type":"text/x-python","patch_set":8,"id":"167ff68b_0e52968b","line":5877,"updated":"2021-07-20 17:36:47.000000000","message":"comments like this would be appreciated on the previous patch","commit_id":"8d84286f11b1203dbb1bf42ec15e8d536a72a7d7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9691821f0f63ecfa45cf49b69b4f77a0d9677345","unresolved":false,"context_lines":[{"line_number":5874,"context_line":"                    compute_rp_uuid]"},{"line_number":5875,"context_line":"            else:"},{"line_number":5876,"context_line":"                # SRIOV ports are expected to have allocation on the PF2 RP"},{"line_number":5877,"context_line":"                # see _create_sriov_networking_rp_tree() for details."},{"line_number":5878,"context_line":"                expected_allocation \u003d self.sriov_dev_rp_per_host["},{"line_number":5879,"context_line":"                    compute_rp_uuid][self.PF2]"},{"line_number":5880,"context_line":"            self.assertEqual("}],"source_content_type":"text/x-python","patch_set":8,"id":"5ba981da_1202b36b","line":5877,"in_reply_to":"167ff68b_0e52968b","updated":"2021-07-22 13:21:02.000000000","message":"yep, done in the previous patch","commit_id":"8d84286f11b1203dbb1bf42ec15e8d536a72a7d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e9a007cbaeac3b8b5bbe9237b2774c7ae8efa5e6","unresolved":true,"context_lines":[{"line_number":5890,"context_line":"        # we expect one for each port that has resource request"},{"line_number":5891,"context_line":"        return len("},{"line_number":5892,"context_line":"            [port for port in ports if port.get(\u0027resource_request\u0027, [])]"},{"line_number":5893,"context_line":"        )"},{"line_number":5894,"context_line":""},{"line_number":5895,"context_line":""},{"line_number":5896,"context_line":"class UnsupportedPortResourceRequestBasedSchedulingTest("}],"source_content_type":"text/x-python","patch_set":8,"id":"1668537c_9a4d5317","line":5893,"updated":"2021-07-20 17:36:47.000000000","message":"fwiw, I\u0027d be personally concerned that this could mask errors in our NeutronFixture that perhaps hardcoding would make a little more obvious. Maybe worth thinking about","commit_id":"8d84286f11b1203dbb1bf42ec15e8d536a72a7d7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9691821f0f63ecfa45cf49b69b4f77a0d9677345","unresolved":true,"context_lines":[{"line_number":5890,"context_line":"        # we expect one for each port that has resource request"},{"line_number":5891,"context_line":"        return len("},{"line_number":5892,"context_line":"            [port for port in ports if port.get(\u0027resource_request\u0027, [])]"},{"line_number":5893,"context_line":"        )"},{"line_number":5894,"context_line":""},{"line_number":5895,"context_line":""},{"line_number":5896,"context_line":"class UnsupportedPortResourceRequestBasedSchedulingTest("}],"source_content_type":"text/x-python","patch_set":8,"id":"636c379e_b18c0e03","line":5893,"in_reply_to":"1668537c_9a4d5317","updated":"2021-07-22 13:21:02.000000000","message":"The problem with hard coding is that this number is increasing by one when a port having today only a bandwidth request will get a packet rate request as well. \n\nMy goal with these refactorings are to reuse every existing bandwidth test simply by inheriting from the current test class and changing the neutron fixture in the child to return ports with multiple request groups in their resource request. Right now we have ~2000 LOC test cases that can simply be reused after these refactorings. The other way would require duplicating those tests just to bump the number of expected allocations from X to X+1.","commit_id":"8d84286f11b1203dbb1bf42ec15e8d536a72a7d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"597c8a4868adc4d35bce621fb24a6fa2bcac4868","unresolved":false,"context_lines":[{"line_number":5890,"context_line":"        # we expect one for each port that has resource request"},{"line_number":5891,"context_line":"        return len("},{"line_number":5892,"context_line":"            [port for port in ports if port.get(\u0027resource_request\u0027, [])]"},{"line_number":5893,"context_line":"        )"},{"line_number":5894,"context_line":""},{"line_number":5895,"context_line":""},{"line_number":5896,"context_line":"class UnsupportedPortResourceRequestBasedSchedulingTest("}],"source_content_type":"text/x-python","patch_set":8,"id":"7614f91a_ba290e4c","line":5893,"in_reply_to":"636c379e_b18c0e03","updated":"2021-07-27 16:22:15.000000000","message":"Ack, that seems reasonable so","commit_id":"8d84286f11b1203dbb1bf42ec15e8d536a72a7d7"}]}