)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"75e854a78e991192c16308145679c25293862de8","unresolved":false,"context_lines":[{"line_number":7362,"context_line":"        # correct volume_id returned by Cinder."},{"line_number":7363,"context_line":"        save_volume_id \u003d comp_ret[\u0027save_volume_id\u0027]"},{"line_number":7364,"context_line":"        new_cinfo[\u0027serial\u0027] \u003d save_volume_id"},{"line_number":7365,"context_line":""},{"line_number":7366,"context_line":"        # some drivers appear to use nova.virt.block_device.get_volume_id"},{"line_number":7367,"context_line":"        # to obtain volume_id so we need to make sure volume_id is correct"},{"line_number":7368,"context_line":"        if \u0027data\u0027 in new_cinfo and \u0027volume_id\u0027 in new_cinfo[\u0027data\u0027]:"},{"line_number":7369,"context_line":"            new_cinfo[\u0027data\u0027][\u0027volume_id\u0027] \u003d save_volume_id"},{"line_number":7370,"context_line":""},{"line_number":7371,"context_line":"        values \u003d {"},{"line_number":7372,"context_line":"            \u0027connection_info\u0027: jsonutils.dumps(new_cinfo),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7926f93b_0c8dd919","line":7369,"range":{"start_line":7365,"start_character":0,"end_line":7369,"end_character":59},"updated":"2021-07-02 12:34:58.000000000","message":"https://github.com/openstack/nova/blob/d03a600461db7d0fe0d6a9f522c30b890c691353/nova/virt/block_device.py#L937-L944\n\nThat falls back to the stashed serial that should be correct as you can see above on L7364. Note that we also stash the serial during volume attachment of both cinderv2 [1] and cinderv3 [2] volumes.\n\n[1] https://github.com/openstack/nova/blob/d03a600461db7d0fe0d6a9f522c30b890c691353/nova/virt/block_device.py#L487-L488\n[2] https://github.com/openstack/nova/blob/d03a600461db7d0fe0d6a9f522c30b890c691353/nova/virt/block_device.py#L574-L575","commit_id":"e0f640e7580afb87544d23eb2a4eea1ca53fa9af"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"423e857acdd1b78113ffd7ad2256b1c5a5343763","unresolved":false,"context_lines":[{"line_number":7362,"context_line":"        # correct volume_id returned by Cinder."},{"line_number":7363,"context_line":"        save_volume_id \u003d comp_ret[\u0027save_volume_id\u0027]"},{"line_number":7364,"context_line":"        new_cinfo[\u0027serial\u0027] \u003d save_volume_id"},{"line_number":7365,"context_line":""},{"line_number":7366,"context_line":"        # some drivers appear to use nova.virt.block_device.get_volume_id"},{"line_number":7367,"context_line":"        # to obtain volume_id so we need to make sure volume_id is correct"},{"line_number":7368,"context_line":"        if \u0027data\u0027 in new_cinfo and \u0027volume_id\u0027 in new_cinfo[\u0027data\u0027]:"},{"line_number":7369,"context_line":"            new_cinfo[\u0027data\u0027][\u0027volume_id\u0027] \u003d save_volume_id"},{"line_number":7370,"context_line":""},{"line_number":7371,"context_line":"        values \u003d {"},{"line_number":7372,"context_line":"            \u0027connection_info\u0027: jsonutils.dumps(new_cinfo),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3bda5599_42a25ad4","line":7369,"range":{"start_line":7365,"start_character":0,"end_line":7369,"end_character":59},"in_reply_to":"11bf2a3d_9bab7116","updated":"2021-07-05 16:33:09.000000000","message":"Can you provide a reference to that, I can\u0027t see any examples.","commit_id":"e0f640e7580afb87544d23eb2a4eea1ca53fa9af"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"41b6308f2ec867763e09fa8e0dbb16759fc5c2c7","unresolved":false,"context_lines":[{"line_number":7362,"context_line":"        # correct volume_id returned by Cinder."},{"line_number":7363,"context_line":"        save_volume_id \u003d comp_ret[\u0027save_volume_id\u0027]"},{"line_number":7364,"context_line":"        new_cinfo[\u0027serial\u0027] \u003d save_volume_id"},{"line_number":7365,"context_line":""},{"line_number":7366,"context_line":"        # some drivers appear to use nova.virt.block_device.get_volume_id"},{"line_number":7367,"context_line":"        # to obtain volume_id so we need to make sure volume_id is correct"},{"line_number":7368,"context_line":"        if \u0027data\u0027 in new_cinfo and \u0027volume_id\u0027 in new_cinfo[\u0027data\u0027]:"},{"line_number":7369,"context_line":"            new_cinfo[\u0027data\u0027][\u0027volume_id\u0027] \u003d save_volume_id"},{"line_number":7370,"context_line":""},{"line_number":7371,"context_line":"        values \u003d {"},{"line_number":7372,"context_line":"            \u0027connection_info\u0027: jsonutils.dumps(new_cinfo),"}],"source_content_type":"text/x-python","patch_set":1,"id":"11bf2a3d_9bab7116","line":7369,"range":{"start_line":7365,"start_character":0,"end_line":7369,"end_character":59},"in_reply_to":"7926f93b_0c8dd919","updated":"2021-07-05 04:27:57.000000000","message":"hmm.. that falls back to serial if volume_id does not exists in connection info.. the issue here is that connection_info has a wrong volume_id which will break detach multi-attach volume","commit_id":"e0f640e7580afb87544d23eb2a4eea1ca53fa9af"}]}